diff mbox

[RFC,1/3] gpio-rz: Port to v3.18

Message ID 1480693434-9415-2-git-send-email-jacopo@jmondi.org (mailing list archive)
State Not Applicable
Delegated to: Simon Horman
Headers show

Commit Message

Jacopo Mondi Dec. 2, 2016, 3:43 p.m. UTC
Fix invalid return value in gpio remove function

Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
---
 drivers/gpio/gpio-rz.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Chris Brandt Dec. 2, 2016, 4:23 p.m. UTC | #1
On 12/2/2016, Jacopo Mondi wrote:
> Fix invalid return value in gpio remove function
> 
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> ---
>  drivers/gpio/gpio-rz.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpio/gpio-rz.c b/drivers/gpio/gpio-rz.c index
> a933dab..cb8f785 100644
> --- a/drivers/gpio/gpio-rz.c
> +++ b/drivers/gpio/gpio-rz.c
> @@ -175,7 +175,8 @@ static int rz_gpio_remove(struct platform_device
> *pdev)  {
>  	struct rz_gpio_priv *p = platform_get_drvdata(pdev);
> 
> -	return gpiochip_remove(&p->gpio_chip);
> +	gpiochip_remove(&p->gpio_chip);
> +	return 0;
>  }
> 
>  static const struct of_device_id rz_gpio_dt_ids[] = {
> --
> 2.7.4


What tree/branch is this based off?



Chris
Jacopo Mondi Dec. 2, 2016, 5:05 p.m. UTC | #2
Hi Chris,

On 02/12/2016 17:23, Chris Brandt wrote:
> On 12/2/2016, Jacopo Mondi wrote:
>> Fix invalid return value in gpio remove function
>>
>> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
>> ---
>>  drivers/gpio/gpio-rz.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpio/gpio-rz.c b/drivers/gpio/gpio-rz.c index
>> a933dab..cb8f785 100644
>> --- a/drivers/gpio/gpio-rz.c
>> +++ b/drivers/gpio/gpio-rz.c
>> @@ -175,7 +175,8 @@ static int rz_gpio_remove(struct platform_device
>> *pdev)  {
>>  	struct rz_gpio_priv *p = platform_get_drvdata(pdev);
>>
>> -	return gpiochip_remove(&p->gpio_chip);
>> +	gpiochip_remove(&p->gpio_chip);
>> +	return 0;
>>  }
>>
>>  static const struct of_device_id rz_gpio_dt_ids[] = {
>> --
>> 2.7.4
>
>
> What tree/branch is this based off?
>

Quoting the cover letter:
The series is based on branch "genmai-gpio-and-pfc" of Geert's tree at
git://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git
and target Linux v3.18

Thanks
    j



>
>
> Chris
>
Chris Brandt Dec. 2, 2016, 5:46 p.m. UTC | #3
Hi Jacopo,

On 12/2/2016, Jacopo Mondi wrote:
> > What tree/branch is this based off?
> >
> 
> Quoting the cover letter:
> The series is based on branch "genmai-gpio-and-pfc" of Geert's tree at
> git://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git
> and target Linux v3.18
> 
> Thanks
>     j

OK. That's what I thought.


I didn't see a cover letter come through, just the 3 patches.

Chris
diff mbox

Patch

diff --git a/drivers/gpio/gpio-rz.c b/drivers/gpio/gpio-rz.c
index a933dab..cb8f785 100644
--- a/drivers/gpio/gpio-rz.c
+++ b/drivers/gpio/gpio-rz.c
@@ -175,7 +175,8 @@  static int rz_gpio_remove(struct platform_device *pdev)
 {
 	struct rz_gpio_priv *p = platform_get_drvdata(pdev);
 
-	return gpiochip_remove(&p->gpio_chip);
+	gpiochip_remove(&p->gpio_chip);
+	return 0;
 }
 
 static const struct of_device_id rz_gpio_dt_ids[] = {