From patchwork Mon Jan 23 16:04:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulrich Hecht X-Patchwork-Id: 9532907 X-Patchwork-Delegate: geert@linux-m68k.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 80E886020B for ; Mon, 23 Jan 2017 16:04:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 707C22845D for ; Mon, 23 Jan 2017 16:04:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6558A28461; Mon, 23 Jan 2017 16:04:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BEC592845D for ; Mon, 23 Jan 2017 16:04:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751520AbdAWQEg (ORCPT ); Mon, 23 Jan 2017 11:04:36 -0500 Received: from mail-wj0-f194.google.com ([209.85.210.194]:36598 "EHLO mail-wj0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751351AbdAWQEf (ORCPT ); Mon, 23 Jan 2017 11:04:35 -0500 Received: by mail-wj0-f194.google.com with SMTP id kq3so2298951wjc.3; Mon, 23 Jan 2017 08:04:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=2M6m9Un2oG83/eda5lpLM9v2rpfsVDMi7NDrRhCBjZ4=; b=cWyFGoH+fBkS2CQVQjsnL7eV8Y3i+RZBMU78pIasklNFt6X7EwHnkyksnf0U3shKxb KJemR0rVbGxfQePIPBC/GWeKPRL0Kaqyq9f2StfPOKFLK6u7n08ZnUVXCC/cw0R67K2L pFAcY0tjMZcoiEdutMewkWdtiNLnljkh40vdxzmasaRG7BISreK/PxUphqwq/+J7teNb H6mzCkmQD3Mqh1388TVpsmZkvVDbB+vCULNWoS3c2NxQxyqPBJ/CypJpvBpV2QHS2Gb4 90fpIxnQSUHHC9CF675J/a2ar2wiqdbAuThnCgyDWwKFX4Ue1pCt4lETpz8G1a52EXWF /VYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=2M6m9Un2oG83/eda5lpLM9v2rpfsVDMi7NDrRhCBjZ4=; b=HEJYlKOnDieUVo3lFYGQ1hergxvHs4JehbYFsUXeBCWWdJWUN9RPa0ygSDErPu362V JmbfS+F1zFCjeD1WavHsuya5Tv+ZyykITIzOM/hxLLs1Xw60w2wox/x/9MuEt2HUoEnK QydWSUPcQScrH8E3n793R1zfXr+1V573V6rRjxJfLzXamUPbYXlcKR/OKbbLd+5cw470 /x0LppD4kEy5EGJYk+RYloZfuDfy9bPLOGBMgppqSXqf/ukzJaysV/0/uPQhsXrfEqpD jQydhtG+QuwlX4798jvOBQ9VXYjdchX09Ov2l8ciCvYrnZlVh5LZDHBW2cBnBnIMn69U Q6pw== X-Gm-Message-State: AIkVDXLqFZJsYJC1Fj8GwWz4Uvbqu7tSIFTrIoQVIfw2l3pVEU/8hkXx+E/xoIhyDaKWww== X-Received: by 10.223.162.153 with SMTP id s25mr20095092wra.148.1485187474229; Mon, 23 Jan 2017 08:04:34 -0800 (PST) Received: from groucho.site (ipbcc0353e.dynamic.kabel-deutschland.de. [188.192.53.62]) by smtp.gmail.com with ESMTPSA id 204sm21788033wmj.7.2017.01.23.08.04.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 23 Jan 2017 08:04:33 -0800 (PST) From: Ulrich Hecht To: linux-renesas-soc@vger.kernel.org, wsa@the-dreams.de, geert@linux-m68k.org Cc: linux-serial@vger.kernel.org, magnus.damm@gmail.com, sergei.shtylyov@cogentembedded.com, Ulrich Hecht Subject: [PATCH v2 2/7] serial: sh-sci: consider DR (data ready) bit adequately Date: Mon, 23 Jan 2017 17:04:13 +0100 Message-Id: <1485187458-8195-3-git-send-email-ulrich.hecht+renesas@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1485187458-8195-1-git-send-email-ulrich.hecht+renesas@gmail.com> References: <1485187458-8195-1-git-send-email-ulrich.hecht+renesas@gmail.com> Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP To allow operation with a higher RX FIFO interrupt threshold in PIO mode, it is necessary to consider the DR bit ("FIFO not full, but no data received for 1.5 frames") as an indicator that data can be read. Otherwise the driver will let data rot in the FIFO until the threshold is reached. Signed-off-by: Ulrich Hecht Reviewed-by: Geert Uytterhoeven --- drivers/tty/serial/sh-sci.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/sh-sci.h b/drivers/tty/serial/sh-sci.h index 2c45e79..9323735 100644 --- a/drivers/tty/serial/sh-sci.h +++ b/drivers/tty/serial/sh-sci.h @@ -151,7 +151,7 @@ enum { #define SCCKS_XIN BIT(14) /* SC_CLK uses bus clock (1) or SCIF_CLK (0) */ #define SCxSR_TEND(port) (((port)->type == PORT_SCI) ? SCI_TEND : SCIF_TEND) -#define SCxSR_RDxF(port) (((port)->type == PORT_SCI) ? SCI_RDRF : SCIF_RDF) +#define SCxSR_RDxF(port) (((port)->type == PORT_SCI) ? SCI_RDRF : SCIF_DR | SCIF_RDF) #define SCxSR_TDxE(port) (((port)->type == PORT_SCI) ? SCI_TDRE : SCIF_TDFE) #define SCxSR_FER(port) (((port)->type == PORT_SCI) ? SCI_FER : SCIF_FER) #define SCxSR_PER(port) (((port)->type == PORT_SCI) ? SCI_PER : SCIF_PER)