| Message ID | 1486118300-12633-5-git-send-email-ulrich.hecht+renesas@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d5566d251f5e839e36db8db8105d8f8f57e54768 |
| Delegated to: | Simon Horman |
| Headers | show |
On Fri, Feb 03, 2017 at 11:38:20AM +0100, Ulrich Hecht wrote: > Enables the SCIF hooked up to the DEBUG1 connector. > > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Hi Ulrich, could you clarify the dependency of this patch on earlier ones in the series. Is it safe to queue this up independently of the other patches?
On Wed, Feb 8, 2017 at 11:54 AM, Simon Horman <horms@verge.net.au> wrote: > On Fri, Feb 03, 2017 at 11:38:20AM +0100, Ulrich Hecht wrote: >> Enables the SCIF hooked up to the DEBUG1 connector. >> >> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com> >> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Hi Ulrich, > > could you clarify the dependency of this patch on earlier ones in the > series. Is it safe to queue this up independently of the other patches? It does not actually depend on the other patches. I think I included it here because I used that port for testing. Should be safe. CU Uli
On Wed, Feb 08, 2017 at 12:19:55PM +0100, Ulrich Hecht wrote: > On Wed, Feb 8, 2017 at 11:54 AM, Simon Horman <horms@verge.net.au> wrote: > > On Fri, Feb 03, 2017 at 11:38:20AM +0100, Ulrich Hecht wrote: > >> Enables the SCIF hooked up to the DEBUG1 connector. > >> > >> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com> > >> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > Hi Ulrich, > > > > could you clarify the dependency of this patch on earlier ones in the > > series. Is it safe to queue this up independently of the other patches? > > It does not actually depend on the other patches. I think I included > it here because I used that port for testing. Should be safe. Thanks but I dont' seem to have scif1 in r8a7796.dtsi. Should this patch be updated to use hscif1 which is (now) present in r8a7796.dtsi?
Hi Simon, On Mon, Feb 13, 2017 at 2:05 PM, Simon Horman <horms@verge.net.au> wrote: > On Wed, Feb 08, 2017 at 12:19:55PM +0100, Ulrich Hecht wrote: >> On Wed, Feb 8, 2017 at 11:54 AM, Simon Horman <horms@verge.net.au> wrote: >> > On Fri, Feb 03, 2017 at 11:38:20AM +0100, Ulrich Hecht wrote: >> >> Enables the SCIF hooked up to the DEBUG1 connector. >> >> >> >> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com> >> >> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> >> > >> > Hi Ulrich, >> > >> > could you clarify the dependency of this patch on earlier ones in the >> > series. Is it safe to queue this up independently of the other patches? >> >> It does not actually depend on the other patches. I think I included >> it here because I used that port for testing. Should be safe. > > Thanks but I dont' seem to have scif1 in r8a7796.dtsi. > Should this patch be updated to use hscif1 which is (now) present in > r8a7796.dtsi? Nah, you just need [PATCH v2 2/3] arm64: renesas: r8a7796: Add all SCIF nodes first :-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts index f35e96c..443eb0a 100644 --- a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts +++ b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts @@ -18,6 +18,7 @@ aliases { serial0 = &scif2; + serial1 = &scif1; }; chosen { @@ -102,6 +103,11 @@ pinctrl-0 = <&scif_clk_pins>; pinctrl-names = "default"; + scif1_pins: scif1 { + groups = "scif1_data_a", "scif1_ctrl"; + function = "scif1"; + }; + scif2_pins: scif2 { groups = "scif2_data_a"; function = "scif2"; @@ -202,6 +208,14 @@ status = "okay"; }; +&scif1 { + pinctrl-0 = <&scif1_pins>; + pinctrl-names = "default"; + + uart-has-rtscts; + status = "okay"; +}; + &scif2 { pinctrl-0 = <&scif2_pins>; pinctrl-names = "default";