| Message ID | 149269961740.23335.7950127209713140684.sendpatchset@little-apple (mailing list archive) |
|---|---|
| State | Deferred |
| Headers | show |
Hi Magnus, On Thu, Apr 20, 2017 at 4:46 PM, Magnus Damm <magnus.damm@gmail.com> wrote: > From: Magnus Damm <damm+renesas@opensource.se> > > r8a7792 Blanche has depending on dip switch and jumper settings > either HSCIF0 or CAN0 exposed on the on-board CN5 connector. > > This patch adds HSCIF0 to the Blanche dts as serial2. > > Signed-off-by: Magnus Damm <damm+renesas@opensource.se> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > Currently the r8a7792 PFC is lacking support for HSCIF devices > so the PFC driver needs to be updated to avoid error messages > on the boot console. Indeed. So while you enhance hardware description, software support is still lacking. Care to submit a PFC patch? Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Thu, Apr 20, 2017 at 11:46:57PM +0900, Magnus Damm wrote: > From: Magnus Damm <damm+renesas@opensource.se> > > r8a7792 Blanche has depending on dip switch and jumper settings > either HSCIF0 or CAN0 exposed on the on-board CN5 connector. > > This patch adds HSCIF0 to the Blanche dts as serial2. > > Signed-off-by: Magnus Damm <damm+renesas@opensource.se> > --- > > Currently the r8a7792 PFC is lacking support for HSCIF devices > so the PFC driver needs to be updated to avoid error messages > on the boot console. I would rather hold off on applying this patch until the PFC driver has been enhanced. Does that sound reasonable? > arch/arm/boot/dts/r8a7792-blanche.dts | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > --- 0001/arch/arm/boot/dts/r8a7792-blanche.dts > +++ work/arch/arm/boot/dts/r8a7792-blanche.dts 2017-04-20 23:35:50.440607110 +0900 > @@ -21,6 +21,7 @@ > aliases { > serial0 = &scif0; > serial1 = &scif3; > + serial2 = &hscif0; > }; > > chosen { > @@ -207,6 +208,11 @@ > function = "scif3"; > }; > > + hscif0_pins: hscif0 { > + groups = "hscif0_data", "hscif0_ctrl"; > + function = "hscif0"; > + }; > + > lan89218_pins: lan89218 { > intc { > groups = "intc_irq0"; > @@ -253,6 +259,14 @@ > status = "okay"; > }; > > +&hscif0 { > + pinctrl-0 = <&hscif0_pins>; > + pinctrl-names = "default"; > + > + uart-has-rtscts; > + status = "okay"; > +}; > + > &can0 { > pinctrl-0 = <&can0_pins>; > pinctrl-names = "default"; >
--- 0001/arch/arm/boot/dts/r8a7792-blanche.dts +++ work/arch/arm/boot/dts/r8a7792-blanche.dts 2017-04-20 23:35:50.440607110 +0900 @@ -21,6 +21,7 @@ aliases { serial0 = &scif0; serial1 = &scif3; + serial2 = &hscif0; }; chosen { @@ -207,6 +208,11 @@ function = "scif3"; }; + hscif0_pins: hscif0 { + groups = "hscif0_data", "hscif0_ctrl"; + function = "hscif0"; + }; + lan89218_pins: lan89218 { intc { groups = "intc_irq0"; @@ -253,6 +259,14 @@ status = "okay"; }; +&hscif0 { + pinctrl-0 = <&hscif0_pins>; + pinctrl-names = "default"; + + uart-has-rtscts; + status = "okay"; +}; + &can0 { pinctrl-0 = <&can0_pins>; pinctrl-names = "default";