| Message ID | 1493721024-15042-1-git-send-email-horms+renesas@verge.net.au (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 133ace3f38045968b971b3ac62da495c54de49a6 |
| Delegated to: | Simon Horman |
| Headers | show |
Hi Simon, On Tue, May 2, 2017 at 12:30 PM, Simon Horman <horms+renesas@verge.net.au> wrote: > The EthernetAVB should not depend on the bootloader to setup correct > drive-strength values. Values for drive-strength where found by > examining the registers after the bootloader has configured the > registers and successfully used the EthernetAVB. > > Based on: > * commit 7d73a4da2681 ("arm64: dts: r8a7795: salvator-x: Set drive-strength > for ravb pins") > * commit 4903987033be ("arm64: dts: r8a7796: salvator-x: Set drive-strength > for ravb pins") > > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > Cc: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > * Compile tested only due to lack of hardware access So how did you examine the registers? ;-) Hence I examined the registers myself: - H3ULCB has the same register settings as Salvator-X with H3 ES1.0 - M3ULCB has the same register settings as Salvator-X with M3-W ES1.0 or H3 ES2.0. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Fri, May 12, 2017 at 04:39:03PM +0200, Geert Uytterhoeven wrote: > Hi Simon, > > On Tue, May 2, 2017 at 12:30 PM, Simon Horman > <horms+renesas@verge.net.au> wrote: > > The EthernetAVB should not depend on the bootloader to setup correct > > drive-strength values. Values for drive-strength where found by > > examining the registers after the bootloader has configured the > > registers and successfully used the EthernetAVB. > > > > Based on: > > * commit 7d73a4da2681 ("arm64: dts: r8a7795: salvator-x: Set drive-strength > > for ravb pins") > > * commit 4903987033be ("arm64: dts: r8a7796: salvator-x: Set drive-strength > > for ravb pins") > > > > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > > Cc: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > * Compile tested only due to lack of hardware access > > So how did you examine the registers? ;-) You got me there: copy-paste gone wrong. > Hence I examined the registers myself: > - H3ULCB has the same register settings as Salvator-X with H3 ES1.0 > - M3ULCB has the same register settings as Salvator-X with M3-W ES1.0 > or H3 ES2.0. That was my assumption, which is what I should have written. But as you have checked - thanks for that - I will leave the changelog as-is and queue up the patch.
diff --git a/arch/arm64/boot/dts/renesas/ulcb.dtsi b/arch/arm64/boot/dts/renesas/ulcb.dtsi index 7669b282bde2..a38d68c4d9a6 100644 --- a/arch/arm64/boot/dts/renesas/ulcb.dtsi +++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi @@ -199,8 +199,22 @@ pinctrl-names = "default"; avb_pins: avb { - groups = "avb_mdc"; - function = "avb"; + mux { + groups = "avb_link", "avb_phy_int", "avb_mdc", + "avb_mii"; + function = "avb"; + }; + + pins_mdc { + groups = "avb_mdc"; + drive-strength = <24>; + }; + + pins_mii_tx { + pins = "PIN_AVB_TX_CTL", "PIN_AVB_TXC", "PIN_AVB_TD0", + "PIN_AVB_TD1", "PIN_AVB_TD2", "PIN_AVB_TD3"; + drive-strength = <12>; + }; }; i2c2_pins: i2c2 {
The EthernetAVB should not depend on the bootloader to setup correct drive-strength values. Values for drive-strength where found by examining the registers after the bootloader has configured the registers and successfully used the EthernetAVB. Based on: * commit 7d73a4da2681 ("arm64: dts: r8a7795: salvator-x: Set drive-strength for ravb pins") * commit 4903987033be ("arm64: dts: r8a7796: salvator-x: Set drive-strength for ravb pins") Cc: Geert Uytterhoeven <geert+renesas@glider.be> Cc: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- * Compile tested only due to lack of hardware access --- arch/arm64/boot/dts/renesas/ulcb.dtsi | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-)