diff mbox

[PATCH/RFC,2/5] mmc: tmio: rename tmio_mmc_{pio => core}.c

Message ID 1493723743-22821-3-git-send-email-horms+renesas@verge.net.au (mailing list archive)
State Superseded
Delegated to: Geert Uytterhoeven
Headers show

Commit Message

Simon Horman May 2, 2017, 11:15 a.m. UTC 
Rename tmio_mmc_pio.c to tmio_mmc_core.c to more accurately reflect its
function: to provide core code for the tmio-mmc and sh-mobole-sdhi drivers.

Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 drivers/mmc/host/Makefile                            | 1 -
 drivers/mmc/host/{tmio_mmc_pio.c => tmio_mmc_core.c} | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)
 rename drivers/mmc/host/{tmio_mmc_pio.c => tmio_mmc_core.c} (99%)

Comments

Wolfram Sang May 2, 2017, 1:11 p.m. UTC | #1 
> - * linux/drivers/mmc/host/tmio_mmc_pio.c
> + * linux/drivers/mmc/host/tmio_mmc_core.c

I think we should drop the filenames here (and in other places)  and use
a human readable string instead?
Simon Horman May 9, 2017, 1:14 p.m. UTC | #2 
On Tue, May 02, 2017 at 03:11:32PM +0200, Wolfram Sang wrote:
> 
> > - * linux/drivers/mmc/host/tmio_mmc_pio.c
> > + * linux/drivers/mmc/host/tmio_mmc_core.c
> 
> I think we should drop the filenames here (and in other places)  and use
> a human readable string instead?

Sure, I've shuffled around the comments at the top of the source files
accordingly.
diff mbox

Patch

diff --git a/drivers/mmc/host/Makefile b/drivers/mmc/host/Makefile
index f11b3d4b121d..f9baa943b470 100644
--- a/drivers/mmc/host/Makefile
+++ b/drivers/mmc/host/Makefile
@@ -36,7 +36,6 @@  obj-$(CONFIG_MMC_S3C)   	+= s3cmci.o
 obj-$(CONFIG_MMC_SDRICOH_CS)	+= sdricoh_cs.o
 obj-$(CONFIG_MMC_TMIO)		+= tmio_mmc.o
 obj-$(CONFIG_MMC_TMIO_CORE)	+= tmio_mmc_core.o
-tmio_mmc_core-y			:= tmio_mmc_pio.o
 obj-$(CONFIG_MMC_SDHI)		+= sh_mobile_sdhi.o tmio_mmc_dma.o
 obj-$(CONFIG_MMC_CB710)		+= cb710-mmc.o
 obj-$(CONFIG_MMC_VIA_SDMMC)	+= via-sdmmc.o
diff --git a/drivers/mmc/host/tmio_mmc_pio.c b/drivers/mmc/host/tmio_mmc_core.c
similarity index 99%
rename from drivers/mmc/host/tmio_mmc_pio.c
rename to drivers/mmc/host/tmio_mmc_core.c
index 96905c7187f0..d5c23496c499 100644
--- a/drivers/mmc/host/tmio_mmc_pio.c
+++ b/drivers/mmc/host/tmio_mmc_core.c
@@ -1,5 +1,5 @@ 
 /*
- * linux/drivers/mmc/host/tmio_mmc_pio.c
+ * linux/drivers/mmc/host/tmio_mmc_core.c
  *
  * Copyright (C) 2016 Sang Engineering, Wolfram Sang
  * Copyright (C) 2015-16 Renesas Electronics Corporation