| Message ID | 1497625049-46802-1-git-send-email-biju.das@bp.renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Simon Horman |
| Headers | show |
Hi Biju, On Fri, Jun 16, 2017 at 4:57 PM, Biju Das <biju.das@bp.renesas.com> wrote: > Adding pinctrl support for scif0 interface. > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> The patch looks good to me, but without schematics, we cannot verify the actual pins used. Are the schematics somewhere available? Having access to them would allow us doing a better job reviewing your DTS patches. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Mon, Jun 19, 2017 at 10:42:18AM +0200, Geert Uytterhoeven wrote: > Hi Biju, > > On Fri, Jun 16, 2017 at 4:57 PM, Biju Das <biju.das@bp.renesas.com> wrote: > > Adding pinctrl support for scif0 interface. > > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > The patch looks good to me, but without schematics, we cannot verify the > actual pins used. > > Are the schematics somewhere available? Having access to them would allow us > doing a better job reviewing your DTS patches. Echoing Geert's request, it would be great to be able to compare the DT description against some documentation. My understanding is that this patch depends on "[PATCH v2 0/3] Add R8A7743/SK-RZG1M PFC support" which in turn depends on pfc driver support which is on target to be included in v4.13-rc1. Accordingly I have marked this patch as deferred. Please repost or otherwise ping me once the driver dependency is present in an rc release. Thanks.
Hello Simon, > On Mon, Jun 19, 2017 at 10:42:18AM +0200, Geert Uytterhoeven wrote: > > Hi Biju, > > > > On Fri, Jun 16, 2017 at 4:57 PM, Biju Das <biju.das@bp.renesas.com> > wrote: > > > Adding pinctrl support for scif0 interface. > > > > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > > > The patch looks good to me, but without schematics, we cannot verify > > the actual pins used. > > > > Are the schematics somewhere available? Having access to them would > > allow us doing a better job reviewing your DTS patches. > > Echoing Geert's request, it would be great to be able to compare the DT > description against some documentation. > > My understanding is that this patch depends on "[PATCH v2 0/3] Add > R8A7743/SK-RZG1M PFC support" which in turn depends on pfc driver > support which is on target to be included in v4.13-rc1. > > Accordingly I have marked this patch as deferred. Please repost or otherwise > ping me once the driver dependency is present in an rc release. Thanks. I will repost/ping you once the pfc driver dependency is present in an rc release. Regards, Biju Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
diff --git a/arch/arm/boot/dts/r8a7743-iwg20d-q7.dts b/arch/arm/boot/dts/r8a7743-iwg20d-q7.dts index 9b54783..497aec0 100644 --- a/arch/arm/boot/dts/r8a7743-iwg20d-q7.dts +++ b/arch/arm/boot/dts/r8a7743-iwg20d-q7.dts @@ -20,6 +20,16 @@ }; }; +&pfc { + scif0_pins: scif0 { + groups = "scif0_data_d"; + function = "scif0"; + }; +}; + &scif0 { + pinctrl-0 = <&scif0_pins>; + pinctrl-names = "default"; + status = "okay"; };
Adding pinctrl support for scif0 interface. Signed-off-by: Biju Das <biju.das@bp.renesas.com> --- This patch is been tested against linux-next tag next-20170616. It depends upon the patch "[PATCH v2 1/3] ARM: dts: r8a7743: add PFC support" https://www.spinics.net/lists/arm-kernel/msg577301.html arch/arm/boot/dts/r8a7743-iwg20d-q7.dts | 10 ++++++++++ 1 file changed, 10 insertions(+)