| Message ID | 1499259711-56175-2-git-send-email-biju.das@bp.renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
Hello! On 07/05/2017 04:01 PM, Biju Das wrote: > Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC. > Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the R-Car Gen2 > family. > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com> [...] > diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c > index 5931e85..e35b30f 100644 > --- a/drivers/net/ethernet/renesas/ravb_main.c > +++ b/drivers/net/ethernet/renesas/ravb_main.c > @@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct ravb_private *priv) > } > > static const struct of_device_id ravb_match_table[] = { > + { .compatible = "renesas,etheravb-r8a7743", .data = (void *)RCAR_GEN2 }, No, this shouldn't be needed if you specify "renesas,etheravb-rcar-gen2". > { .compatible = "renesas,etheravb-r8a7790", .data = (void *)RCAR_GEN2 }, > { .compatible = "renesas,etheravb-r8a7794", .data = (void *)RCAR_GEN2 }, > { .compatible = "renesas,etheravb-rcar-gen2", .data = (void *)RCAR_GEN2 }, MBR, Sergei
Hi Biju, On Wed, Jul 5, 2017 at 3:01 PM, Biju Das <biju.das@bp.renesas.com> wrote: > Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC. > Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the R-Car Gen2 > family. > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com> Thanks for your patch! > --- a/drivers/net/ethernet/renesas/ravb_main.c > +++ b/drivers/net/ethernet/renesas/ravb_main.c > @@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct ravb_private *priv) > } > > static const struct of_device_id ravb_match_table[] = { > + { .compatible = "renesas,etheravb-r8a7743", .data = (void *)RCAR_GEN2 }, > { .compatible = "renesas,etheravb-r8a7790", .data = (void *)RCAR_GEN2 }, > { .compatible = "renesas,etheravb-r8a7794", .data = (void *)RCAR_GEN2 }, > { .compatible = "renesas,etheravb-rcar-gen2", .data = (void *)RCAR_GEN2 }, As Sergei already mentioned, a driver update is not needed due to the presence of family-specific compatible values. Please drop that part, and you can add my: Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hello Geert, Sergei, > From: geert.uytterhoeven@gmail.com > [mailto:geert.uytterhoeven@gmail.com] On Behalf Of Geert Uytterhoeven > Sent: 05 July 2017 14:47 > > Hi Biju, > > On Wed, Jul 5, 2017 at 3:01 PM, Biju Das <biju.das@bp.renesas.com> wrote: > > Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC. > > Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the R-Car > > Gen2 family. > > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com> > > Thanks for your patch! > > > --- a/drivers/net/ethernet/renesas/ravb_main.c > > +++ b/drivers/net/ethernet/renesas/ravb_main.c > > @@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct ravb_private > > *priv) } > > > > static const struct of_device_id ravb_match_table[] = { > > + { .compatible = "renesas,etheravb-r8a7743", .data = (void > > + *)RCAR_GEN2 }, > > { .compatible = "renesas,etheravb-r8a7790", .data = (void > *)RCAR_GEN2 }, > > { .compatible = "renesas,etheravb-r8a7794", .data = (void > *)RCAR_GEN2 }, > > { .compatible = "renesas,etheravb-rcar-gen2", .data = (void > > *)RCAR_GEN2 }, > > As Sergei already mentioned, a driver update is not needed due to the > presence of family-specific compatible values. > Please drop that part, and you can add my: > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Should the other compatible values (r8a7790, 94 etc) be removed then? Or are they needed for backwards compatibility? Kind regards, Chris > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
Hi Chris, On Wed, Jul 5, 2017 at 3:51 PM, Chris Paterson <Chris.Paterson2@renesas.com> wrote: >> From: geert.uytterhoeven@gmail.com >> [mailto:geert.uytterhoeven@gmail.com] On Behalf Of Geert Uytterhoeven >> Sent: 05 July 2017 14:47 >> On Wed, Jul 5, 2017 at 3:01 PM, Biju Das <biju.das@bp.renesas.com> wrote: >> > Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC. >> > Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the R-Car >> > Gen2 family. >> > >> > Signed-off-by: Biju Das <biju.das@bp.renesas.com> >> > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com> >> >> Thanks for your patch! >> >> > --- a/drivers/net/ethernet/renesas/ravb_main.c >> > +++ b/drivers/net/ethernet/renesas/ravb_main.c >> > @@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct ravb_private >> > *priv) } >> > >> > static const struct of_device_id ravb_match_table[] = { >> > + { .compatible = "renesas,etheravb-r8a7743", .data = (void >> > + *)RCAR_GEN2 }, >> > { .compatible = "renesas,etheravb-r8a7790", .data = (void >> *)RCAR_GEN2 }, >> > { .compatible = "renesas,etheravb-r8a7794", .data = (void >> *)RCAR_GEN2 }, >> > { .compatible = "renesas,etheravb-rcar-gen2", .data = (void >> > *)RCAR_GEN2 }, >> >> As Sergei already mentioned, a driver update is not needed due to the >> presence of family-specific compatible values. >> Please drop that part, and you can add my: >> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Should the other compatible values (r8a7790, 94 etc) be removed then? Or are they needed for backwards compatibility? The other compatible values in DT bindings and DTS files should be kept, to allow handling of SoC-specific quirks if/when they are ever detected. The other compatible values in the driver should be kept for backwards-compatibility with old DTB files that lack the (newer) family-specific compatible values. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hello Geert, > From: geert.uytterhoeven@gmail.com > [mailto:geert.uytterhoeven@gmail.com] On Behalf Of Geert Uytterhoeven > Sent: 05 July 2017 15:56 > > Hi Chris, > > On Wed, Jul 5, 2017 at 3:51 PM, Chris Paterson > <Chris.Paterson2@renesas.com> wrote: > >> From: geert.uytterhoeven@gmail.com > >> [mailto:geert.uytterhoeven@gmail.com] On Behalf Of Geert > Uytterhoeven > >> Sent: 05 July 2017 14:47 > >> On Wed, Jul 5, 2017 at 3:01 PM, Biju Das <biju.das@bp.renesas.com> > wrote: > >> > Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC. > >> > Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the > >> > R-Car > >> > Gen2 family. > >> > > >> > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > >> > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com> > >> > >> Thanks for your patch! > >> > >> > --- a/drivers/net/ethernet/renesas/ravb_main.c > >> > +++ b/drivers/net/ethernet/renesas/ravb_main.c > >> > @@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct > >> > ravb_private > >> > *priv) } > >> > > >> > static const struct of_device_id ravb_match_table[] = { > >> > + { .compatible = "renesas,etheravb-r8a7743", .data = (void > >> > + *)RCAR_GEN2 }, > >> > { .compatible = "renesas,etheravb-r8a7790", .data = (void > >> *)RCAR_GEN2 }, > >> > { .compatible = "renesas,etheravb-r8a7794", .data = (void > >> *)RCAR_GEN2 }, > >> > { .compatible = "renesas,etheravb-rcar-gen2", .data = (void > >> > *)RCAR_GEN2 }, > >> > >> As Sergei already mentioned, a driver update is not needed due to the > >> presence of family-specific compatible values. > >> Please drop that part, and you can add my: > >> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > Should the other compatible values (r8a7790, 94 etc) be removed then? Or > are they needed for backwards compatibility? > > The other compatible values in DT bindings and DTS files should be kept, to > allow handling of SoC-specific quirks if/when they are ever detected. > > The other compatible values in the driver should be kept for backwards- > compatibility with old DTB files that lack the (newer) family-specific > compatible values. Thank you for the comprehensive answer. Kind regards, Chris > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
> -----Original Message----- > From: devicetree-owner@vger.kernel.org [mailto:devicetree- > owner@vger.kernel.org] On Behalf Of Sergei Shtylyov > Sent: 05 July 2017 14:21 > To: Biju Das <biju.das@bp.renesas.com>; Rob Herring <robh+dt@kernel.org>; > Mark Rutland <mark.rutland@arm.com>; Russell King > <linux@armlinux.org.uk> > Cc: Simon Horman <horms@verge.net.au>; Magnus Damm > <magnus.damm@gmail.com>; Chris Paterson > <Chris.Paterson2@renesas.com>; devicetree@vger.kernel.org; linux-renesas- > soc@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > netdev@vger.kernel.org > Subject: Re: [PATCH v 1/2] ravb: Add support for r8a7743 SoC > > Hello! > > On 07/05/2017 04:01 PM, Biju Das wrote: > > > Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC. > > Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the R-Car > > Gen2 family. > > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com> > [...] > > diff --git a/drivers/net/ethernet/renesas/ravb_main.c > > b/drivers/net/ethernet/renesas/ravb_main.c > > index 5931e85..e35b30f 100644 > > --- a/drivers/net/ethernet/renesas/ravb_main.c > > +++ b/drivers/net/ethernet/renesas/ravb_main.c > > @@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct ravb_private > > *priv) } > > > > static const struct of_device_id ravb_match_table[] = { > > +{ .compatible = "renesas,etheravb-r8a7743", .data = (void > > +*)RCAR_GEN2 }, > > No, this shouldn't be needed if you specify "renesas,etheravb-rcar-gen2". > Thanks for the review. I will remove this change. > > { .compatible = "renesas,etheravb-r8a7790", .data = (void > *)RCAR_GEN2 }, > > { .compatible = "renesas,etheravb-r8a7794", .data = (void > *)RCAR_GEN2 }, > > { .compatible = "renesas,etheravb-rcar-gen2", .data = (void > > *)RCAR_GEN2 }, > > MBR, Sergei > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in the body > of a message to majordomo@vger.kernel.org More majordomo info at > http://vger.kernel.org/majordomo-info.html Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
Hi All, This series aims to upstream the Ethernet AVB driver support for RZ/G1M (r8a7743) SoC . The iWave RZ/G1M Qseven SOM supports Gigabit Ethernet Phy from Micrel(KSZ9031MNX). Gigabit Ethernet support is available in Renesas AVB driver. This series has been tested against linux-next tag next-20170704. Modifications: v1->v2 -Dropped the driver update,as is it not needed due to the presence of family-specific compatible values. -Added Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> for the DT binding patch -Added Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> for the defconfig: Enable Ethernet AVB patch History: ------- [v1]: https://www.spinics.net/lists/arm-kernel/msg592366.html Biju Das (2): ravb: Document binding for r8a7743 SoC ARM: shmobile: defconfig: Enable Ethernet AVB Documentation/devicetree/bindings/net/renesas,ravb.txt | 3 ++- arch/arm/configs/shmobile_defconfig | 1 + 2 files changed, 3 insertions(+), 1 deletion(-)
On Wed, Jul 05, 2017 at 02:01:50PM +0100, Biju Das wrote: > Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC. > Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the R-Car Gen2 > family. For the subject: "dt-bindings: net: ..." > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com> > --- > Documentation/devicetree/bindings/net/renesas,ravb.txt | 3 ++- > drivers/net/ethernet/renesas/ravb_main.c | 1 + > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt > index b519503..bc692ab 100644 > --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt > +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt > @@ -4,7 +4,8 @@ This file provides information on what the device node for the Ethernet AVB > interface contains. > > Required properties: > -- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC. > +- compatible: "renesas,etheravb-r8a7743" if the device is a part of R8A7743 SoC. > + "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC. Please re-format like this: - compatible: Must be one of: ... So it's a one line change to add new compatibles. > "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC. > "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC. > "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC. > diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c > index 5931e85..e35b30f 100644 > --- a/drivers/net/ethernet/renesas/ravb_main.c > +++ b/drivers/net/ethernet/renesas/ravb_main.c > @@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct ravb_private *priv) > } > > static const struct of_device_id ravb_match_table[] = { > + { .compatible = "renesas,etheravb-r8a7743", .data = (void *)RCAR_GEN2 }, > { .compatible = "renesas,etheravb-r8a7790", .data = (void *)RCAR_GEN2 }, > { .compatible = "renesas,etheravb-r8a7794", .data = (void *)RCAR_GEN2 }, > { .compatible = "renesas,etheravb-rcar-gen2", .data = (void *)RCAR_GEN2 }, > -- > 1.9.1 >
Hello, Thanks for the review. > -----Original Message----- > From: Rob Herring [mailto:robh@kernel.org] > Sent: 10 July 2017 02:20 > To: Biju Das <biju.das@bp.renesas.com> > Cc: Mark Rutland <mark.rutland@arm.com>; Russell King > <linux@armlinux.org.uk>; Sergei Shtylyov > <sergei.shtylyov@cogentembedded.com>; Simon Horman > <horms@verge.net.au>; Magnus Damm <magnus.damm@gmail.com>; Chris > Paterson <Chris.Paterson2@renesas.com>; devicetree@vger.kernel.org; linux- > renesas-soc@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > netdev@vger.kernel.org > Subject: Re: [PATCH v 1/2] ravb: Add support for r8a7743 SoC > > On Wed, Jul 05, 2017 at 02:01:50PM +0100, Biju Das wrote: > > Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC. > > Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the R-Car > > Gen2 family. > > For the subject: "dt-bindings: net: ..." I will change the subject to "dt-bindings: net: ravb: .. > > > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com> > > --- > > Documentation/devicetree/bindings/net/renesas,ravb.txt | 3 ++- > > drivers/net/ethernet/renesas/ravb_main.c | 1 + > > 2 files changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt > > b/Documentation/devicetree/bindings/net/renesas,ravb.txt > > index b519503..bc692ab 100644 > > --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt > > +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt > > @@ -4,7 +4,8 @@ This file provides information on what the device node > > for the Ethernet AVB interface contains. > > > > Required properties: > > -- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 > SoC. > > +- compatible: "renesas,etheravb-r8a7743" if the device is a part of R8A7743 > SoC. > > + "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC. > > Please re-format like this: > > - compatible: Must be one of: > ... > Ok. I will change this as well. > So it's a one line change to add new compatibles. > > > "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC. > > "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC. > > "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC. > > diff --git a/drivers/net/ethernet/renesas/ravb_main.c > > b/drivers/net/ethernet/renesas/ravb_main.c > > index 5931e85..e35b30f 100644 > > --- a/drivers/net/ethernet/renesas/ravb_main.c > > +++ b/drivers/net/ethernet/renesas/ravb_main.c > > @@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct ravb_private > > *priv) } > > > > static const struct of_device_id ravb_match_table[] = { > > +{ .compatible = "renesas,etheravb-r8a7743", .data = (void > > +*)RCAR_GEN2 }, > > { .compatible = "renesas,etheravb-r8a7790", .data = (void > *)RCAR_GEN2 }, > > { .compatible = "renesas,etheravb-r8a7794", .data = (void > *)RCAR_GEN2 }, > > { .compatible = "renesas,etheravb-rcar-gen2", .data = (void > > *)RCAR_GEN2 }, > > -- > > 1.9.1 > > Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
Hello! On 7/10/2017 4:20 AM, Rob Herring wrote: >> Add support for Gigabit Ethernet E-MAC on r8a7743 (RZ/G1M) SoC. >> Renesas RZ/G1M (R8A7743) SoC Ethernet AVB IP is identical to the R-Car Gen2 >> family. > > For the subject: "dt-bindings: net: ..." > >> >> Signed-off-by: Biju Das <biju.das@bp.renesas.com> >> Reviewed-by: Chris Paterson <chris.paterson2@renesas.com> >> --- >> Documentation/devicetree/bindings/net/renesas,ravb.txt | 3 ++- >> drivers/net/ethernet/renesas/ravb_main.c | 1 + >> 2 files changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt >> index b519503..bc692ab 100644 >> --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt >> +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt >> @@ -4,7 +4,8 @@ This file provides information on what the device node for the Ethernet AVB >> interface contains. >> >> Required properties: >> -- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC. >> +- compatible: "renesas,etheravb-r8a7743" if the device is a part of R8A7743 SoC. >> + "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC. > > Please re-format like this: > > - compatible: Must be one of: > ... > > So it's a one line change to add new compatibles. Note that the common gen2/3 values are at end of this list, so they'll need different treating if you add these words. MBR, Sergei
diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt b/Documentation/devicetree/bindings/net/renesas,ravb.txt index b519503..bc692ab 100644 --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt @@ -4,7 +4,8 @@ This file provides information on what the device node for the Ethernet AVB interface contains. Required properties: -- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC. +- compatible: "renesas,etheravb-r8a7743" if the device is a part of R8A7743 SoC. + "renesas,etheravb-r8a7790" if the device is a part of R8A7790 SoC. "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC. "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC. "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC. diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c index 5931e85..e35b30f 100644 --- a/drivers/net/ethernet/renesas/ravb_main.c +++ b/drivers/net/ethernet/renesas/ravb_main.c @@ -1869,6 +1869,7 @@ static int ravb_mdio_release(struct ravb_private *priv) } static const struct of_device_id ravb_match_table[] = { + { .compatible = "renesas,etheravb-r8a7743", .data = (void *)RCAR_GEN2 }, { .compatible = "renesas,etheravb-r8a7790", .data = (void *)RCAR_GEN2 }, { .compatible = "renesas,etheravb-r8a7794", .data = (void *)RCAR_GEN2 }, { .compatible = "renesas,etheravb-rcar-gen2", .data = (void *)RCAR_GEN2 },