[1/6] arm64: dts: renesas: ulcb: Enable I2C4

Commit Message

Vladimir Barinov July 7, 2017, 2:09 a.m. UTC

From: Vladimir Barinov <[e-mail]>

This enables I2C4 for ULCB board

Signed-off-by: Vladimir Barinov <[e-mail]>
---
 arch/arm64/boot/dts/renesas/ulcb.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Geert Uytterhoeven July 10, 2017, 8:20 a.m. UTC | #1

On Fri, Jul 7, 2017 at 4:09 AM, Vladimir Barinov
<[e-mail]> wrote:
> From: Vladimir Barinov <[e-mail]>
>
> This enables I2C4 for ULCB board
>
> Signed-off-by: Vladimir Barinov <[e-mail]>

Reviewed-by: Geert Uytterhoeven <[e-mail]>

> --- a/arch/arm64/boot/dts/renesas/ulcb.dtsi
> +++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi
> @@ -189,6 +189,12 @@
>         };
>  };
>
> +&i2c4 {
> +       status = "okay";
> +
> +       clock-frequency = <400000>;

Is this a bus limitation, or a limitation for the VC6 that's added in a later
patch?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [e-mail]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Simon Horman July 10, 2017, 8:33 a.m. UTC | #2

On Mon, Jul 10, 2017 at 10:20:02AM +0200, Geert Uytterhoeven wrote:
> On Fri, Jul 7, 2017 at 4:09 AM, Vladimir Barinov
> <[e-mail]> wrote:
> > From: Vladimir Barinov <[e-mail]>
> >
> > This enables I2C4 for ULCB board
> >
> > Signed-off-by: Vladimir Barinov <[e-mail]>
> 
> Reviewed-by: Geert Uytterhoeven <[e-mail]>

Thanks, applied.

FWIIW, I only got this one patch of this series.

> 
> > --- a/arch/arm64/boot/dts/renesas/ulcb.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi
> > @@ -189,6 +189,12 @@
> >         };
> >  };
> >
> > +&i2c4 {
> > +       status = "okay";
> > +
> > +       clock-frequency = <400000>;
> 
> Is this a bus limitation, or a limitation for the VC6 that's added in a later
> patch?
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [e-mail]
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
>

Geert Uytterhoeven July 10, 2017, 8:39 a.m. UTC | #3

Hi Simon

On Mon, Jul 10, 2017 at 10:33 AM, Simon Horman <[e-mail]> wrote:
> FWIIW, I only got this one patch of this series.

I believe the others have an "x/5" prefix. instead of "x/6".

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [e-mail]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Simon Horman July 10, 2017, 9:20 a.m. UTC | #4

On Mon, Jul 10, 2017 at 10:39:14AM +0200, Geert Uytterhoeven wrote:
> Hi Simon
> 
> On Mon, Jul 10, 2017 at 10:33 AM, Simon Horman <[e-mail]> wrote:
> > FWIIW, I only got this one patch of this series.
> 
> I believe the others have an "x/5" prefix. instead of "x/6".

Thanks, I see them.

Vladimir Barinov July 10, 2017, 4:04 p.m. UTC | #5

Hi Geert,

Thank you for review!

On 10.07.2017 11:20, Geert Uytterhoeven wrote:
> On Fri, Jul 7, 2017 at 4:09 AM, Vladimir Barinov
> <[e-mail]> wrote:
>> From: Vladimir Barinov <[e-mail]>
>>
>> This enables I2C4 for ULCB board
>>
>> Signed-off-by: Vladimir Barinov <[e-mail]>
> Reviewed-by: Geert Uytterhoeven <[e-mail]>
>
>> --- a/arch/arm64/boot/dts/renesas/ulcb.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi
>> @@ -189,6 +189,12 @@
>>          };
>>   };
>>
>> +&i2c4 {
>> +       status = "okay";
>> +
>> +       clock-frequency = <400000>;
> Is this a bus limitation, or a limitation for the VC6 that's added in a later
> patch?
Yes, IDT VC5 clock generator supports up to 400kHz.

I've explicitly set 400kHz as default since the documentation says that 
the default value is 100kHz if 'clock-frequency' not set:
Documentation/devicetree/bindings/i2c/i2c-rcar.txt

Regards,
Vladimir

Patch

diff --git a/arch/arm64/boot/dts/renesas/ulcb.dtsi b/arch/arm64/boot/dts/renesas/ulcb.dtsi
index 6e5ffc8..e402f16f 100644
--- a/arch/arm64/boot/dts/renesas/ulcb.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi
@@ -189,6 +189,12 @@ 
 	};
 };
 
+&i2c4 {
+	status = "okay";
+
+	clock-frequency = <400000>;
+};
+
 &i2c_dvfs {
 	status = "okay";
 };