| Message ID | 1499395019-14261-1-git-send-email-vladimir.barinov@cogentembedded.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 342001fd224052104342bcf377a217c9b6d02da0 |
| Delegated to: | Simon Horman |
| Headers | show |
On Fri, Jul 7, 2017 at 4:36 AM, Vladimir Barinov <vladimir.barinov@cogentembedded.com> wrote: > From: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com> > > The DU0/DU1/DU2/DU3 external dot clocks are generated by an I2C-controlled > programmable clock generator. > > Clock generator is available on both the H3 and M3-W ULCB boards. > Add this to the ulcb.dtsi file. > > Signed-off-by: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Fri, Jul 07, 2017 at 05:36:59AM +0300, Vladimir Barinov wrote: > From: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com> > > The DU0/DU1/DU2/DU3 external dot clocks are generated by an I2C-controlled > programmable clock generator. > > Clock generator is available on both the H3 and M3-W ULCB boards. > Add this to the ulcb.dtsi file. > > Signed-off-by: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com> > --- > arch/arm64/boot/dts/renesas/ulcb.dtsi | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/ulcb.dtsi b/arch/arm64/boot/dts/renesas/ulcb.dtsi > index e402f16f..6f0a7ca 100644 > --- a/arch/arm64/boot/dts/renesas/ulcb.dtsi > +++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi > @@ -120,6 +120,12 @@ > #clock-cells = <0>; > clock-frequency = <24576000>; > }; > + > + x23_clk: x23-clock { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <25000000>; > + }; > }; > > &audio_clk_a { > @@ -193,6 +199,14 @@ > status = "okay"; > > clock-frequency = <400000>; > + > + versaclock5: clock-generator@6a { > + compatible = "idt,5p49v5925"; Checkpatch tells me that "idt,5p49v5925" is undocumented (in v4.12-rc1). Has this been addressed for v4.14? If not is there a plan to do so? > + reg = <0x6a>; > + #clock-cells = <1>; > + clocks = <&x23_clk>; > + clock-names = "xin"; > + }; > }; > > &i2c_dvfs { > -- > 1.9.1 >
On Mon, Jul 10, 2017 at 10:42:58AM +0200, Simon Horman wrote: > On Fri, Jul 07, 2017 at 05:36:59AM +0300, Vladimir Barinov wrote: > > From: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com> > > > > The DU0/DU1/DU2/DU3 external dot clocks are generated by an I2C-controlled > > programmable clock generator. > > > > Clock generator is available on both the H3 and M3-W ULCB boards. > > Add this to the ulcb.dtsi file. > > > > Signed-off-by: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com> > > --- > > arch/arm64/boot/dts/renesas/ulcb.dtsi | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/renesas/ulcb.dtsi b/arch/arm64/boot/dts/renesas/ulcb.dtsi > > index e402f16f..6f0a7ca 100644 > > --- a/arch/arm64/boot/dts/renesas/ulcb.dtsi > > +++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi > > @@ -120,6 +120,12 @@ > > #clock-cells = <0>; > > clock-frequency = <24576000>; > > }; > > + > > + x23_clk: x23-clock { > > + compatible = "fixed-clock"; > > + #clock-cells = <0>; > > + clock-frequency = <25000000>; > > + }; > > }; > > > > &audio_clk_a { > > @@ -193,6 +199,14 @@ > > status = "okay"; > > > > clock-frequency = <400000>; > > + > > + versaclock5: clock-generator@6a { > > + compatible = "idt,5p49v5925"; > > Checkpatch tells me that "idt,5p49v5925" is undocumented (in v4.12-rc1). > Has this been addressed for v4.14? If not is there a plan to do so? I now see "clk: vc5: Add support for IDT VersaClock 5P49V5925". Sorry for the noise. > > > + reg = <0x6a>; > > + #clock-cells = <1>; > > + clocks = <&x23_clk>; > > + clock-names = "xin"; > > + }; > > }; > > > > &i2c_dvfs { > > -- > > 1.9.1 > > >
diff --git a/arch/arm64/boot/dts/renesas/ulcb.dtsi b/arch/arm64/boot/dts/renesas/ulcb.dtsi index e402f16f..6f0a7ca 100644 --- a/arch/arm64/boot/dts/renesas/ulcb.dtsi +++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi @@ -120,6 +120,12 @@ #clock-cells = <0>; clock-frequency = <24576000>; }; + + x23_clk: x23-clock { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <25000000>; + }; }; &audio_clk_a { @@ -193,6 +199,14 @@ status = "okay"; clock-frequency = <400000>; + + versaclock5: clock-generator@6a { + compatible = "idt,5p49v5925"; + reg = <0x6a>; + #clock-cells = <1>; + clocks = <&x23_clk>; + clock-names = "xin"; + }; }; &i2c_dvfs {