| Message ID | 1500305076-15570-5-git-send-email-ulrich.hecht+renesas@gmail.com (mailing list archive) |
|---|---|
| State | RFC |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
On Mon, Jul 17, 2017 at 10:24 AM, Ulrich Hecht <ulrich.hecht+renesas@gmail.com> wrote: > serdev controllers may depend on other devices (such as multiplexers) > and thus require deferred probing support. I wonder if instead of deferring, we could just delay binding the devices. There's really no reason to defer the controller. This is a small addition, but deferring involves a lot of undoing and redoing of initialization. Rob
diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c index f534a40..30a8997 100644 --- a/drivers/tty/serial/serial_core.c +++ b/drivers/tty/serial/serial_core.c @@ -2785,6 +2785,10 @@ int uart_add_one_port(struct uart_driver *drv, struct uart_port *uport) uport->line, uport->dev, port, uport->tty_groups); if (likely(!IS_ERR(tty_dev))) { device_set_wakeup_capable(tty_dev, 1); + } else if (PTR_ERR(tty_dev) == -EPROBE_DEFER) { + ret = -EPROBE_DEFER; + state->uart_port = NULL; + goto out; } else { dev_err(uport->dev, "Cannot register tty device on line %d\n", uport->line);
serdev controllers may depend on other devices (such as multiplexers) and thus require deferred probing support. Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com> --- drivers/tty/serial/serial_core.c | 4 ++++ 1 file changed, 4 insertions(+)