From patchwork Wed Aug 9 10:55:24 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yoshihiro Shimoda X-Patchwork-Id: 9890319 X-Patchwork-Delegate: geert@linux-m68k.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1B247601EB for ; Wed, 9 Aug 2017 10:58:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2155A289C9 for ; Wed, 9 Aug 2017 10:58:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 14D6328A35; Wed, 9 Aug 2017 10:58:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 09A81289C9 for ; Wed, 9 Aug 2017 10:58:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752125AbdHIK6j (ORCPT ); Wed, 9 Aug 2017 06:58:39 -0400 Received: from relmlor4.renesas.com ([210.160.252.174]:7393 "EHLO relmlie3.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751872AbdHIK6h (ORCPT ); Wed, 9 Aug 2017 06:58:37 -0400 Received: from unknown (HELO relmlir2.idc.renesas.com) ([10.200.68.152]) by relmlie3.idc.renesas.com with ESMTP; 09 Aug 2017 19:58:35 +0900 Received: from relmlii1.idc.renesas.com (relmlii1.idc.renesas.com [10.200.68.65]) by relmlir2.idc.renesas.com (Postfix) with ESMTP id D65A44DBD7; Wed, 9 Aug 2017 19:58:35 +0900 (JST) X-IronPort-AV: E=Sophos;i="5.41,347,1498489200"; d="scan'208";a="252982531" Received: from mail-ty1jpn01lp0177.outbound.protection.outlook.com (HELO JPN01-TY1-obe.outbound.protection.outlook.com) ([23.103.139.177]) by relmlii1.idc.renesas.com with ESMTP/TLS/AES256-SHA256; 09 Aug 2017 19:58:35 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesasgroup.onmicrosoft.com; s=selector1-renesas-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Awj88iQXvZnS0FtJEVsH1vQzIbzvNryRcEX2G42+rKA=; b=IOelp/XY2wlowZ1DtZbLc0wk+ytlgQVhy7+8C/7UNTQomgDYlrxVdjqtVf/dUg9JIu5rUpCOYROKQmqYzHAKbgtZgaIsdAGKLHv4sjXdYsprwfIghG45Y2XkbfpoocesbSL4NiCvXPCbQarD1nV6DFnfaXabwC+j7FOkJG+urUM= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=<>; Received: from localhost.localdomain (211.11.155.138) by TY1PR06MB0990.apcprd06.prod.outlook.com (10.164.99.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1320.16; Wed, 9 Aug 2017 10:58:33 +0000 From: Yoshihiro Shimoda To: balbi@kernel.org Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Yoshihiro Shimoda Subject: [PATCH] usb: renesas_usbhs: gadget: fix spin_lock_init() for &uep->lock Date: Wed, 9 Aug 2017 19:55:24 +0900 Message-Id: <1502276124-27816-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 X-Originating-IP: [211.11.155.138] X-ClientProxiedBy: SG2PR06CA0107.apcprd06.prod.outlook.com (10.170.138.33) To TY1PR06MB0990.apcprd06.prod.outlook.com (10.164.99.24) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4fe5b098-51a5-4e4b-832d-08d4df15947f X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(201703131423075)(201703031133081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:TY1PR06MB0990; X-Microsoft-Exchange-Diagnostics: 1; TY1PR06MB0990; 3:lCpaKMNKEo3usbAbxP+1MiOtVXsdFEwx45V6myF2XEjR9/q4brDEGKXqJlph2BoCC3lGl6dSZWKrxeTNntLBU0ao6TKFQk+TuY/n46v2EEjFS9CnYxSwsJU9Xi9mIx45gVd04WCVXsd1SQldMhwittZn+X2REIfLAYekXxRy3NJbVu+WBcbqONnv8DW11TRmqg09JiFbR9jrkvzyAFYeGGAdI7kti1kyV44s7vc22cYttBUa9/hv0GmGwJlPQM5j; 25:1y1YYy8Nlj5wLB2UfGU6GZMn/xEtCVsO0NzCmYQ7001RNdKc281Lh3G4/1t4cK9+WtEzIIUyxjb2UsVrlwdNZpR35FtHZTloJVssJz0Egx/C0Vv/LOoiYjgXkJpw4WGtR2WXs1jqKvTVbLIKDucWS9bdE0U9deL9hP4HRNXdFmqe98SpkHontFlpecGPNo+Ms1/1yVRDEPuQi2hhmbYCDBiitLtRqk5BOW6sPUf1iLEriDM5nSEgVsn+g71w2WBksV2UCKT70nwfL9oYEoCOQKU+/K5G9TE3PxctoDDbQm6BJU1NIPhvzElzvMTluobwK+ULOjhFNBHYl828D9d+Sw==; 31:1Fx9bAlUhqu9K8sj6kxOQrJmTwFVOQbzqaLnbOnYPEA9UmxxyLAsW+4bnNW0+hy3+Iy4KvkDq6WvzZPR/lwJS80JBMowJEgzuMpiSiLRtNL6Z+eAzSkUNZOBad3IBAnjaY4fBh3ds/rtP4cBbDDNkuSy9vE40JdLJ6oGtHgCqciFhYLnHZp4jFgIFIeNH2WeaVCWgiPvsndaa2IojlK69MQPbHGXJNO7FL3T/EBm2KQ= X-MS-TrafficTypeDiagnostic: TY1PR06MB0990: X-Microsoft-Exchange-Diagnostics: 1; TY1PR06MB0990; 20:3SCqOmyEeWbRvrCMulicz3EbxKyeDY7UafaSNNBoVx45+zgdQEc7rW3ZS87Sn8jzpfeIIJiunhlN0ZEdurUl3oMEWOY0YVC3GuYqjk7S3h0F2yUHxmHmoL6KVhYWY+f5tJhZxEJ8EUTjz0muSr5d6MgSm6DiIA4PV9HYCe9njKkiMLV/EcrV4V8wGS0Lr1tsNXD6tfup4A1ZZNbbvA3h3Hj/ePBG5eTH3gaYUHcC4YIgloiBdYH3WsIvdLU0Spuss4vNsVasXGhtcRuEJXRiGomQI/ZxISZIh+i+VaxUpHEXsHizuRcgN4Oz187vtBkYa0ZIT1XAk0SFTzTp3ebBaPzSTakl4Ovq8PgN1ullY8dAFBRoybAFrPzBR742qjICCoKv0GzE11uJhElXJUI8CrrKd42UjsZGhF841zgnaX3pjSmyxeR154xoGcvGILTq7IsrXGJXHeLCPJ+0Bd8kh1Izo7/mhwd1Nz0hEnDn8up8oSVT/XVmvNdRBN8cUjeV; 4:WzowvFWHZR5swtxMiDJvBDRFR+VcEs6Vbt+IMNCUdkNTw/J52u+OIcxacxC1tndL7AQEfrEPhPB+DUHDanAKPmAR3gWpjt9n77B2N4m1JTzpzLhPbLoeVoDW5bF8C0Vdz88A3CxTxcqq5m1de88/4mBduKdqBzL6F6n+T08uI1CmF5dOxDZmWndbVIIB9i/g72Il7Gpz5bM9kyw38wCk7BKqjoFPXJor8TMDcLiUEa3mFbr4NzxfK8MI/PhAmWbynQC0b5pwjmQekwGsLQa6rS8ezy/aGybopu5wrFWuH+0= X-Exchange-Antispam-Report-Test: UriScan:(21532816269658); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(100000703101)(100105400095)(6055026)(6041248)(20161123555025)(20161123562025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061750153)(20161123560025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:TY1PR06MB0990; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:TY1PR06MB0990; X-Forefront-PRVS: 0394259C80 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(4630300001)(7370300001)(6069001)(6009001)(39850400002)(39400400002)(39410400002)(39450400003)(39860400002)(39840400002)(189002)(199003)(2361001)(78352004)(2351001)(66066001)(33646002)(47776003)(81166006)(2906002)(42186005)(189998001)(7350300001)(81156014)(305945005)(498600001)(50226002)(105586002)(106356001)(8676002)(6512007)(6116002)(6916009)(110136004)(48376002)(5003940100001)(42882006)(25786009)(5660300001)(101416001)(38730400002)(107886003)(6666003)(97736004)(7736002)(6506006)(68736007)(6486002)(4326008)(50466002)(36756003)(53936002)(3846002)(50986999)(3720700003); DIR:OUT; SFP:1102; SCL:1; SRVR:TY1PR06MB0990; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; MX:0; A:0; LANG:en; Received-SPF: None (protection.outlook.com: localhost.localdomain does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; TY1PR06MB0990; 23:y7ni2hYXJpJ6IZuSV/g3HSKtDreaGsgf3y6cRigSR?= =?us-ascii?Q?Hi8z/AZ1nDVfsMPbe2cXTxxplFq6V9gyYQDNn09rCSL/nlevaQDgBt6AJchB?= =?us-ascii?Q?HS7/0btHjdUFvDD5GwwaF3LikR6ZbeSE8tbfq2x1xHmJ1BNg7Fgjo5lKQMdd?= =?us-ascii?Q?n1a+Dty7ZfVVXQ3vptyVpYZm8Yov8R1NZ+Y0MIqlyQdDHFvXw5xUnQ7Iyqy/?= =?us-ascii?Q?KSWqA7JX4Tfto8l3QW21wzELabHoHlJA1VoOrkpeZ0MrXS1T++5B5LNHSEsl?= =?us-ascii?Q?MIMK5BfF6QLAe53qMbz5+jltQq2sSE6+oEydXPjKWrcQKD1WGxerIs5vpW4z?= =?us-ascii?Q?VTdYRDBvIyW5ilIPEBL0bZD4xeJsPVgJbxT6JPF0RaXscOUcZuRyNS5hQSWR?= =?us-ascii?Q?HmRLRyJi/HXH1DTN5UEM2I9s/4oHfbDNRNnWJ8oAMHXtqRuln+aj/8rVzqTX?= =?us-ascii?Q?oeicp0VOFV+TPrRZ78JiGIhyODjB3nkMRBxDJ6NRXkrdJ0FQK1TmC6tG2gPD?= =?us-ascii?Q?pS1M0emOxeV0wSFXDRiQisNx2urcI5BsK3gGYDy7aDJ3/VR5trGoC0YTcwee?= =?us-ascii?Q?mtSn8aGqwU1g0FbhgfwqbEjQDY+jt0pNsqHMHW4e5MJOfkbiM2SBSKs+ODgf?= =?us-ascii?Q?XyeaAfDO5/N/TpAG7LpOJcGDD6sEd4DI4oUfPwuNFgQazZTCG4LHbhSz+LIn?= =?us-ascii?Q?9noy1HBEcRqIQgKbwXt3x+6pvCllorYTiz1GHB3m3aLdL59XdPCrQMKW9bUM?= =?us-ascii?Q?Y5qlEbTph3D1cCf9+lqkmyGPIKohY9CfKBbakXhmNhx7rgQ89Exsa6fkPa4H?= =?us-ascii?Q?HJG4xYbCmhuQHniaLTXw6A7c63sXOITu4ZvHrxCWjL/kXLgJ+z9mN64ilLFB?= =?us-ascii?Q?05Ty16u25uFrmNEJcS27q8dj+PJiP11E55jhU5KgLZY/OjZ+lhs4sTFLzQgE?= =?us-ascii?Q?22APduGbdHVgrF4Ze+QRLgGtMv4zlpezU0tzfhxyxVl0z3eDq3VE9b7IXsKS?= =?us-ascii?Q?ycM72wxUMKtykbXoEGmGFP9lTpwDs1gSmjH1/bMKL8D12ZjU9MPzR2cTUzwq?= =?us-ascii?Q?5zIC6VOOWSGXTbsqwpTvMIMinzsxVPEtBaPP+R6vjKiVeK/taO2UGX4hC6rs?= =?us-ascii?Q?2eXky7It278wGh/gdJwMXA0VOBSqOUW18c5re1wu73Syt7NYwsZO6IAMoVo3?= =?us-ascii?Q?6UeyF0YmpA/J6xv+kTA/QioAy8JiHLL74Gb7J+yValwSD7KOoYqut1BoZPpZ?= =?us-ascii?Q?fwiG3Hy5jt27EDGEAkerl2JSj4REzR3mvJ9Jhl1O/AEVeXSZz2+SGAfrJX+h?= =?us-ascii?Q?2Tqmplx1IzjnZjKzsuF8sCTZqDTYdxBmBRAsVZEH2IpOEbAGAil+0e11g3ih?= =?us-ascii?Q?RxW6Q=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; TY1PR06MB0990; 6:FnhqGxgia5dwU+VR9yQvOfk7ZqDeiI/kWAemdys16HPtHlf9Vfzdry4yRU6QgjKoYq9+O+KEZxbbVb8k2sMENhx1DrGE6KWCYXIUeaqPUMzrol+PGsPv5fNW24/b7b/NBSgdd/2KCjk1q5OtWJurCSV6IH1pOEH4+NvLltYhyqvL6DXGILA2q/hU86iX9P7iIFRY0eH2r3dZ/IJMZuPdD6JhcMRe9WCzSLyA0gjdSkA4KYrrTPlEqBzrL1nWaC73NUX6EKF0iaevrWtNh357VjXfAuKWX5PEdn706iSCHt5Vy9zaoyyqlwIJiUPUYPzSRMv3zw+3laTtSEkJWSxYDQ==; 5:Sdsfh4dZQ6ifDCeNqiuCykNzLHxU3iPG4bQDUwRQpIM2sMDplboYp92/AzmmswYmjYXP8s8a+SWIUUm4MY0Q9O2bQ1cWPrmRtggTdHEjCkX5u5UA2eibbbhQmUQk8Ryuv39wb/3/YqCmSO9/Lpqdmw==; 24:fvVAokd+dpdqSx8Yjal5qt3Jk7gdSLfz7saU4ykZQdmyGHwrg73vCxEjJvaxF6uwRWKzeZn9XuPFb2fV+3AMiH0e0InmRAi0uwysh8FVQQ4=; 7:mhYVHhLsgsHntfF7/PZ2Ia93p1uXxYxp0BDzjo4QgAzfu10pY2skiWytzScxrDONN0nxbWA8G3fw+/n6YUrJa5TyWFS4cfzsBPFu3dubo6M/l2Ruy6rbKhsz5kN/Cs7phvUr/TaYb4/RjQOJgjl26OEmMOXIrOrWEBUTVuEqJMpqfO4Sulky4bdW6mmIOGi7ZyUcBiGyoimR2Bz9dvdF9pAG7VDWJuhNgdFLGHwdvO0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; TY1PR06MB0990; 20:ImCtQ2L730gufdZcFQsaZDUq25ZNcOscNBOtZby6tEu6MyzD3uKHWfr84TVt/IMNm5iJXWBk2LrnBCqcWjQ9aDe3zWblZ1RbnjHgMuGq2B/AbJlODHED77hMPwVBxmPuEcvUjDKkvIiYnwJ2lPKBuK0gaeE3LzhYAARk7VOalcA= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2017 10:58:33.4495 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY1PR06MB0990 Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch fixes an issue that the spin_lock_init() is not called for almost all pipes. Otherwise, the lockdep output the following message when we connect a usb cable using g_ncm: INFO: trying to register non-static key. the code is fine but needs lockdep annotation. turning off the locking correctness validator. Reported-by: Kazuya Mizuguchi Fixes: b8b9c974afee ("usb: renesas_usbhs: gadget: disable all eps when the driver stops") Signed-off-by: Yoshihiro Shimoda Tested-by: Kazuya Mizuguchi --- I'm sorry again and again. This patch is based on the latest Felipe's usb.git / testing/fixes branch (the commit id = b7d44c36a6f6d). Or, should I revert related patches first? b7d44c36a6f6 ("usb: renesas_usbhs: gadget: fix unused-but-set-variable warning") b8b9c974afee ("usb: renesas_usbhs: gadget: disable all eps when the driver stops") drivers/usb/renesas_usbhs/mod_gadget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/renesas_usbhs/mod_gadget.c b/drivers/usb/renesas_usbhs/mod_gadget.c index 2c8161b..5984fb1 100644 --- a/drivers/usb/renesas_usbhs/mod_gadget.c +++ b/drivers/usb/renesas_usbhs/mod_gadget.c @@ -1082,7 +1082,6 @@ int usbhs_mod_gadget_probe(struct usbhs_priv *priv) ret = -ENOMEM; goto usbhs_mod_gadget_probe_err_gpriv; } - spin_lock_init(&uep->lock); gpriv->transceiver = usb_get_phy(USB_PHY_TYPE_UNDEFINED); dev_info(dev, "%stransceiver found\n", @@ -1132,6 +1131,7 @@ int usbhs_mod_gadget_probe(struct usbhs_priv *priv) uep->ep.name = uep->ep_name; uep->ep.ops = &usbhsg_ep_ops; INIT_LIST_HEAD(&uep->ep.ep_list); + spin_lock_init(&uep->lock); /* init DCP */ if (usbhsg_is_dcp(uep)) {