| Message ID | 1502704398-28378-1-git-send-email-biju.das@bp.renesas.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Simon Horman |
| Headers | show |
Hello reviewers, > From: Biju Das [mailto:biju.das@bp.renesas.com] > Sent: 14 August 2017 10:53 > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > --- > v1-->v2 > Corrected the resets property for i2c6 device node. Are you happy with this version of the patch? Or is the discussion for moving to 'iic' still alive? Thanks, Chris > > This patch is compiled against renesas-devel tag renesas-devel-20170814- > v4.13-rc5. > > arch/arm/boot/dts/r8a7743.dtsi | 55 > ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 55 insertions(+) > > diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi > index ce80a26..480950f 100644 > --- a/arch/arm/boot/dts/r8a7743.dtsi > +++ b/arch/arm/boot/dts/r8a7743.dtsi > @@ -25,6 +25,9 @@ > i2c3 = &i2c3; > i2c4 = &i2c4; > i2c5 = &i2c5; > + i2c6 = &i2c6; > + i2c7 = &i2c7; > + i2c8 = &i2c8; > }; > > cpus { > @@ -411,6 +414,58 @@ > status = "disabled"; > }; > > + i2c6: i2c@e60b0000 { > + /* doesn't need pinmux */ > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "renesas,iic-r8a7743", > + "renesas,rcar-gen2-iic", > + "renesas,rmobile-iic"; > + reg = <0 0xe60b0000 0 0x425>; > + interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 926>; > + dmas = <&dmac0 0x77>, <&dmac0 0x78>, > + <&dmac1 0x77>, <&dmac1 0x78>; > + dma-names = "tx", "rx", "tx", "rx"; > + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; > + resets = <&cpg 926>; > + status = "disabled"; > + }; > + > + i2c7: i2c@e6500000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "renesas,iic-r8a7743", > + "renesas,rcar-gen2-iic", > + "renesas,rmobile-iic"; > + reg = <0 0xe6500000 0 0x425>; > + interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 318>; > + dmas = <&dmac0 0x61>, <&dmac0 0x62>, > + <&dmac1 0x61>, <&dmac1 0x62>; > + dma-names = "tx", "rx", "tx", "rx"; > + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; > + resets = <&cpg 318>; > + status = "disabled"; > + }; > + > + i2c8: i2c@e6510000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "renesas,iic-r8a7743", > + "renesas,rcar-gen2-iic", > + "renesas,rmobile-iic"; > + reg = <0 0xe6510000 0 0x425>; > + interrupts = <GIC_SPI 175 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 323>; > + dmas = <&dmac0 0x65>, <&dmac0 0x66>, > + <&dmac1 0x65>, <&dmac1 0x66>; > + dma-names = "tx", "rx", "tx", "rx"; > + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; > + resets = <&cpg 323>; > + status = "disabled"; > + }; > + > scifa0: serial@e6c40000 { > compatible = "renesas,scifa-r8a7743", > "renesas,rcar-gen2-scifa", "renesas,scifa"; > -- > 1.9.1
On 08/22/2017 12:10 PM, Chris Paterson wrote: >> From: Biju Das [mailto:biju.das@bp.renesas.com] >> Sent: 14 August 2017 10:53 >> >> Signed-off-by: Biju Das <biju.das@bp.renesas.com> >> --- >> v1-->v2 >> Corrected the resets property for i2c6 device node. > > Are you happy with this version of the patch? > > Or is the discussion for moving to 'iic' still alive? Yes, appears so. I'd like the labels to be named iic<n>. > Thanks, Chris MBR, Sergei
On Tue, Aug 22, 2017 at 03:23:39PM +0300, Sergei Shtylyov wrote: > On 08/22/2017 12:10 PM, Chris Paterson wrote: > > >>From: Biju Das [mailto:biju.das@bp.renesas.com] > >>Sent: 14 August 2017 10:53 > >> > >>Signed-off-by: Biju Das <biju.das@bp.renesas.com> > >>--- > >>v1-->v2 > >> Corrected the resets property for i2c6 device node. > > > >Are you happy with this version of the patch? > > > >Or is the discussion for moving to 'iic' still alive? > > Yes, appears so. I'd like the labels to be named iic<n>. Chirs, I'm marking this as "Changes Requested" and expecting to see iic in v3 when you are ready.
> From: Simon Horman [mailto:horms@verge.net.au] > Sent: 30 August 2017 08:32 > > On Tue, Aug 22, 2017 at 03:23:39PM +0300, Sergei Shtylyov wrote: > > On 08/22/2017 12:10 PM, Chris Paterson wrote: > > > > >>From: Biju Das [mailto:biju.das@bp.renesas.com] > > >>Sent: 14 August 2017 10:53 > > >> > > >>Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > >>--- > > >>v1-->v2 > > >> Corrected the resets property for i2c6 device node. > > > > > >Are you happy with this version of the patch? > > > > > >Or is the discussion for moving to 'iic' still alive? > > > > Yes, appears so. I'd like the labels to be named iic<n>. > > Chirs, I'm marking this as "Changes Requested" and expecting to see iic in v3 > when you are ready. Sure, thanks.
diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi index ce80a26..480950f 100644 --- a/arch/arm/boot/dts/r8a7743.dtsi +++ b/arch/arm/boot/dts/r8a7743.dtsi @@ -25,6 +25,9 @@ i2c3 = &i2c3; i2c4 = &i2c4; i2c5 = &i2c5; + i2c6 = &i2c6; + i2c7 = &i2c7; + i2c8 = &i2c8; }; cpus { @@ -411,6 +414,58 @@ status = "disabled"; }; + i2c6: i2c@e60b0000 { + /* doesn't need pinmux */ + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe60b0000 0 0x425>; + interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 926>; + dmas = <&dmac0 0x77>, <&dmac0 0x78>, + <&dmac1 0x77>, <&dmac1 0x78>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 926>; + status = "disabled"; + }; + + i2c7: i2c@e6500000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe6500000 0 0x425>; + interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 318>; + dmas = <&dmac0 0x61>, <&dmac0 0x62>, + <&dmac1 0x61>, <&dmac1 0x62>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 318>; + status = "disabled"; + }; + + i2c8: i2c@e6510000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "renesas,iic-r8a7743", + "renesas,rcar-gen2-iic", + "renesas,rmobile-iic"; + reg = <0 0xe6510000 0 0x425>; + interrupts = <GIC_SPI 175 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 323>; + dmas = <&dmac0 0x65>, <&dmac0 0x66>, + <&dmac1 0x65>, <&dmac1 0x66>; + dma-names = "tx", "rx", "tx", "rx"; + power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; + resets = <&cpg 323>; + status = "disabled"; + }; + scifa0: serial@e6c40000 { compatible = "renesas,scifa-r8a7743", "renesas,rcar-gen2-scifa", "renesas,scifa";
Signed-off-by: Biju Das <biju.das@bp.renesas.com> --- v1-->v2 Corrected the resets property for i2c6 device node. This patch is compiled against renesas-devel tag renesas-devel-20170814-v4.13-rc5. arch/arm/boot/dts/r8a7743.dtsi | 55 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 55 insertions(+)