diff mbox

[2/2] README: Document need for killall command

Message ID 1503528064-10454-3-git-send-email-kieran.bingham+renesas@ideasonboard.com (mailing list archive)
State Not Applicable
Delegated to: Geert Uytterhoeven
Headers show

Commit Message

Kieran Bingham Aug. 23, 2017, 10:41 p.m. UTC 
From: Kieran Bingham <kieran.bingham@ideasonboard.com>

The killall command is provided by the psmisc package on debian based systems.
On other systems it should be built or added to the filesystem as appropriate.

Also remove unnecessary blank line.

Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
---
 README | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Laurent Pinchart Aug. 24, 2017, 9:36 a.m. UTC | #1 
Hi Kieran,

Thank you for the patch.

On Thursday, 24 August 2017 01:41:04 EEST Kieran Bingham wrote:
> From: Kieran Bingham <kieran.bingham@ideasonboard.com>
> 
> The killall command is provided by the psmisc package on debian based
> systems. On other systems it should be built or added to the filesystem as
> appropriate.
> 
> Also remove unnecessary blank line.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> ---
>  README | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/README b/README
> index e503a2c41aef..7efcef394ae9 100644
> --- a/README
> +++ b/README
> @@ -43,6 +43,7 @@ system in a directory included in $PATH.
>  * media-ctl (part of v4l-utils, available at
> git://linuxtv.org/v4l-utils.git) * raw2rgbpnm (available at
> git://git.retiisi.org.uk/~sailus/raw2rgbpnm.git) * yavta (available at
> git://git.ideasonboard.org/yavta.git)
> +* killall (available from the psmisc package)

I've moved this between compare and media-ctl to keep the dependencies 
alphabetically sorted.

> 
>  All but the HGO and CLU/LUT tests can be run with the latest version of
> these tools. To test the HGO, HGT and CLU/LUT, the 'vsp' branch of 'yavta'
> is currently @@ -53,7 +54,6 @@ tool is not available the corresponding
> tests will be skipped.
> 
>  * stress (available at http://people.seas.harvard.edu/~apw/stress/)
> 
> -

I like this blank line :-) There are two blank lines before each section title 
in the README file.

Apart from that,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

If you're fine the comments I'll update the patch when applying and push it.

>  -----------------
>  Running the Tests
>  -----------------
Kieran Bingham Aug. 24, 2017, 4:03 p.m. UTC | #2 
Hi Laurent,

On 24/08/17 10:36, Laurent Pinchart wrote:
> Hi Kieran,
> 
> Thank you for the patch.
> 
> On Thursday, 24 August 2017 01:41:04 EEST Kieran Bingham wrote:
>> From: Kieran Bingham <kieran.bingham@ideasonboard.com>
>>
>> The killall command is provided by the psmisc package on debian based
>> systems. On other systems it should be built or added to the filesystem as
>> appropriate.
>>
>> Also remove unnecessary blank line.
>>
>> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
>> ---
>>  README | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/README b/README
>> index e503a2c41aef..7efcef394ae9 100644
>> --- a/README
>> +++ b/README
>> @@ -43,6 +43,7 @@ system in a directory included in $PATH.
>>  * media-ctl (part of v4l-utils, available at
>> git://linuxtv.org/v4l-utils.git) * raw2rgbpnm (available at
>> git://git.retiisi.org.uk/~sailus/raw2rgbpnm.git) * yavta (available at
>> git://git.ideasonboard.org/yavta.git)
>> +* killall (available from the psmisc package)
> 
> I've moved this between compare and media-ctl to keep the dependencies 
> alphabetically sorted.

That's fine with me.

>>  All but the HGO and CLU/LUT tests can be run with the latest version of
>> these tools. To test the HGO, HGT and CLU/LUT, the 'vsp' branch of 'yavta'
>> is currently @@ -53,7 +54,6 @@ tool is not available the corresponding
>> tests will be skipped.
>>
>>  * stress (available at http://people.seas.harvard.edu/~apw/stress/)
>>
>> -
> 
> I like this blank line :-) There are two blank lines before each section title 
> in the README file.
> 

Ah ok, I must have seen two lines and deleted one without looking further.

> Apart from that,
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> If you're fine the comments I'll update the patch when applying and push it.

Sure, that's fine.

--
Kieran
diff mbox

Patch

diff --git a/README b/README
index e503a2c41aef..7efcef394ae9 100644
--- a/README
+++ b/README
@@ -43,6 +43,7 @@  system in a directory included in $PATH.
 * media-ctl (part of v4l-utils, available at git://linuxtv.org/v4l-utils.git)
 * raw2rgbpnm (available at git://git.retiisi.org.uk/~sailus/raw2rgbpnm.git)
 * yavta (available at git://git.ideasonboard.org/yavta.git)
+* killall (available from the psmisc package)
 
 All but the HGO and CLU/LUT tests can be run with the latest version of these
 tools. To test the HGO, HGT and CLU/LUT, the 'vsp' branch of 'yavta' is currently
@@ -53,7 +54,6 @@  tool is not available the corresponding tests will be skipped.
 
 * stress (available at http://people.seas.harvard.edu/~apw/stress/)
 
-
 -----------------
 Running the Tests
 -----------------