Message ID | 1506505633-4688-2-git-send-email-yoshihiro.shimoda.uh@renesas.com (mailing list archive) |
---|---|
State | Accepted |
Delegated to: | Geert Uytterhoeven |
Headers | show
Return-Path: <linux-renesas-soc-owner@kernel.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 93C9A60365 for <patchwork-linux-renesas-soc@patchwork.kernel.org>; Wed, 27 Sep 2017 09:51:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 814D027F89 for <patchwork-linux-renesas-soc@patchwork.kernel.org>; Wed, 27 Sep 2017 09:51:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 760532910B; Wed, 27 Sep 2017 09:51:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4FCDF27F89 for <patchwork-linux-renesas-soc@patchwork.kernel.org>; Wed, 27 Sep 2017 09:51:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751938AbdI0Jv0 (ORCPT <rfc822;patchwork-linux-renesas-soc@patchwork.kernel.org>); Wed, 27 Sep 2017 05:51:26 -0400 Received: from relmlor4.renesas.com ([210.160.252.174]:38553 "EHLO relmlie3.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751892AbdI0JvS (ORCPT <rfc822;linux-renesas-soc@vger.kernel.org>); Wed, 27 Sep 2017 05:51:18 -0400 Received: from unknown (HELO relmlir3.idc.renesas.com) ([10.200.68.153]) by relmlie3.idc.renesas.com with ESMTP; 27 Sep 2017 18:51:16 +0900 Received: from relmlii1.idc.renesas.com (relmlii1.idc.renesas.com [10.200.68.65]) by relmlir3.idc.renesas.com (Postfix) with ESMTP id 8DB5E76238; Wed, 27 Sep 2017 18:51:16 +0900 (JST) X-IronPort-AV: E=Sophos;i="5.42,444,1500908400"; d="scan'208";a="257876054" Received: from mail-ty1jpn01lp0182.outbound.protection.outlook.com (HELO JPN01-TY1-obe.outbound.protection.outlook.com) ([23.103.139.182]) by relmlii1.idc.renesas.com with ESMTP/TLS/AES256-SHA256; 27 Sep 2017 18:51:16 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesasgroup.onmicrosoft.com; s=selector1-renesas-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=idET+xwHvQxJgNvdnGZcBfL+PKvUGpRVal49BzfHCSg=; b=EaycO/eidtLkMVUvWarajFYvlX99ywe1SaWc5fg9mc5ZUz0aGIZwJpOKTwuUBDvWGPEDygmZ5/vs0aDVJ9/P2WNZ849PnaT42dp8DWDfpz37pRdmLEn/adTNq2QxoVow62Z4kBpagutFD7+e3pWIXwIM7g6I7ORyH8iMqzQCzUg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=<>; Received: from localhost.localdomain (211.11.155.138) by TY1PR06MB0990.apcprd06.prod.outlook.com (10.164.99.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Wed, 27 Sep 2017 09:51:13 +0000 From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> To: balbi@kernel.org Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-renesas-soc@vger.kernel.org, stable@vger.kernel.org, Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Subject: [PATCH v2 1/2] usb: renesas_usbhs: fix the BCLR setting condition for non-DCP pipe Date: Wed, 27 Sep 2017 18:47:12 +0900 Message-Id: <1506505633-4688-2-git-send-email-yoshihiro.shimoda.uh@renesas.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1506505633-4688-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> References: <1506505633-4688-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [211.11.155.138] X-ClientProxiedBy: PS1PR0601CA0094.apcprd06.prod.outlook.com (10.170.176.148) To TY1PR06MB0990.apcprd06.prod.outlook.com (10.164.99.24) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 80974be6-6002-46ec-b304-08d5058d4a70 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081); SRVR:TY1PR06MB0990; X-Microsoft-Exchange-Diagnostics: 1; TY1PR06MB0990; 3:NBjSyyz0pife47zNzv03ExqIKykLIRz6RBFPY0fE+OsUg2eTSop9e+tC0jkSCdHTH+JJGCUcxKke0iqaTVXatfcqRfeoaT545Z4q0YrSfWH41T0Ik0J+joUOLosWNG+kxqZjFtcb5Nn+QOtfrfbqhouFXKLjLqCwL3ort3IkkZ0tqbiYubIlI/vVwqPpVqfEUN9fgCJs4/RuNBwSdN9dJS7EAIU7YsFmkVr6Nywj7tmj+CYoZVfos3A3ZsITExDt; 25:RvNENsZ1xYhroLkIqCY146JEY7aM0+gT/i1Mci387EfNkmNSSD66BfIxw+NPGfl9PRLDqceOC63se9qbOEUnDi1mFNfFzWw687ba/ARb5/V5+o/kaH/vyLEZL50kEyJ/BJenR2mD7BUF+nWI+NC12GhQuoBxhVlPbN7hdHPn1rXgwyj78lCVxtsnBxNQyKPFhTyzzSuHWjcKhRJCPf10nnqfMQEtJ8A7m98qr2Qe/m6sZBN6z9ddAtqtXoPnJnznfir9dkJlB9u+hYi0lRLTZwaH9kr0+1KTnOMhDOwBM/M5n3w6OK7lLMuurM7m1E+rLrpHg77aBXckvs3lK20yyg==; 31:CeGbiaWheLN1ugp3oA9AgqFVdwaRv5SEF/+ZrNt4PlzRS7Ud+1nM1/jmsMnwhyKLMGpRimHfD2A470IQ0V8kca59W2tgrpYc7MDxX90vcmn4su5NavzdCV3LkA2rWpBNDLabuc3TCGFwChL74PU99U3UX67g/CBsIpvQyGTs447/4XLJhGZBT22mRB1ZPQP/urp9WZQ0pwG3y59E2ogSrgGyudMr+CQMNz9EYneBbow= X-MS-TrafficTypeDiagnostic: TY1PR06MB0990: X-Microsoft-Exchange-Diagnostics: 1; TY1PR06MB0990; 20:Jfgbk3CQ8SRUewROtOfAoKHJeL54746370begFG5MDfrKZmP0Wj+I9YJmunST6FAUnzT9WLfQdmxkmuJY+W4YzR357jb79lnyOrFcVt6Celni82l2062bohWKEFzkoiw6TM1i7BMSH7nwQWUpmBHa5RkZEtEHxdr5QOWOORMF+aFawjx6IUx0BWpT4HLgXYPSDDABQSDeFZgJ/aZayJXufiS4hGNQlekqA3Gx6rp/VOl3sP2Jdo0i1NYRK14IvU1EWua/ZKahAEomATQtgjbEbRPkszdWNNRHC/Ccmn02kAECWyMb4zzhy+woCqzFbCZJThtKAVWWXwlL95IEUvDSRrr82nkUbGsagEPbBW4TvQEphaXgLxydVIB82xWb0exNCJMuvgcD4fIM5nklh7eEhN0+yk6y/f0sLaU81IW58Wo+rjlxmX2ikMthFzhdo/yloQHcvxSNaYu7hkBbWcoh6A0mxsNWuvBfLFa0eELhw33mfI+hBgsaiJXRc0o1To4; 4:tiJHT9OoagYIaEFQWwNGsXico686Aj1pqBYp72MPByZJ8hl6tq7pBs0qudXTdFJEJtaQSCI2bGbK5V1udOK/a5HTh7bGKdueOrdqYfOChDmP1r2AQQxGlp8QlPIfJy9rXZ8aiW7U5upDK2DVAuSK+Kh6F10tygSpztdUpFSqE1WYwkohNwSDvcMlFKmd8jz4nHOuNk7UKRrQASxREg3SYnOxZMN0t148n0572BR6OOu1IcZALMD40nhhNWltfcXlK0On4zHWVv/n9xxlwChfKeNtHdEJGc9Zavg6yj7ax20= X-Exchange-Antispam-Report-Test: UriScan:(9452136761055); X-Microsoft-Antispam-PRVS: <TY1PR06MB0990798C43EE20CEABA3CDE9B8780@TY1PR06MB0990.apcprd06.prod.outlook.com> X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(100000703101)(100105400095)(93006095)(3002001)(6055026)(6041248)(20161123562025)(20161123564025)(20161123560025)(20161123555025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061750153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:TY1PR06MB0990; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:TY1PR06MB0990; X-Forefront-PRVS: 04433051BF X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(6069001)(6009001)(39860400002)(376002)(346002)(189002)(199003)(2950100002)(105586002)(2351001)(36756003)(2361001)(5660300001)(81156014)(106356001)(97736004)(81166006)(53936002)(5003940100001)(50226002)(498600001)(47776003)(4326008)(8936002)(6512007)(66066001)(68736007)(107886003)(8676002)(189998001)(6506006)(6486002)(305945005)(101416001)(16586007)(16526017)(7736002)(6916009)(48376002)(50466002)(42882006)(316002)(2906002)(6116002)(76176999)(78352004)(33646002)(50986999)(3846002)(25786009)(3720700003); DIR:OUT; SFP:1102; SCL:1; SRVR:TY1PR06MB0990; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; MX:0; A:0; LANG:en; Received-SPF: None (protection.outlook.com: localhost.localdomain does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; TY1PR06MB0990; 23:kTFBByZHGV5v5006kOTSdOFJ3eIg5AWg2pNpIDF+z?= =?us-ascii?Q?HrYy3VA0bHUQOyBfVEWqxU+awMQN01Nxa4Y3M+3OIcatYMeIC8bGFPtBfgUB?= =?us-ascii?Q?OMJk3bOFvdD456JK9QXFy+uZoDDW0XMfnK5rFzvCAdITD8G/5f6UHpj0fAz+?= =?us-ascii?Q?sC6t1gJVjrq5LZqqcdvt3EGYCqmLTpe/igR1OCd1JVapRh+KQJjqwnqkdz1J?= =?us-ascii?Q?K1J/kZYr8xMSBsPgQESfu6sMHI8vS0Qhp3W5UrpBKyFPENwgAbkN41uyMr+E?= =?us-ascii?Q?howc553ZhmMW3xiosYnz/Jc2AJDA5XzSgeRXXwiu5jxYMpFfHHDpVZvb/BcS?= =?us-ascii?Q?cXw9WrQhKeAagdf0z4QpyPSoP0GuJOEmgZhKUUhrUDnlHZBnWFDqz0JmWV84?= =?us-ascii?Q?k8nFeIt/7bOJ6+9VIovJM9M3ShDFYdSH8x5Rq3wbzXGHUPd59emjt/dtZizy?= =?us-ascii?Q?+kqakyoW9g4oTElD1hjLCrJZIW+qt96NNNsEPXUn+sZhXKyiOUQr0inwd5HC?= =?us-ascii?Q?59hSvGXnYRs6uHfrxomcRmV+rS/hlU7PfHVc3Y+g2ecKoMWHmoE3f7xSSaE1?= =?us-ascii?Q?Bh2Dp1Stiu6ZswOsUeQ8hgCnk8BjzXiuCjDNEZ7EL+DSmSajd6Z3TV/Jjgsx?= =?us-ascii?Q?o8Y9yRB5C/geKEh+uSIcB0CvSpxOjSDSSnTXzGlf3qcxHXHfqCh2ICORWHOe?= =?us-ascii?Q?CjRT01LBDl7szQrn9kWfvuCAjQ0BP0A2z+tqyvMYZSaeUsDZ5mTyWYlC0K4l?= =?us-ascii?Q?60ssl/B82yqbwfFzbE7lgq6pz1mWQAD5iK+3W1QHryg47ebI/oS1PXddT0of?= =?us-ascii?Q?ikVsh+tjgyb5+HZygy8UAlEA0vQZcBi4NQXTeXcr8rZ6CPUlMB2RP0DxsEii?= =?us-ascii?Q?h6lTsRDJWhPpfiZvv0cRfWuE8bpQUgKkYEVuLD8PVWvYXOE6MHDOkcSUtXqb?= =?us-ascii?Q?P4BqL+3/sTT/ardHo3OcpYQpVEhNSFWn1uohAS2Rn+0rIJKXOybyub9ZzceU?= =?us-ascii?Q?Bd7wZeWlHyxh7F3Al3fdV6QsC960skrVL8USGCBRznynrET1GBIJsbVE27kH?= =?us-ascii?Q?FAgbohqwUsIedUPZ2Yv3ZU5qGBQ6eeROMuESRy/KgcWziDq5a2DsWYl2dsjZ?= =?us-ascii?Q?FGs8aSJeK+AQ5Y59to0JZ1Rl1Xkw6k5Eu1sTNmqAJvO/znHZzpXxFxOFE7bi?= =?us-ascii?Q?DJWvpIOsccnB34=3D?= X-Microsoft-Exchange-Diagnostics: 1; TY1PR06MB0990; 6:zKxLNCt+osiIqW9vtXUnmn/Iq/0m8Pc1rYIpwC/vwftxozSiITD3WQRD5A+LP7wleXMuN2cAcGhVfzO2yG+WTB87IPGWnZulZKyaKMvd9pEcTIG3PBL/FExwBEN0FcDxBxCVpylgpq34Z64sWBMmUzJsHZNSKq9lZfpeUAr1Il/PPC1zcKNh5ESwq+LeGqCDWf3LivHDVedX5rF2ZVr373d/j5jIocQZ3N6sEi+PCEIyWwJ5DrbcYL6u8mpKtincgVzBWEvqZzpV0QbeApZUL4axQIbCKblhQ7jHv7JLe/w3vUWSEyI3UsHKkTqmNjOaGjc+z11LahNApPXtBDci5Q==; 5:yZHqwgm80/VROSfO428eVqaBJauG16hKuL8MAFRMgs00ZcxFIK9ldxD0ZqXXrKVQQ/eqZFX2u+DkGTaBxQ2eLpGLt8ehhhQodPGh3m9pixaRuhE9fmzoUXXPecXfmk+a+ZVgKv8QJJuwSbQXQRhfNg==; 24:1nRtAN2Uv9H2Xi2rFxdsHSK0djnds3oBjID0HlSpqf2yyyH/gzKXxfdvptNIMTfwMpnzyk02hXPRY6rLoMgdmj+Rn+4mQp8e/94eeiuPcls=; 7:P6CHY7L1LbXHrGWLL+cRI/VdBnQiLUP7k2s4R8St++j9bujCuS+GfA/XntyWFus/camjrCmszwip12VbgkmF59PY+QY48qABc4N7LTnkDG/pREi6XgIm4USISKrfFm6+krcymDuE1mpfLXHKWT8FGsvp78kzRLiLltgQDNPalnqQ4TFx4uq5fn5EFeBwhK0zbQBBdTC0cWjnKB71CxiDNEToZQbyWQ9ebQfChzAfqdg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; TY1PR06MB0990; 20:WiYkzanVr3AGQsII9lKZpUc9NPGGXxBpXp3e78kcQC+vqIAkmvQFcwdp6IvFGRAC+H8cStzu9VcVrm6GXM8jFCNiaJ6k+ASsEZOx1gdLoReZaqbdsCh56UhL6KA/NR+eoFXOv8p8CGw9vyNRO+UC7rsmLXWpktZ2fzA7L4zNxM0= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2017 09:51:13.2720 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY1PR06MB0990 Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: <linux-renesas-soc.vger.kernel.org> X-Mailing-List: linux-renesas-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP |
diff --git a/drivers/usb/renesas_usbhs/fifo.c b/drivers/usb/renesas_usbhs/fifo.c index d1af831..03cac07 100644 --- a/drivers/usb/renesas_usbhs/fifo.c +++ b/drivers/usb/renesas_usbhs/fifo.c @@ -282,11 +282,17 @@ static void usbhsf_fifo_clear(struct usbhs_pipe *pipe, struct usbhs_fifo *fifo) { struct usbhs_priv *priv = usbhs_pipe_to_priv(pipe); + int ret = 0; if (!usbhs_pipe_is_dcp(pipe)) - usbhsf_fifo_barrier(priv, fifo); + ret = usbhsf_fifo_barrier(priv, fifo); - usbhs_write(priv, fifo->ctr, BCLR); + /* + * if non-DCP pipe, this driver should set BCLR when + * usbhsf_fifo_barrier() returns 0. + */ + if (!ret) + usbhs_write(priv, fifo->ctr, BCLR); } static int usbhsf_fifo_rcv_len(struct usbhs_priv *priv,
This patch fixes an issue that the driver sets the BCLR bit of {C,Dn}FIFOCTR register to 1 even when it's non-DCP pipe and the FRDY bit of {C,Dn}FIFOCTR register is set to 1. Fixes: e8d548d54968 ("usb: renesas_usbhs: fifo became independent from pipe.") Cc: <stable@vger.kernel.org> # v3.1+ Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- drivers/usb/renesas_usbhs/fifo.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)