| Message ID | 1507119903-13148-1-git-send-email-geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
On Wed, Oct 04, 2017 at 02:25:03PM +0200, Geert Uytterhoeven wrote: > Use the of_device_get_match_data() helper instead of open coding. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
On 05.10.2017 12:19, Simon Horman wrote: > On Wed, Oct 04, 2017 at 02:25:03PM +0200, Geert Uytterhoeven wrote: >> Use the of_device_get_match_data() helper instead of open coding. >> >> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Reviewed-by: Simon Horman <horms+renesas@verge.net.au> > > Thanks, I already applied and sent forward before this new reviewed-by tag -Mathias
Hi, > From: Geert Uytterhoeven, Sent: Wednesday, October 4, 2017 9:25 PM > > Use the of_device_get_match_data() helper instead of open coding. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Thank you for the patch! Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> But, it seems too late about this Reviewed-by though... https://marc.info/?l=linux-usb&m=150719811907415&w=2 Best regards, Yoshihiro Shimoda
On Thu, Oct 05, 2017 at 01:12:01PM +0300, Mathias Nyman wrote: > On 05.10.2017 12:19, Simon Horman wrote: > >On Wed, Oct 04, 2017 at 02:25:03PM +0200, Geert Uytterhoeven wrote: > >>Use the of_device_get_match_data() helper instead of open coding. > >> > >>Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > >Reviewed-by: Simon Horman <horms+renesas@verge.net.au> > > > > > > Thanks, I already applied and sent forward before this new reviewed-by tag Thanks, sorry for not noticing that.
diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c index 163bafde709f79bf..a1b42348e0c8c6c8 100644 --- a/drivers/usb/host/xhci-plat.c +++ b/drivers/usb/host/xhci-plat.c @@ -16,6 +16,7 @@ #include <linux/module.h> #include <linux/pci.h> #include <linux/of.h> +#include <linux/of_device.h> #include <linux/platform_device.h> #include <linux/usb/phy.h> #include <linux/slab.h> @@ -152,7 +153,7 @@ MODULE_DEVICE_TABLE(of, usb_xhci_of_match); static int xhci_plat_probe(struct platform_device *pdev) { - const struct of_device_id *match; + const struct xhci_plat_priv *priv_match; const struct hc_driver *driver; struct device *sysdev; struct xhci_hcd *xhci; @@ -238,9 +239,8 @@ static int xhci_plat_probe(struct platform_device *pdev) } xhci = hcd_to_xhci(hcd); - match = of_match_node(usb_xhci_of_match, pdev->dev.of_node); - if (match) { - const struct xhci_plat_priv *priv_match = match->data; + priv_match = of_device_get_match_data(&pdev->dev); + if (priv_match) { struct xhci_plat_priv *priv = hcd_to_xhci_priv(hcd); /* Just copy data for now */
Use the of_device_get_match_data() helper instead of open coding. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/usb/host/xhci-plat.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)