| Message ID | 1507539981-4193-1-git-send-email-fabrizio.castro@bp.renesas.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 77014a7c654c76e1c0cf82563cc48e07c546461c |
| Delegated to: | Simon Horman |
| Headers | show |
Hi Fabrizio, Chris, On Mon, Oct 9, 2017 at 11:06 AM, Fabrizio Castro <fabrizio.castro@bp.renesas.com> wrote: > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> Thanks for your patch! Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- a/arch/arm/boot/dts/iwg20d-q7-common.dtsi > +++ b/arch/arm/boot/dts/iwg20d-q7-common.dtsi > @@ -11,6 +11,7 @@ > / { > aliases { > serial0 = &scif0; > + serial3 = &scifb1; Given this port is not labeled "serial3", but called "data uart", you may want to add a comment to avoid confusion: serial3 = &scifb1; /* data uart */ > ethernet0 = &avb; > }; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hello Geert, thank you for your feedback! > > Hi Fabrizio, Chris, > > On Mon, Oct 9, 2017 at 11:06 AM, Fabrizio Castro > <fabrizio.castro@bp.renesas.com> wrote: > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> > > Thanks for your patch! > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > --- a/arch/arm/boot/dts/iwg20d-q7-common.dtsi > > +++ b/arch/arm/boot/dts/iwg20d-q7-common.dtsi > > @@ -11,6 +11,7 @@ > > / { > > aliases { > > serial0 = &scif0; > > + serial3 = &scifb1; > > Given this port is not labeled "serial3", but called "data uart", you may want > to add a comment to avoid confusion: It's a little bit confusing, isn't it? The lines related to such interface are named as UART0_x on the carrier board schematic, the section of the schematic that contains the header is named "data uart header", and the board documentation names it explicitly as "UART 3 - /dev/ttySC3 (SCIFB1)". I don't think there is anything we can do to make this easier for the user really, is there? :D If we decide to add a comment to serial 3, I guess we need to be consistent and add comments for the other serial interfaces too. If you still prefer having a comment there I'll send a v2 and patch(es) for adding comments to the other interfaces, just let me know. Thanks, Fab > > serial3 = &scifb1; /* data uart */ > > > ethernet0 = &avb; > > }; > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
Hello Geert, > > > > > --- a/arch/arm/boot/dts/iwg20d-q7-common.dtsi > > > +++ b/arch/arm/boot/dts/iwg20d-q7-common.dtsi > > > @@ -11,6 +11,7 @@ > > > / { > > > aliases { > > > serial0 = &scif0; > > > + serial3 = &scifb1; > > > > Given this port is not labeled "serial3", but called "data uart", you may want > > to add a comment to avoid confusion: > > It's a little bit confusing, isn't it? The lines related to such interface are named as UART0_x on the carrier board schematic, the section > of the schematic that contains the header is named "data uart header", and the board documentation names it explicitly as "UART 3 - > /dev/ttySC3 (SCIFB1)". > > I don't think there is anything we can do to make this easier for the user really, is there? :D > If we decide to add a comment to serial 3, I guess we need to be consistent and add comments for the other serial interfaces too. > If you still prefer having a comment there I'll send a v2 and patch(es) for adding comments to the other interfaces, just let me know. Any thoughts about this? Thanks, Fab > > Thanks, > Fab > Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
On Mon, Oct 09, 2017 at 01:45:07PM +0000, Fabrizio Castro wrote: > Hello Geert, > > thank you for your feedback! > > > > > Hi Fabrizio, Chris, > > > > On Mon, Oct 9, 2017 at 11:06 AM, Fabrizio Castro > > <fabrizio.castro@bp.renesas.com> wrote: > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> > > > > Thanks for your patch! > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > > --- a/arch/arm/boot/dts/iwg20d-q7-common.dtsi > > > +++ b/arch/arm/boot/dts/iwg20d-q7-common.dtsi > > > @@ -11,6 +11,7 @@ > > > / { > > > aliases { > > > serial0 = &scif0; > > > + serial3 = &scifb1; > > > > Given this port is not labeled "serial3", but called "data uart", you may want > > to add a comment to avoid confusion: > > It's a little bit confusing, isn't it? The lines related to such > interface are named as UART0_x on the carrier board schematic, the > section of the schematic that contains the header is named "data uart > header", and the board documentation names it explicitly as "UART 3 - > /dev/ttySC3 (SCIFB1)". > > I don't think there is anything we can do to make this easier for the > user really, is there? :D If we decide to add a comment to serial 3, I > guess we need to be consistent and add comments for the other serial > interfaces too. If you still prefer having a comment there I'll send a > v2 and patch(es) for adding comments to the other interfaces, just let me > know. I have applied this patch. If a comment is subsequently decided on then please send a follow-up patch.
> Subject: Re: [PATCH] ARM: dts: iwg20d-q7: Add support for ttySC3 > > On Mon, Oct 09, 2017 at 01:45:07PM +0000, Fabrizio Castro wrote: > > Hello Geert, > > > > thank you for your feedback! > > > > > > > > Hi Fabrizio, Chris, > > > > > > On Mon, Oct 9, 2017 at 11:06 AM, Fabrizio Castro > > > <fabrizio.castro@bp.renesas.com> wrote: > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > > > Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> > > > > > > Thanks for your patch! > > > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > > > > --- a/arch/arm/boot/dts/iwg20d-q7-common.dtsi > > > > +++ b/arch/arm/boot/dts/iwg20d-q7-common.dtsi > > > > @@ -11,6 +11,7 @@ > > > > / { > > > > aliases { > > > > serial0 = &scif0; > > > > + serial3 = &scifb1; > > > > > > Given this port is not labeled "serial3", but called "data uart", you may want > > > to add a comment to avoid confusion: > > > > It's a little bit confusing, isn't it? The lines related to such > > interface are named as UART0_x on the carrier board schematic, the > > section of the schematic that contains the header is named "data uart > > header", and the board documentation names it explicitly as "UART 3 - > > /dev/ttySC3 (SCIFB1)". > > > > I don't think there is anything we can do to make this easier for the > > user really, is there? :D If we decide to add a comment to serial 3, I > > guess we need to be consistent and add comments for the other serial > > interfaces too. If you still prefer having a comment there I'll send a > > v2 and patch(es) for adding comments to the other interfaces, just let me > > know. > > I have applied this patch. If a comment is subsequently decided on > then please send a follow-up patch. Thank you Simon. Cheers, Fab Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
Hi Fabrizio, On Mon, Oct 23, 2017 at 3:25 PM, Fabrizio Castro <fabrizio.castro@bp.renesas.com> wrote: >> > > --- a/arch/arm/boot/dts/iwg20d-q7-common.dtsi >> > > +++ b/arch/arm/boot/dts/iwg20d-q7-common.dtsi >> > > @@ -11,6 +11,7 @@ >> > > / { >> > > aliases { >> > > serial0 = &scif0; >> > > + serial3 = &scifb1; >> > >> > Given this port is not labeled "serial3", but called "data uart", you may want >> > to add a comment to avoid confusion: >> >> It's a little bit confusing, isn't it? The lines related to such interface are named as UART0_x on the carrier board schematic, the section >> of the schematic that contains the header is named "data uart header", and the board documentation names it explicitly as "UART 3 - >> /dev/ttySC3 (SCIFB1)". And you cannot use "serial0" (to match "UART0"), as that's already in use for the SOM... >> I don't think there is anything we can do to make this easier for the user really, is there? :D >> If we decide to add a comment to serial 3, I guess we need to be consistent and add comments for the other serial interfaces too. >> If you still prefer having a comment there I'll send a v2 and patch(es) for adding comments to the other interfaces, just let me know. > > Any thoughts about this? Making life easier for the user is good. Consistency is also good. I have no strong feelings about this, so do as you please... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/arch/arm/boot/dts/iwg20d-q7-common.dtsi b/arch/arm/boot/dts/iwg20d-q7-common.dtsi index 1c072c0..8c852d1 100644 --- a/arch/arm/boot/dts/iwg20d-q7-common.dtsi +++ b/arch/arm/boot/dts/iwg20d-q7-common.dtsi @@ -11,6 +11,7 @@ / { aliases { serial0 = &scif0; + serial3 = &scifb1; ethernet0 = &avb; }; @@ -99,6 +100,11 @@ function = "scif0"; }; + scifb1_pins: scifb1 { + groups = "scifb1_data_d", "scifb1_ctrl"; + function = "scifb1"; + }; + sdhi1_pins: sd1 { groups = "sdhi1_data4", "sdhi1_ctrl"; function = "sdhi1"; @@ -129,6 +135,14 @@ status = "okay"; }; +&scifb1 { + pinctrl-0 = <&scifb1_pins>; + pinctrl-names = "default"; + + uart-has-rtscts; + status = "okay"; +}; + &sdhi1 { pinctrl-0 = <&sdhi1_pins>; pinctrl-1 = <&sdhi1_pins_uhs>;