| Message ID | 1507544543-28654-1-git-send-email-biju.das@bp.renesas.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
Hello Kishon, > From: Biju Das [mailto:biju.das@bp.renesas.com] > Sent: 09 October 2017 11:22 > > Add USB PHY support for r8a7743/5 SoC. Renesas RZ/G1[ME] (R8A7743/5) > USB PHY is identical to the R-Car Gen2 family. > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > Acked-by: Simon Horman <horms+renesas@verge.net.au> > Acked-by: Rob Herring <robh@kernel.org> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Does this patch look okay to you? Thanks, Chris > --- > This patch is tested against Linux next tag next-20170929. > > Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt > b/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt > index 91da947..eeb9e18 100644 > --- a/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt > +++ b/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt > @@ -4,10 +4,13 @@ This file provides information on what the device node > for the R-Car generation > 2 USB PHY contains. > > Required properties: > -- compatible: "renesas,usb-phy-r8a7790" if the device is a part of R8A7790 > SoC. > +- compatible: "renesas,usb-phy-r8a7743" if the device is a part of R8A7743 > SoC. > + "renesas,usb-phy-r8a7745" if the device is a part of R8A7745 SoC. > + "renesas,usb-phy-r8a7790" if the device is a part of R8A7790 SoC. > "renesas,usb-phy-r8a7791" if the device is a part of R8A7791 SoC. > "renesas,usb-phy-r8a7794" if the device is a part of R8A7794 SoC. > - "renesas,rcar-gen2-usb-phy" for a generic R-Car Gen2 compatible > device. > + "renesas,rcar-gen2-usb-phy" for a generic R-Car Gen2 or > + RZ/G1 compatible device. > > When compatible with the generic version, nodes must list the > SoC-specific version corresponding to the platform first > -- > 1.9.1
On Monday 09 October 2017 03:52 PM, Biju Das wrote: > Add USB PHY support for r8a7743/5 SoC. Renesas RZ/G1[ME] (R8A7743/5) > USB PHY is identical to the R-Car Gen2 family. > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > Acked-by: Simon Horman <horms+renesas@verge.net.au> > Acked-by: Rob Herring <robh@kernel.org> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> merged, thanks! -Kishon > --- > This patch is tested against Linux next tag next-20170929. > > Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt b/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt > index 91da947..eeb9e18 100644 > --- a/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt > +++ b/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt > @@ -4,10 +4,13 @@ This file provides information on what the device node for the R-Car generation > 2 USB PHY contains. > > Required properties: > -- compatible: "renesas,usb-phy-r8a7790" if the device is a part of R8A7790 SoC. > +- compatible: "renesas,usb-phy-r8a7743" if the device is a part of R8A7743 SoC. > + "renesas,usb-phy-r8a7745" if the device is a part of R8A7745 SoC. > + "renesas,usb-phy-r8a7790" if the device is a part of R8A7790 SoC. > "renesas,usb-phy-r8a7791" if the device is a part of R8A7791 SoC. > "renesas,usb-phy-r8a7794" if the device is a part of R8A7794 SoC. > - "renesas,rcar-gen2-usb-phy" for a generic R-Car Gen2 compatible device. > + "renesas,rcar-gen2-usb-phy" for a generic R-Car Gen2 or > + RZ/G1 compatible device. > > When compatible with the generic version, nodes must list the > SoC-specific version corresponding to the platform first >
On Wednesday 18 October 2017 05:10 PM, Kishon Vijay Abraham I wrote: > > > On Monday 09 October 2017 03:52 PM, Biju Das wrote: >> Add USB PHY support for r8a7743/5 SoC. Renesas RZ/G1[ME] (R8A7743/5) >> USB PHY is identical to the R-Car Gen2 family. >> >> Signed-off-by: Biju Das <biju.das@bp.renesas.com> >> Acked-by: Simon Horman <horms+renesas@verge.net.au> >> Acked-by: Rob Herring <robh@kernel.org> >> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > merged, thanks! just realized $subject is misleading since this is only dt-binding patch. Do you plan to send the driver patch too? Thanks Kishon > > -Kishon >> --- >> This patch is tested against Linux next tag next-20170929. >> >> Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt | 7 +++++-- >> 1 file changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt b/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt >> index 91da947..eeb9e18 100644 >> --- a/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt >> +++ b/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt >> @@ -4,10 +4,13 @@ This file provides information on what the device node for the R-Car generation >> 2 USB PHY contains. >> >> Required properties: >> -- compatible: "renesas,usb-phy-r8a7790" if the device is a part of R8A7790 SoC. >> +- compatible: "renesas,usb-phy-r8a7743" if the device is a part of R8A7743 SoC. >> + "renesas,usb-phy-r8a7745" if the device is a part of R8A7745 SoC. >> + "renesas,usb-phy-r8a7790" if the device is a part of R8A7790 SoC. >> "renesas,usb-phy-r8a7791" if the device is a part of R8A7791 SoC. >> "renesas,usb-phy-r8a7794" if the device is a part of R8A7794 SoC. >> - "renesas,rcar-gen2-usb-phy" for a generic R-Car Gen2 compatible device. >> + "renesas,rcar-gen2-usb-phy" for a generic R-Car Gen2 or >> + RZ/G1 compatible device. >> >> When compatible with the generic version, nodes must list the >> SoC-specific version corresponding to the platform first >>
Hi KIshon, On Wed, Oct 25, 2017 at 12:30 PM, Kishon Vijay Abraham I <kishon@ti.com> wrote: > On Wednesday 18 October 2017 05:10 PM, Kishon Vijay Abraham I wrote: >> On Monday 09 October 2017 03:52 PM, Biju Das wrote: >>> Add USB PHY support for r8a7743/5 SoC. Renesas RZ/G1[ME] (R8A7743/5) >>> USB PHY is identical to the R-Car Gen2 family. >>> >>> Signed-off-by: Biju Das <biju.das@bp.renesas.com> >>> Acked-by: Simon Horman <horms+renesas@verge.net.au> >>> Acked-by: Rob Herring <robh@kernel.org> >>> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> >> >> merged, thanks! > > just realized $subject is misleading since this is only dt-binding patch. Do > you plan to send the driver patch too? There's no need to update the driver, as it matches against the generic fallback compatible value "renesas,rcar-gen2-usb-phy". >>> --- >>> This patch is tested against Linux next tag next-20170929. >>> >>> Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt | 7 +++++-- >>> 1 file changed, 5 insertions(+), 2 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt b/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt >>> index 91da947..eeb9e18 100644 >>> --- a/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt >>> +++ b/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt >>> @@ -4,10 +4,13 @@ This file provides information on what the device node for the R-Car generation >>> 2 USB PHY contains. >>> >>> Required properties: >>> -- compatible: "renesas,usb-phy-r8a7790" if the device is a part of R8A7790 SoC. >>> +- compatible: "renesas,usb-phy-r8a7743" if the device is a part of R8A7743 SoC. >>> + "renesas,usb-phy-r8a7745" if the device is a part of R8A7745 SoC. >>> + "renesas,usb-phy-r8a7790" if the device is a part of R8A7790 SoC. >>> "renesas,usb-phy-r8a7791" if the device is a part of R8A7791 SoC. >>> "renesas,usb-phy-r8a7794" if the device is a part of R8A7794 SoC. >>> - "renesas,rcar-gen2-usb-phy" for a generic R-Car Gen2 compatible device. >>> + "renesas,rcar-gen2-usb-phy" for a generic R-Car Gen2 or >>> + RZ/G1 compatible device. >>> >>> When compatible with the generic version, nodes must list the >>> SoC-specific version corresponding to the platform first Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt b/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt index 91da947..eeb9e18 100644 --- a/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt +++ b/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt @@ -4,10 +4,13 @@ This file provides information on what the device node for the R-Car generation 2 USB PHY contains. Required properties: -- compatible: "renesas,usb-phy-r8a7790" if the device is a part of R8A7790 SoC. +- compatible: "renesas,usb-phy-r8a7743" if the device is a part of R8A7743 SoC. + "renesas,usb-phy-r8a7745" if the device is a part of R8A7745 SoC. + "renesas,usb-phy-r8a7790" if the device is a part of R8A7790 SoC. "renesas,usb-phy-r8a7791" if the device is a part of R8A7791 SoC. "renesas,usb-phy-r8a7794" if the device is a part of R8A7794 SoC. - "renesas,rcar-gen2-usb-phy" for a generic R-Car Gen2 compatible device. + "renesas,rcar-gen2-usb-phy" for a generic R-Car Gen2 or + RZ/G1 compatible device. When compatible with the generic version, nodes must list the SoC-specific version corresponding to the platform first