From patchwork Wed Nov 15 14:38:31 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 10059641 X-Patchwork-Delegate: geert@linux-m68k.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 67D676019D for ; Wed, 15 Nov 2017 14:38:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5BB4229FDC for ; Wed, 15 Nov 2017 14:38:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 50CBD2A089; Wed, 15 Nov 2017 14:38:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A395629FDC for ; Wed, 15 Nov 2017 14:38:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755666AbdKOOij (ORCPT ); Wed, 15 Nov 2017 09:38:39 -0500 Received: from mail.kernel.org ([198.145.29.99]:36542 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754013AbdKOOij (ORCPT ); Wed, 15 Nov 2017 09:38:39 -0500 Received: from localhost.localdomain (cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C3C2520C09; Wed, 15 Nov 2017 14:38:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C3C2520C09 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=kbingham@kernel.org From: Kieran Bingham To: niklas.soderlund@ragnatech.se Cc: linux-renesas-soc@vger.kernel.org, kieran.bingham@ideasonboard.com, Kieran Bingham Subject: [PATCH 3/3] vin-tests: Refactor mc_get_dev Date: Wed, 15 Nov 2017 14:38:31 +0000 Message-Id: <1510756711-6488-4-git-send-email-kbingham@kernel.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1510756711-6488-1-git-send-email-kbingham@kernel.org> References: <1510756711-6488-1-git-send-email-kbingham@kernel.org> Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Kieran Bingham Rather that using shell parsing of each file when looking for a device node, use a combination of grep and sed to identify the device. This is a remarkable speed optimisation for this code segment. Signed-off-by: Kieran Bingham --- scripts/vin-tests.sh | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/scripts/vin-tests.sh b/scripts/vin-tests.sh index 7c81aa51c1c5..2e6214bc95e6 100644 --- a/scripts/vin-tests.sh +++ b/scripts/vin-tests.sh @@ -99,17 +99,9 @@ mc_get_mdev() { } mc_get_dev() { - name=$1 - mdev=$(mc_get_mdev) - - for dev in /sys/class/video4linux/*; do - if [[ "$(cat $dev/name)" == "$name" ]]; then - basename $dev - return 0 - fi - done - - error "Can't find device" + name="$1" + grep -l "$name" /sys/class/video4linux/video*/name | \ + sed 's#.*video4linux\(.*\)/name#/dev\1#g' } mc_log() {