| Message ID | 1512046646-15253-3-git-send-email-geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e99185b298ba0288e88ea0a935342f01c8387b76 |
| Headers | show |
On Thu, Nov 30, 2017 at 1:57 PM, Geert Uytterhoeven <geert+renesas@glider.be> wrote: > Commits 7d29f509d2cfd807 ("dt-bindings: i2c: i2c-gpio: Add support for > named gpios") and 05c74778858d7d99 ("i2c: gpio: Add support for named > gpios in DT") introduced named i2c-gpio DT bindings, and deprecated the > more error-prone unnamed variant. > > Switch to the new bindings, and add the missing GPIO_OPEN_DRAIN I/O > flags, which were implicitly assumed before. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts index e3d27783b6b56b42..f2ea632381e7d1af 100644 --- a/arch/arm/boot/dts/r8a7790-lager.dts +++ b/arch/arm/boot/dts/r8a7790-lager.dts @@ -272,9 +272,8 @@ #size-cells = <0>; compatible = "i2c-gpio"; status = "disabled"; - gpios = <&gpio1 17 GPIO_ACTIVE_HIGH /* sda */ - &gpio1 16 GPIO_ACTIVE_HIGH /* scl */ - >; + sda-gpios = <&gpio1 17 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; + scl-gpios = <&gpio1 16 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; i2c-gpio,delay-us = <5>; };
Commits 7d29f509d2cfd807 ("dt-bindings: i2c: i2c-gpio: Add support for named gpios") and 05c74778858d7d99 ("i2c: gpio: Add support for named gpios in DT") introduced named i2c-gpio DT bindings, and deprecated the more error-prone unnamed variant. Switch to the new bindings, and add the missing GPIO_OPEN_DRAIN I/O flags, which were implicitly assumed before. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- v2: - New. --- arch/arm/boot/dts/r8a7790-lager.dts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)