Message ID | 1512046646-15253-5-git-send-email-geert+renesas@glider.be (mailing list archive) |
---|---|
State | Accepted |
Commit | 7f32eddb81ecc06131a643babe2d0f961fbd7f08 |
Headers | show |
On Thu, Nov 30, 2017 at 1:57 PM, Geert Uytterhoeven <geert+renesas@glider.be> wrote: > Commits 7d29f509d2cfd807 ("dt-bindings: i2c: i2c-gpio: Add support for > named gpios") and 05c74778858d7d99 ("i2c: gpio: Add support for named > gpios in DT") introduced named i2c-gpio DT bindings, and deprecated the > more error-prone unnamed variant. > > Switch to the new bindings, and add the missing GPIO_OPEN_DRAIN I/O > flags, which were implicitly assumed before. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
diff --git a/arch/arm/boot/dts/r8a7794-alt.dts b/arch/arm/boot/dts/r8a7794-alt.dts index bd98790d964e13a7..60c6515c499660eb 100644 --- a/arch/arm/boot/dts/r8a7794-alt.dts +++ b/arch/arm/boot/dts/r8a7794-alt.dts @@ -143,9 +143,8 @@ #size-cells = <0>; compatible = "i2c-gpio"; status = "disabled"; - gpios = <&gpio4 9 GPIO_ACTIVE_HIGH /* sda */ - &gpio4 8 GPIO_ACTIVE_HIGH /* scl */ - >; + sda-gpios = <&gpio4 9 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; + scl-gpios = <&gpio4 8 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; i2c-gpio,delay-us = <5>; };
Commits 7d29f509d2cfd807 ("dt-bindings: i2c: i2c-gpio: Add support for named gpios") and 05c74778858d7d99 ("i2c: gpio: Add support for named gpios in DT") introduced named i2c-gpio DT bindings, and deprecated the more error-prone unnamed variant. Switch to the new bindings, and add the missing GPIO_OPEN_DRAIN I/O flags, which were implicitly assumed before. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- v2: - New. --- arch/arm/boot/dts/r8a7794-alt.dts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)