| Message ID | 1512047522-16312-6-git-send-email-geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | RFC |
| Headers | show |
On Thu, Nov 30, 2017 at 02:12:02PM +0100, Geert Uytterhoeven wrote: > CONFIG_EXPERT exposes too many config options that do not matter for > development. However, CONFIG_EMBEDDED selects CONFIG_EXPERT, so it > cannot be disabled. > > Hence disable CONFIG_EMBEDDED, and compensate for the loss of > CONFIG_DEBUG_KERNEL by enabling the latter. > > Actual impact: > - CONFIG_NAMESPACES=y, > - CONFIG_SYSCTL_SYSCALL=n, > - CONFIG_SERIAL_SH_SCI_NR_UARTS changed from 20 to 18, > - CONFIG_SERIAL_SH_SCI_EARLYCON=y, > - Some HID support became enabled, > - CONFIG_DEBUG_MEMORY_INIT=y, > > Refresh the result. I'm sorry but I don't understand the motivation for this change. I understand that it might make the image smaller or build times faster. But it seems to be a risky change for those benefits. What are the side-effects of the changes you describe above?
Hi Simon, On Fri, Dec 1, 2017 at 9:33 AM, Simon Horman <horms@verge.net.au> wrote: > On Thu, Nov 30, 2017 at 02:12:02PM +0100, Geert Uytterhoeven wrote: >> CONFIG_EXPERT exposes too many config options that do not matter for >> development. However, CONFIG_EMBEDDED selects CONFIG_EXPERT, so it >> cannot be disabled. >> >> Hence disable CONFIG_EMBEDDED, and compensate for the loss of >> CONFIG_DEBUG_KERNEL by enabling the latter. >> >> Actual impact: >> - CONFIG_NAMESPACES=y, >> - CONFIG_SYSCTL_SYSCALL=n, >> - CONFIG_SERIAL_SH_SCI_NR_UARTS changed from 20 to 18, >> - CONFIG_SERIAL_SH_SCI_EARLYCON=y, >> - Some HID support became enabled, >> - CONFIG_DEBUG_MEMORY_INIT=y, >> >> Refresh the result. > > I'm sorry but I don't understand the motivation for this change. > I understand that it might make the image smaller or build times faster. > But it seems to be a risky change for those benefits. My main motivation is to start using the default values for the various SH_SCI options from the first 4 patches, but that requires disabling CONFIG_EXPERT. Sorry for not making that clearer. > What are the side-effects of the changes you describe above? Enabling CONFIG_NAMESPACES shouldn't hurt (isn't that also needed for systemd anyway?), just like the HID devices, or CONFIG_DEBUG_MEMORY_INIT (it does a few more checks, and defaults to yes). Disabling CONFIG_SYSCTL_SYSCALL also shouldn't hurt (it defaults to no), except for very old userland not yet using /proc/sys, which might have been broken along the way by changed binary paths anyway. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Mon, Dec 04, 2017 at 10:46:22AM +0100, Geert Uytterhoeven wrote: > Hi Simon, > > On Fri, Dec 1, 2017 at 9:33 AM, Simon Horman <horms@verge.net.au> wrote: > > On Thu, Nov 30, 2017 at 02:12:02PM +0100, Geert Uytterhoeven wrote: > >> CONFIG_EXPERT exposes too many config options that do not matter for > >> development. However, CONFIG_EMBEDDED selects CONFIG_EXPERT, so it > >> cannot be disabled. > >> > >> Hence disable CONFIG_EMBEDDED, and compensate for the loss of > >> CONFIG_DEBUG_KERNEL by enabling the latter. > >> > >> Actual impact: > >> - CONFIG_NAMESPACES=y, > >> - CONFIG_SYSCTL_SYSCALL=n, > >> - CONFIG_SERIAL_SH_SCI_NR_UARTS changed from 20 to 18, > >> - CONFIG_SERIAL_SH_SCI_EARLYCON=y, > >> - Some HID support became enabled, > >> - CONFIG_DEBUG_MEMORY_INIT=y, > >> > >> Refresh the result. > > > > I'm sorry but I don't understand the motivation for this change. > > I understand that it might make the image smaller or build times faster. > > But it seems to be a risky change for those benefits. > > My main motivation is to start using the default values for the various SH_SCI > options from the first 4 patches, but that requires disabling CONFIG_EXPERT. > Sorry for not making that clearer. Thanks for explaining, that helps me significantly. > > What are the side-effects of the changes you describe above? > > Enabling CONFIG_NAMESPACES shouldn't hurt (isn't that also needed for > systemd anyway?), just like the HID devices, or CONFIG_DEBUG_MEMORY_INIT > (it does a few more checks, and defaults to yes). > > Disabling CONFIG_SYSCTL_SYSCALL also shouldn't hurt (it defaults to no), > except for very old userland not yet using /proc/sys, which might have been > broken along the way by changed binary paths anyway. Understood. I (no longer) have any particular objections to this, though I would appreciate an enhanced changelog.
On 12/05/2017 02:28 AM, Simon Horman wrote: > On Mon, Dec 04, 2017 at 10:46:22AM +0100, Geert Uytterhoeven wrote: >> Hi Simon, >> >> On Fri, Dec 1, 2017 at 9:33 AM, Simon Horman <horms@verge.net.au> wrote: >>> On Thu, Nov 30, 2017 at 02:12:02PM +0100, Geert Uytterhoeven wrote: >>>> CONFIG_EXPERT exposes too many config options that do not matter for >>>> development. However, CONFIG_EMBEDDED selects CONFIG_EXPERT, so it >>>> cannot be disabled. >>>> >>>> Hence disable CONFIG_EMBEDDED, and compensate for the loss of >>>> CONFIG_DEBUG_KERNEL by enabling the latter. Didn't I already submit a patch to fix this in 2015? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=560b8c0ed45a If it came back, it's a regression. Rob
Hi Rob, On Sat, Dec 9, 2017 at 3:18 AM, Rob Landley <rob@landley.net> wrote: > On 12/05/2017 02:28 AM, Simon Horman wrote: >> On Mon, Dec 04, 2017 at 10:46:22AM +0100, Geert Uytterhoeven wrote: >>> On Fri, Dec 1, 2017 at 9:33 AM, Simon Horman <horms@verge.net.au> wrote: >>>> On Thu, Nov 30, 2017 at 02:12:02PM +0100, Geert Uytterhoeven wrote: >>>>> CONFIG_EXPERT exposes too many config options that do not matter for >>>>> development. However, CONFIG_EMBEDDED selects CONFIG_EXPERT, so it >>>>> cannot be disabled. >>>>> >>>>> Hence disable CONFIG_EMBEDDED, and compensate for the loss of >>>>> CONFIG_DEBUG_KERNEL by enabling the latter. > > Didn't I already submit a patch to fix this in 2015? > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=560b8c0ed45a > > If it came back, it's a regression. Your patch was for arch/sh/Kconfig, not for (arm32) shmobile_defconfig. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig index 7b4fc01431483f21..41eccc1b6cef7251 100644 --- a/arch/arm/configs/shmobile_defconfig +++ b/arch/arm/configs/shmobile_defconfig @@ -5,8 +5,6 @@ CONFIG_IKCONFIG_PROC=y CONFIG_CGROUPS=y CONFIG_BLK_DEV_INITRD=y CONFIG_CC_OPTIMIZE_FOR_SIZE=y -CONFIG_SYSCTL_SYSCALL=y -CONFIG_EMBEDDED=y CONFIG_PERF_EVENTS=y CONFIG_SLAB=y CONFIG_ARCH_RENESAS=y @@ -34,7 +32,6 @@ CONFIG_SMP=y CONFIG_SCHED_MC=y CONFIG_HAVE_ARM_ARCH_TIMER=y CONFIG_NR_CPUS=8 -CONFIG_AEABI=y CONFIG_HIGHMEM=y CONFIG_CMA=y CONFIG_ZBOOT_ROM_TEXT=0x0 @@ -106,7 +103,6 @@ CONFIG_SERIAL_8250_EM=y CONFIG_SERIAL_SH_SCI=y CONFIG_SERIAL_SH_SCI_NR_UARTS=20 CONFIG_SERIAL_SH_SCI_CONSOLE=y -CONFIG_SERIAL_SH_SCI_DMA=y CONFIG_I2C_CHARDEV=y CONFIG_I2C_MUX=y CONFIG_I2C_DEMUX_PINCTRL=y @@ -166,7 +162,6 @@ CONFIG_FB_SH_MOBILE_MERAM=y # CONFIG_BACKLIGHT_GENERIC is not set CONFIG_BACKLIGHT_PWM=y CONFIG_BACKLIGHT_AS3711=y -CONFIG_FRAMEBUFFER_CONSOLE=y CONFIG_SOUND=y CONFIG_SND=y CONFIG_SND_SOC=y @@ -225,4 +220,5 @@ CONFIG_NLS_ISO8859_1=y CONFIG_PRINTK_TIME=y # CONFIG_ENABLE_WARN_DEPRECATED is not set # CONFIG_ENABLE_MUST_CHECK is not set +CONFIG_DEBUG_KERNEL=y # CONFIG_ARM_UNWIND is not set
CONFIG_EXPERT exposes too many config options that do not matter for development. However, CONFIG_EMBEDDED selects CONFIG_EXPERT, so it cannot be disabled. Hence disable CONFIG_EMBEDDED, and compensate for the loss of CONFIG_DEBUG_KERNEL by enabling the latter. Actual impact: - CONFIG_NAMESPACES=y, - CONFIG_SYSCTL_SYSCALL=n, - CONFIG_SERIAL_SH_SCI_NR_UARTS changed from 20 to 18, - CONFIG_SERIAL_SH_SCI_EARLYCON=y, - Some HID support became enabled, - CONFIG_DEBUG_MEMORY_INIT=y, Refresh the result. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- arch/arm/configs/shmobile_defconfig | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)