| Message ID | 1513104579-6333-2-git-send-email-fabrizio.castro@bp.renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
On Tue, Dec 12, 2017 at 06:49:37PM +0000, Fabrizio Castro wrote: > Document SoC specific compatible strings for r8a7743 and r8a7745. > No driver change is needed as the fallback strings will activate > the right code. > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > Reviewed-by: Biju Das <biju.das@bp.renesas.com> > --- > Documentation/devicetree/bindings/timer/renesas,cmt.txt | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/timer/renesas,cmt.txt b/Documentation/devicetree/bindings/timer/renesas,cmt.txt > index d740989..1e4fe98 100644 > --- a/Documentation/devicetree/bindings/timer/renesas,cmt.txt > +++ b/Documentation/devicetree/bindings/timer/renesas,cmt.txt > @@ -22,6 +22,10 @@ Required Properties: > > - "renesas,r8a73a4-cmt0" for the 32-bit CMT0 device included in r8a73a4. > - "renesas,r8a73a4-cmt1" for the 48-bit CMT1 device included in r8a73a4. > + - "renesas,r8a7743-cmt0" for the 32-bit CMT0 device included in r8a7743. > + - "renesas,r8a7743-cmt1" for the 48-bit CMT1 device included in r8a7743. > + - "renesas,r8a7745-cmt0" for the 32-bit CMT0 device included in r8a7745. > + - "renesas,r8a7745-cmt1" for the 48-bit CMT1 device included in r8a7745. > - "renesas,r8a7790-cmt0" for the 32-bit CMT0 device included in r8a7790. > - "renesas,r8a7790-cmt1" for the 48-bit CMT1 device included in r8a7790. > - "renesas,r8a7791-cmt0" for the 32-bit CMT0 device included in r8a7791. > @@ -31,9 +35,11 @@ Required Properties: > - "renesas,r8a7794-cmt0" for the 32-bit CMT0 device included in r8a7794. > - "renesas,r8a7794-cmt1" for the 48-bit CMT1 device included in r8a7794. > > - - "renesas,rcar-gen2-cmt0" for 32-bit CMT0 devices included in R-Car Gen2. > - - "renesas,rcar-gen2-cmt1" for 48-bit CMT1 devices included in R-Car Gen2. > - These are fallbacks for r8a73a4 and all the R-Car Gen2 > + - "renesas,rcar-gen2-cmt0" for 32-bit CMT0 devices included in R-Car Gen2 or nit: or -> and ? > + RZ/G1. > + - "renesas,rcar-gen2-cmt1" for 48-bit CMT1 devices included in R-Car Gen2 or > + RZ/G1. > + These are fallbacks for r8a73a4, all the R-Car Gen2 and RZ/G1 > entries listed above. nit: all the R-Car -> R-Car > - reg: base address and length of the registers block for the timer module.
Hello Simon, thank you for the feedback. I'll apply your comments to V2, but I'll wait for your reply on the CMT "enable by default" issue. Thanks, Fab > Subject: Re: [PATCH 1/3] dt-bindings: timer: renesas, cmt: Document r8a774[35] CMT support > > On Tue, Dec 12, 2017 at 06:49:37PM +0000, Fabrizio Castro wrote: > > Document SoC specific compatible strings for r8a7743 and r8a7745. > > No driver change is needed as the fallback strings will activate > > the right code. > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > Reviewed-by: Biju Das <biju.das@bp.renesas.com> > > --- > > Documentation/devicetree/bindings/timer/renesas,cmt.txt | 12 +++++++++--- > > 1 file changed, 9 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/timer/renesas,cmt.txt > b/Documentation/devicetree/bindings/timer/renesas,cmt.txt > > index d740989..1e4fe98 100644 > > --- a/Documentation/devicetree/bindings/timer/renesas,cmt.txt > > +++ b/Documentation/devicetree/bindings/timer/renesas,cmt.txt > > @@ -22,6 +22,10 @@ Required Properties: > > > > - "renesas,r8a73a4-cmt0" for the 32-bit CMT0 device included in r8a73a4. > > - "renesas,r8a73a4-cmt1" for the 48-bit CMT1 device included in r8a73a4. > > + - "renesas,r8a7743-cmt0" for the 32-bit CMT0 device included in r8a7743. > > + - "renesas,r8a7743-cmt1" for the 48-bit CMT1 device included in r8a7743. > > + - "renesas,r8a7745-cmt0" for the 32-bit CMT0 device included in r8a7745. > > + - "renesas,r8a7745-cmt1" for the 48-bit CMT1 device included in r8a7745. > > - "renesas,r8a7790-cmt0" for the 32-bit CMT0 device included in r8a7790. > > - "renesas,r8a7790-cmt1" for the 48-bit CMT1 device included in r8a7790. > > - "renesas,r8a7791-cmt0" for the 32-bit CMT0 device included in r8a7791. > > @@ -31,9 +35,11 @@ Required Properties: > > - "renesas,r8a7794-cmt0" for the 32-bit CMT0 device included in r8a7794. > > - "renesas,r8a7794-cmt1" for the 48-bit CMT1 device included in r8a7794. > > > > - - "renesas,rcar-gen2-cmt0" for 32-bit CMT0 devices included in R-Car Gen2. > > - - "renesas,rcar-gen2-cmt1" for 48-bit CMT1 devices included in R-Car Gen2. > > -These are fallbacks for r8a73a4 and all the R-Car Gen2 > > + - "renesas,rcar-gen2-cmt0" for 32-bit CMT0 devices included in R-Car Gen2 or > > nit: or -> and ? > > > +RZ/G1. > > + - "renesas,rcar-gen2-cmt1" for 48-bit CMT1 devices included in R-Car Gen2 or > > +RZ/G1. > > +These are fallbacks for r8a73a4, all the R-Car Gen2 and RZ/G1 > > entrieslisted above. > > nit: all the R-Car -> R-Car > > > - reg: base address and length of the registers block for the timer module. [https://www2.renesas.eu/media/email/unicef_2017.jpg] This Christmas, instead of sending out cards, Renesas Electronics Europe have decided to support Unicef with a donation. For further details click here<https://www.unicef.org/> to find out about the valuable work they do, helping children all over the world. We would like to take this opportunity to wish you a Merry Christmas and a prosperous New Year. Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
Hi Fabrizio, On Tue, Dec 12, 2017 at 7:49 PM, Fabrizio Castro <fabrizio.castro@bp.renesas.com> wrote: > Document SoC specific compatible strings for r8a7743 and r8a7745. > No driver change is needed as the fallback strings will activate > the right code. > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > Reviewed-by: Biju Das <biju.das@bp.renesas.com> With the issues pointed out by Simon fixed: Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Tue, Dec 12, 2017 at 06:49:37PM +0000, Fabrizio Castro wrote: > Document SoC specific compatible strings for r8a7743 and r8a7745. > No driver change is needed as the fallback strings will activate > the right code. > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > Reviewed-by: Biju Das <biju.das@bp.renesas.com> > --- > Documentation/devicetree/bindings/timer/renesas,cmt.txt | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/timer/renesas,cmt.txt b/Documentation/devicetree/bindings/timer/renesas,cmt.txt index d740989..1e4fe98 100644 --- a/Documentation/devicetree/bindings/timer/renesas,cmt.txt +++ b/Documentation/devicetree/bindings/timer/renesas,cmt.txt @@ -22,6 +22,10 @@ Required Properties: - "renesas,r8a73a4-cmt0" for the 32-bit CMT0 device included in r8a73a4. - "renesas,r8a73a4-cmt1" for the 48-bit CMT1 device included in r8a73a4. + - "renesas,r8a7743-cmt0" for the 32-bit CMT0 device included in r8a7743. + - "renesas,r8a7743-cmt1" for the 48-bit CMT1 device included in r8a7743. + - "renesas,r8a7745-cmt0" for the 32-bit CMT0 device included in r8a7745. + - "renesas,r8a7745-cmt1" for the 48-bit CMT1 device included in r8a7745. - "renesas,r8a7790-cmt0" for the 32-bit CMT0 device included in r8a7790. - "renesas,r8a7790-cmt1" for the 48-bit CMT1 device included in r8a7790. - "renesas,r8a7791-cmt0" for the 32-bit CMT0 device included in r8a7791. @@ -31,9 +35,11 @@ Required Properties: - "renesas,r8a7794-cmt0" for the 32-bit CMT0 device included in r8a7794. - "renesas,r8a7794-cmt1" for the 48-bit CMT1 device included in r8a7794. - - "renesas,rcar-gen2-cmt0" for 32-bit CMT0 devices included in R-Car Gen2. - - "renesas,rcar-gen2-cmt1" for 48-bit CMT1 devices included in R-Car Gen2. - These are fallbacks for r8a73a4 and all the R-Car Gen2 + - "renesas,rcar-gen2-cmt0" for 32-bit CMT0 devices included in R-Car Gen2 or + RZ/G1. + - "renesas,rcar-gen2-cmt1" for 48-bit CMT1 devices included in R-Car Gen2 or + RZ/G1. + These are fallbacks for r8a73a4, all the R-Car Gen2 and RZ/G1 entries listed above. - reg: base address and length of the registers block for the timer module.