diff mbox

[3/4] arm64: dts: r8a7796: Add GSX device node

Message ID 1513350890-2446-4-git-send-email-ulrich.hecht+renesas@gmail.com (mailing list archive)
State Changes Requested
Delegated to: Simon Horman
Headers show

Commit Message

Ulrich Hecht Dec. 15, 2017, 3:14 p.m. UTC 
From: Takeshi Kihara <takeshi.kihara.df@renesas.com>

This patch adds GSX device node for R8A7796 SoC.

Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
---
 arch/arm64/boot/dts/renesas/r8a7796.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Geert Uytterhoeven Dec. 18, 2017, 10:08 a.m. UTC | #1 
Hi Uli,

On Fri, Dec 15, 2017 at 4:14 PM, Ulrich Hecht
<ulrich.hecht+renesas@gmail.com> wrote:
> From: Takeshi Kihara <takeshi.kihara.df@renesas.com>
>
> This patch adds GSX device node for R8A7796 SoC.
>
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>

SoB?

> --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> @@ -2241,6 +2241,14 @@
>                         };
>                 };
>
> +               gsx: gsx@fd000000 {

gpu@fd000000?

> +                       compatible = "renesas,gsx";

That compatible value sounds a bit simplistic to me.
In addition, it's not yet documented.

> +                       reg = <0 0xfd000000 0 0x3ffff>;

reg = <0 0xfd000000 0 0x40000>;

> +                       interrupts = <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>;
> +                       clocks = <&cpg CPG_MOD 112>;

According to Figure 23.2, there's an incoming reset signal, but it's not
listed in Table 8A.28.

> +                       power-domains = <&sysc R8A7796_PD_3DG_B>;

iommus?

> +               };
> +
>                 pciec0: pcie@fe000000 {
>                         /* placeholder */
>                 };

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
diff mbox

Patch

diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
index 0b8558d..d3264e7 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
@@ -2241,6 +2241,14 @@ 
 			};
 		};
 
+		gsx: gsx@fd000000 {
+			compatible = "renesas,gsx";
+			reg = <0 0xfd000000 0 0x3ffff>;
+			interrupts = <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 112>;
+			power-domains = <&sysc R8A7796_PD_3DG_B>;
+		};
+
 		pciec0: pcie@fe000000 {
 			/* placeholder */
 		};