| Message ID | 1514469681-15602-5-git-send-email-jacopo+renesas@jmondi.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Simon Horman |
| Headers | show |
Hi Jacopo, On Thu, Dec 28, 2017 at 3:01 PM, Jacopo Mondi <jacopo+renesas@jmondi.org> wrote: > Add Capture Engine Unit (CEU) node to device tree. Thanks for your patch! > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> With the issue below fixed: Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- a/arch/arm/boot/dts/r7s72100.dtsi > +++ b/arch/arm/boot/dts/r7s72100.dtsi > @@ -667,4 +667,13 @@ > power-domains = <&cpg_clocks>; > status = "disabled"; > }; > + > + ceu: ceu@e8210000 { > + reg = <0xe8210000 0x209c>; Given the last documented register is at offset 0x209C, the region above is too small (also in the example in the DT bindings). But due to MMU granularity, it will be accessible anyway. reg = <0xe8210000 0x3000>; I assume the mandatory "remote-endpoint" property will come with the board (GR-Peach) DTS patch? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Jacopo, Thank you for the patch. On Thursday, 28 December 2017 16:01:16 EET Jacopo Mondi wrote: > Add Capture Engine Unit (CEU) node to device tree. > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > --- > arch/arm/boot/dts/r7s72100.dtsi | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/boot/dts/r7s72100.dtsi > b/arch/arm/boot/dts/r7s72100.dtsi index ab9645a..b09b032 100644 > --- a/arch/arm/boot/dts/r7s72100.dtsi > +++ b/arch/arm/boot/dts/r7s72100.dtsi > @@ -135,9 +135,9 @@ > #clock-cells = <1>; > compatible = "renesas,r7s72100-mstp-clocks", "renesas,cpg-mstp- clocks"; > reg = <0xfcfe042c 4>; > - clocks = <&p0_clk>; > - clock-indices = <R7S72100_CLK_RTC>; > - clock-output-names = "rtc"; > + clocks = <&b_clk>, <&p0_clk>; > + clock-indices = <R7S72100_CLK_CEU R7S72100_CLK_RTC>; > + clock-output-names = "ceu", "rtc"; > }; > > mstp7_clks: mstp7_clks@fcfe0430 { > @@ -667,4 +667,13 @@ > power-domains = <&cpg_clocks>; > status = "disabled"; > }; > + > + ceu: ceu@e8210000 { > + reg = <0xe8210000 0x209c>; With the reg issue pointed out by Geert fixed, Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > + compatible = "renesas,r7s72100-ceu"; > + interrupts = <GIC_SPI 332 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&mstp6_clks R7S72100_CLK_CEU>; > + power-domains = <&cpg_clocks>; > + status = "disabled"; > + }; > };
diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi index ab9645a..b09b032 100644 --- a/arch/arm/boot/dts/r7s72100.dtsi +++ b/arch/arm/boot/dts/r7s72100.dtsi @@ -135,9 +135,9 @@ #clock-cells = <1>; compatible = "renesas,r7s72100-mstp-clocks", "renesas,cpg-mstp-clocks"; reg = <0xfcfe042c 4>; - clocks = <&p0_clk>; - clock-indices = <R7S72100_CLK_RTC>; - clock-output-names = "rtc"; + clocks = <&b_clk>, <&p0_clk>; + clock-indices = <R7S72100_CLK_CEU R7S72100_CLK_RTC>; + clock-output-names = "ceu", "rtc"; }; mstp7_clks: mstp7_clks@fcfe0430 { @@ -667,4 +667,13 @@ power-domains = <&cpg_clocks>; status = "disabled"; }; + + ceu: ceu@e8210000 { + reg = <0xe8210000 0x209c>; + compatible = "renesas,r7s72100-ceu"; + interrupts = <GIC_SPI 332 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&mstp6_clks R7S72100_CLK_CEU>; + power-domains = <&cpg_clocks>; + status = "disabled"; + }; };
Add Capture Engine Unit (CEU) node to device tree. Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> --- arch/arm/boot/dts/r7s72100.dtsi | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-)