| Message ID | 1516903391-30467-12-git-send-email-fabrizio.castro@bp.renesas.com (mailing list archive) |
|---|---|
| State | RFC |
| Delegated to: | Simon Horman |
| Headers | show |
On Thu, Jan 25, 2018 at 7:02 PM, Fabrizio Castro <fabrizio.castro@bp.renesas.com> wrote: > From now on, devices compatible with the generic compatible strings > documented by this commit don't need to modify the corresponding driver > anymore. > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > Signed-off-by: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com> Thanks for your patch! From commit 362922a1a5345d17 ("reset: Add renesas,rst DT bindings") As the features provided by the hardware module differ a lot across the various SoC families and members, only SoC-specific compatible values are defined. In fact the only commonalities are the presence of the MODEMR register (the mode bits differ), and the Watchdog Timer Reset Control Register. All other registers and bits depend on the SoC's CPU core configuration. Hence that's why I did not add generic compatible values. So unless you really need them (from this series, it looks like you don't?), I wouldn't add them. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/Documentation/devicetree/bindings/reset/renesas,rst.txt b/Documentation/devicetree/bindings/reset/renesas,rst.txt index a8014f3..2602a19 100644 --- a/Documentation/devicetree/bindings/reset/renesas,rst.txt +++ b/Documentation/devicetree/bindings/reset/renesas,rst.txt @@ -11,7 +11,10 @@ following functions: Required properties: - - compatible: Should be + - compatible: Should be a SoC specific string, followed by a generic + fallback compatible string when compatible with the generic + version. + The SoC specific compatible string should be: - "renesas,<soctype>-reset-wdt" for R-Car Gen1, - "renesas,<soctype>-rst" for R-Car Gen2 and Gen3, and RZ/G Examples with soctypes are: @@ -28,12 +31,16 @@ Required properties: - "renesas,r8a7796-rst" (R-Car M3-W) - "renesas,r8a77970-rst" (R-Car V3M) - "renesas,r8a77995-rst" (R-Car D3) + The generic compatible string should be: + - "renesas,rcar-gen1-rst" for R-Car Gen1 + - "renesas,rcar-gen2-rst" for R-Car Gen2 and RZ/G + - "renesas,rcar-gen3-rst" for R-Car Gen3 - reg: Address start and address range for the device. Example: rst: reset-controller@e6160000 { - compatible = "renesas,r8a7795-rst"; + compatible = "renesas,r8a7795-rst", "renesas,rcar-gen3-rst"; reg = <0 0xe6160000 0 0x0200>; };