Message ID | 1517804714-5554-1-git-send-email-yoshihiro.shimoda.uh@renesas.com (mailing list archive) |
---|---|
State | Accepted |
Delegated to: | Geert Uytterhoeven |
Headers | show
Return-Path: <linux-renesas-soc-owner@kernel.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0E430602CA for <patchwork-linux-renesas-soc@patchwork.kernel.org>; Mon, 5 Feb 2018 04:30:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E386F2838B for <patchwork-linux-renesas-soc@patchwork.kernel.org>; Mon, 5 Feb 2018 04:30:00 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D795728618; Mon, 5 Feb 2018 04:30:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E60FC2838B for <patchwork-linux-renesas-soc@patchwork.kernel.org>; Mon, 5 Feb 2018 04:29:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752208AbeBEE35 (ORCPT <rfc822;patchwork-linux-renesas-soc@patchwork.kernel.org>); Sun, 4 Feb 2018 23:29:57 -0500 Received: from relmlor3.renesas.com ([210.160.252.173]:61005 "EHLO relmlie2.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752195AbeBEE34 (ORCPT <rfc822;linux-renesas-soc@vger.kernel.org>); Sun, 4 Feb 2018 23:29:56 -0500 Received: from unknown (HELO relmlir1.idc.renesas.com) ([10.200.68.151]) by relmlie2.idc.renesas.com with ESMTP; 05 Feb 2018 13:29:54 +0900 Received: from relmlii1.idc.renesas.com (relmlii1.idc.renesas.com [10.200.68.65]) by relmlir1.idc.renesas.com (Postfix) with ESMTP id 99B837369D; Mon, 5 Feb 2018 13:29:54 +0900 (JST) X-IronPort-AV: E=Sophos;i="5.46,462,1511794800"; d="scan'208";a="270278954" Received: from mail-ty1jpn01lp0179.outbound.protection.outlook.com (HELO JPN01-TY1-obe.outbound.protection.outlook.com) ([23.103.139.179]) by relmlii1.idc.renesas.com with ESMTP/TLS/AES256-GCM-SHA384; 05 Feb 2018 13:29:54 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesasgroup.onmicrosoft.com; s=selector1-renesas-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=NpfY+uQSfOIN0WMydROmQbJ8bTFLLEPzRmXeF/gbLpY=; b=bnrAaQC+8ew48uB8jbKckuWkLuNw5mnAKo4LnmdrTm7RygBCLOUeCPEfB+Qm6U0HPdTmmsndxvWQHrahNbFOZime1+w8RxTFmdSVF7Xs79KmU9B9f/8cuY/pK3UPhn/PG7+/45LYebZnrjvB2O1RrLtUUjQAg1UUXS4ZKbHwC6U= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=<>; Received: from localhost.localdomain (211.11.155.138) by TY1PR06MB0989.apcprd06.prod.outlook.com (10.164.99.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.464.11; Mon, 5 Feb 2018 04:29:52 +0000 From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> To: balbi@kernel.org Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Subject: [PATCH/resend] usb: gadget: udc: renesas_usb3: fix oops in renesas_usb3_remove() Date: Mon, 5 Feb 2018 13:25:14 +0900 Message-Id: <1517804714-5554-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [211.11.155.138] X-ClientProxiedBy: OSBPR01CA0019.jpnprd01.prod.outlook.com (52.134.224.31) To TY1PR06MB0989.apcprd06.prod.outlook.com (10.164.99.23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: dfc58f6f-08da-4ec5-80ec-08d56c511a2b X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(4534165)(4627221)(201703031133081)(8559017)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:TY1PR06MB0989; X-Microsoft-Exchange-Diagnostics: 1; TY1PR06MB0989; 3:UtVU5JajjuwusOmrB3tfCqmwR4QaIleH8TfCJPQI+g5vj8g1jBd9Hx2Bm2QXtgwH6fV92gzYLztahVFbtIv0Lx/S4xQW1svo4Fz1e9BqpgV+cq8xGoFhX5CFPfUj70EG8HeIJaxu6az7l/uOw5kujQHHBK23frELcznuegsjFbhlWvEi84lpP4guXci76q1CuH6aa161394P2QZ1qvoDaGxoD4Ezetr+LuZLBa+ymPMXzEZlCDvb0N/0OFwV8/kb; 25:DGsfdZTUoTGeBT+tJGu1XJpv5xH+65HEL1Y9Ca0hTNnUBbO7YNDb8mO42ehnExnd1crtmeRFCk3AbAy3zJ1vDJR+ZGISDGcnrHZDiALV8pQrMIrxisgbx/TddMYc9zDrxiXxwr3TjUFg7ew8Addi0wgNN/t2Yb7niaDR2JUtLopt54EZhkIcJ36CDmoxD+XxZYW55D2zB2zrNTl+j8w9JJnk3Xh1fCP5jNgExTLRItzjt0BK6PxuPGRKrBYS8kb7HFC2J2WVFKHx/5R7jLyICYajY96miSbJc+ksWLYvNksa76Gls+RNN70xJMA+t1U2PSCa8Sj2OO4NK1XNw0qDQg==; 31:dOwdtX3O7wG7KrY38d+UpKAh+tIC8FBZ7cAwrCkGL6W6KO8+qzLhSqh5QrVlUh8sjKQei5vR0a3p/aprwvqR2uFKU+h5aLBDX8nTPTKhqtuiWKXXdmA4puXG5XN8A5JMBBfkLmv022gGGCWaallDyD4hgujtfQzqHAS4Bh9Um8jAYkRY1iLIhEd8XHZ9SZ/ddXnYhO+dEjFA5BsUIN/NLByG6PiIuy0KC0qkWnGFTS4= X-MS-TrafficTypeDiagnostic: TY1PR06MB0989: X-Microsoft-Exchange-Diagnostics: 1; TY1PR06MB0989; 20:5lKOJl83UWRivopn0rpsOeP4yigGSCKJeM2ZZ25rd4RgDFrrBHvaMImyR4m53G419wEyeQDXCBPFdjSoWhA4XgtIcMuAHmOvzI8DLLys7EkF9ikcmgRasKy13z4n/As/hH8b1uGKpcjxX+riJDnpQwe1p4n1hGCe+hBO+F0+PSY3z3HqtYBhVeA5JGz9wBD8SAHBDGJHC3RgZWj5Vp5ONSTkjhPa5xt7LMrF8zLp9tJI7qT7MJMVEbVGZnYCYXtvhoFtWGhkLXE8I7OsYNehmthsYuPsCs6PETp+qPeVRvbjhEZw4GcSHI6NUS5h2StqqKfPv8GJLbQIled6strnwLKcA7/j61tsDXz3H+x6h6tQViEJAIiA1FToH9h9HNN/tG+PVy3nz6FmezVmtlA7XC+JnK60IMfJNSwX/VeGSQhbcRXkPc/2zqOUqikuGjpf9U3dc+0+yGW7kh+1oC1/xGJNnBRbUhHrF/zDNEkJvoQ/RW7oCaO7J3FoueY8M+XE; 4:nzQ1LOcSkYG+ko1+4F0S6+qYGvf5tE2cEHVjc3IADYHFZomvG+IC4UFcme8vNzsUJrtVjGEY8GkCvrjsj/k1CMwEbyKogx3XvNC5Fdxv7zF4Vs/EcFAPjhtDLW5mCxxxEPACIQvZrFkYCUfOWjH7AT8iXMB0Y5hYMabAxzJt/6Ivlk5TNWsDZVqfcJXpZEOOa62eckxdrJvh/o6/UrYQd+1JGI1BAiZcySkDBPUKVmAMJozV9bnOLVjSkZpzHUqMZmG17h2/vn0YiYygrM8D6A== X-Microsoft-Antispam-PRVS: <TY1PR06MB09891E969609152CD24F8BFAB8FE0@TY1PR06MB0989.apcprd06.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(93006095)(3231101)(2400082)(944501161)(10201501046)(3002001)(6055026)(6041288)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061750153)(20161123560045)(20161123558120)(6072148)(201708071742011); SRVR:TY1PR06MB0989; BCL:0; PCL:0; RULEID:; SRVR:TY1PR06MB0989; X-Forefront-PRVS: 0574D4712B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(6069001)(346002)(39860400002)(366004)(376002)(39380400002)(396003)(189003)(199004)(6916009)(6512007)(81156014)(81166006)(42882006)(97736004)(2361001)(2351001)(2906002)(68736007)(16526019)(47776003)(106356001)(50226002)(66066001)(6666003)(26005)(36756003)(52116002)(25786009)(8676002)(8936002)(51416003)(50466002)(48376002)(53936002)(6486002)(107886003)(105586002)(316002)(4326008)(15760500003)(3846002)(6116002)(5660300001)(498600001)(386003)(78352004)(6506007)(305945005)(16586007)(7736002)(59450400001)(3720700003); DIR:OUT; SFP:1102; SCL:1; SRVR:TY1PR06MB0989; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; MX:0; A:0; LANG:en; Received-SPF: None (protection.outlook.com: localhost.localdomain does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; TY1PR06MB0989; 23:iacEojpNDPzGpXiAcdXpJiK2Ey/2OQBKQxtfn6eTb?= =?us-ascii?Q?jsbCT767CesV38U40ucMdpD8wR6da3SczEUZkhWtpVUu7LezKpG1YQYemv7z?= =?us-ascii?Q?ofOlkEMuVqdKexVfvl++nh9U5aWsg4lSvwsmgb1LY07wIlTWomJ84PJF37LG?= =?us-ascii?Q?CTM78rhn7gfD0FghJ//bm/ojTJcOM9uxX7FLgRqwdE4tsfoh+BGT8696Rrnj?= =?us-ascii?Q?2FE3MlP9fU69ZljkFiHqqQtXJ5nx3TkJMQSQf5SS/xX/zWOIzXSR7OhtH89g?= =?us-ascii?Q?d5kTa7/jLd9fdeXTMexsnn5oLshIZyI+FDqMNEj9Z3VPuv7tPWmL1cQgiGEJ?= =?us-ascii?Q?uot9/rvAGFCFwgUINuak4ce+Wh47geoPmWidzuhzSrkkiTseTqNXVW1QE06X?= =?us-ascii?Q?LuDrnb6YFlWes0SsrAyIdsjZpomW1Nacf0hjlyNTRm4NQHRRqzbqXYSxSY/Z?= =?us-ascii?Q?wwZt+LZfK6oZqJZYvOH9ERXD+I+cDbaJp8vVekq3BGsPJyx+KoY+MFY6UbGj?= =?us-ascii?Q?PBLfi65SC+4YRTdtx8GvQBk80pEia1OBNPpq+deqoyUZU4i5Bn7x7KgzGwuW?= =?us-ascii?Q?uZGECHfGBGRv7pujzGiB/2Ad4mLWlV212BqKMaJ9KKq1XMA6re1Pzg1enCTD?= =?us-ascii?Q?hHgJ6UCd8NQqCQuqVf3UXyKyU/sVTokF1GvQC0I/6GZYpo3SdLTSy9yOjSby?= =?us-ascii?Q?3xWlBjiw5e1TtTPMt0Dv0K06X/vA0Bsr/8MrYxywwqScFZIDTXsmcPSOP3ch?= =?us-ascii?Q?1EFs1qg0WJavQxkQi9TQosZn86hZTK6omz5Wpmjn/LTxVjeB3/uY2mjJZ8It?= =?us-ascii?Q?wfSzUhA/gbQu44dIBau8r+KFDLqsUbhGtR/5BNZH3g8qaDit69ahYCt1QPFg?= =?us-ascii?Q?QmI6pGfeIC93wSJovJO57MZ8mc51GBo7GuZeM4UDeJhf9+SQrnXwUKud+QNe?= =?us-ascii?Q?y0YemVvCbPiiLxzPYjNJV/GYIV25J1yZ64Ztos/eA3zP0C9lC6sMVCp8GNSJ?= =?us-ascii?Q?W9gRPuFRTuQTml50iKMXIUowBNBODQOiVl70BU8P/XFXdOhjcKjl5RTctNi5?= =?us-ascii?Q?NWHpj4mlNXaWBfzX3coScJW23WeCecUjdYGGUdu7ul5EFa6/if60KfXw8NX4?= =?us-ascii?Q?cDL0DPz4QyMmLypW7b/BVEGKNV7I755eKj82fMOpl6hicGf1h7UPS3kzubA4?= =?us-ascii?Q?w+qts0GaGJlgHRl1F4UJfaDczKjNp/t9iGr?= X-Microsoft-Exchange-Diagnostics: 1; TY1PR06MB0989; 6:4ZPi20PcDMZ9Vko0w3aXujiswEp7SRfhsUawA32c8qQHRzK7y7NEmcjVg3WtDkGDlGwyqav5yrks62VwhmbImsXe8xQ2sHjDQoacIV2qpMJ/KwNVvTvkpSoSqNqbZY3lb1zs/Q/SoZasZQ1r6M3tbg+3bBAIZT32E6mD7iSg1BvNYeSBG9jaQKIDGMzeDVZ6Qkc3X5O55C2UJSI6vLSwEhaw/cmEHnGjlIM53Uah6cFoHjBDvtspHEzp4EiBiepALkKRHBdm2A6rf7ClfPHDXsX97ys1cnQu3x4kMsqoGv5AJnK+o/iZbiE2yPD82sil1h00YJSlfnANo+vUxlTkPQjbkGzouamtON9AqxRDZUw=; 5:DLlismtvNiMoGIWGpQfr+/Deu8tHHyUbntQW3ltNWAp9KjfdHE9YLcn1M1CAd+6x4Kv0F2ydo9d/99fWAT2lT1FG1XIihNPKc0o0qJc20KlfFFWRarmz3eg/2zxQPf0OQ5lH4ULcsqwukpbGNzaQ8lYhABHTYz9WM/4MsfiBvtY=; 24:niMe9YNDRRPklhyFkZbkeN3HnoFj5GQgX7RSez5cFVd0XPclWZ3ZaAwJmnbP+TfEXNjdRVg+U8y1HGHQZ2K3ibm3sjK+yFTXHTenJRROVZk=; 7:V7smirKu6vy5gl3/KxQW3Jeg+tuv84pnau7yNe8u0F+HEQB01Or2Keql4y0+BD/8bxYRbkgoqqc7b7e8hILDptfFEjrfwsIwqgPDtwrbTd2sbsKchEYZVWMYU4YgSPsqQH/5rBC+7p+F9c2AeORMjsypkrXIb3u200AJpHlOI1X8aDO2hFeYN65o1BLoWgBEZzP7PcPcEjQ+hAX4IGbJlUPT0+j6P+CHQfA3ATgOO3mTg53UNbS/UaEd/ktTr2qI SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; TY1PR06MB0989; 20:j//lEh3TGhrpLpEdpHlDipD5BN3CldxQTdHaKWQNtskLxrnOwLGMUE7kkjV4NEHqBkItlPknL+Uk/SE9waHhbcg/NY6T6m6N6LI9TGuvFIInucJGwN2KkbRsoQVu60JXFGQttQU/EvivuXjDgL1JayNhPi9Z38NwYh2X6EWO87E= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2018 04:29:52.8127 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dfc58f6f-08da-4ec5-80ec-08d56c511a2b X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY1PR06MB0989 Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: <linux-renesas-soc.vger.kernel.org> X-Mailing-List: linux-renesas-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP |
diff --git a/drivers/usb/gadget/udc/renesas_usb3.c b/drivers/usb/gadget/udc/renesas_usb3.c index 6e87af2..409cde4 100644 --- a/drivers/usb/gadget/udc/renesas_usb3.c +++ b/drivers/usb/gadget/udc/renesas_usb3.c @@ -2410,7 +2410,7 @@ static int renesas_usb3_remove(struct platform_device *pdev) __renesas_usb3_ep_free_request(usb3->ep0_req); if (usb3->phy) phy_put(usb3->phy); - pm_runtime_disable(usb3_to_dev(usb3)); + pm_runtime_disable(&pdev->dev); return 0; }
This patch fixes an issue that the renesas_usb3_remove() causes NULL pointer dereference because the usb3_to_dev() macro will use the gadget instance and it will be deleted before. Fixes: cf06df3fae28 ("usb: gadget: udc: renesas_usb3: move pm_runtime_{en,dis}able()") Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- drivers/usb/gadget/udc/renesas_usb3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)