Message ID | 1522671694-10229-4-git-send-email-yoshihiro.shimoda.uh@renesas.com (mailing list archive) |
---|---|
State | Superseded |
Delegated to: | Geert Uytterhoeven |
Headers | show
Return-Path: <linux-renesas-soc-owner@kernel.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A27DB602C8 for <patchwork-linux-renesas-soc@patchwork.kernel.org>; Mon, 2 Apr 2018 12:22:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 921EA2874E for <patchwork-linux-renesas-soc@patchwork.kernel.org>; Mon, 2 Apr 2018 12:22:00 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 86C3228A48; Mon, 2 Apr 2018 12:22:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 19D5E2874E for <patchwork-linux-renesas-soc@patchwork.kernel.org>; Mon, 2 Apr 2018 12:22:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751322AbeDBMV5 (ORCPT <rfc822;patchwork-linux-renesas-soc@patchwork.kernel.org>); Mon, 2 Apr 2018 08:21:57 -0400 Received: from relmlor4.renesas.com ([210.160.252.174]:16794 "EHLO relmlie3.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751242AbeDBMVu (ORCPT <rfc822;linux-renesas-soc@vger.kernel.org>); Mon, 2 Apr 2018 08:21:50 -0400 Received: from unknown (HELO relmlir2.idc.renesas.com) ([10.200.68.152]) by relmlie3.idc.renesas.com with ESMTP; 02 Apr 2018 21:21:49 +0900 Received: from relmlii1.idc.renesas.com (relmlii1.idc.renesas.com [10.200.68.65]) by relmlir2.idc.renesas.com (Postfix) with ESMTP id 70B9A8CB99; Mon, 2 Apr 2018 21:21:49 +0900 (JST) X-IronPort-AV: E=Sophos;i="5.48,395,1517842800"; d="scan'208";a="275594044" Received: from mail-os2jpn01lp0144.outbound.protection.outlook.com (HELO JPN01-OS2-obe.outbound.protection.outlook.com) ([23.103.139.144]) by relmlii1.idc.renesas.com with ESMTP/TLS/AES256-SHA256; 02 Apr 2018 21:21:49 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesasgroup.onmicrosoft.com; s=selector1-renesas-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=55lYlYVpRGXD0seXig8ALXQXazP8D4ogF1euJRUM1O4=; b=iEl3oLt3zsK8RFaFrJyDqgzjojgNvM2t7kAjPEAbH4NcvsXIFI9vMW9gO9OI9QvUsnNh3/sxqC4A0EpmLza4kDOGsNziTpTyMOveCYDdj9+x9XiMqasFjPjjWuwVpjj5OLFeZQjtoAI75mJMvNjiCSX3NFhOiZA3TghcgnmBgyc= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=<>; Received: from localhost.localdomain (211.11.155.138) by TY1PR06MB0990.apcprd06.prod.outlook.com (2a01:111:e400:59f2::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.631.10; Mon, 2 Apr 2018 12:21:46 +0000 From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> To: balbi@kernel.org Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-renesas-soc@vger.kernel.org, stable@vger.kernel.org, Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Subject: [PATCH 3/4] usb: gadget: udc: renesas_usb3: should call pm_runtime_enable() before add udc Date: Mon, 2 Apr 2018 21:21:33 +0900 Message-Id: <1522671694-10229-4-git-send-email-yoshihiro.shimoda.uh@renesas.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1522671694-10229-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> References: <1522671694-10229-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [211.11.155.138] X-ClientProxiedBy: TY1PR01CA0141.jpnprd01.prod.outlook.com (2603:1096:402:1::17) To TY1PR06MB0990.apcprd06.prod.outlook.com (2a01:111:e400:59f2::24) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 028a77dd-687a-4788-d220-08d598944d6b X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(4534165)(4627221)(201703031133081)(2017052603328)(7153060)(7193020); SRVR:TY1PR06MB0990; X-Microsoft-Exchange-Diagnostics: 1; TY1PR06MB0990; 3:sDUqJ49XxNEOJ58YG75L7c2bVa0k1p2j/bDk+tAUA4AQHzK4wAN7qDrmuyWSU1W65wV3DMCGGRKV1ssWLxO0cBQNrZ97HoRL8zbawsTuDS2fLXXwhbvrbNEtcIquEeA6Z8EEr/EtiHhvXBA5qU+6F2ak0R7xOW7hmNNHBrcS/maSfCXW5Z3/YJq1M+du3bcsFxuEWVjLp9k6THcHHtjbIMqp/FNY57vzygYgyLfQD/5fDaRbe9K4I8hGMplD91YT; 25:9WoyLdDIY5jUX03+iMpOe2nAXmS1N5s+aa7n+nb7MQHVlo19qJuw//xbriRE9CHQ1o+GTpH5hqvb9kAJJZFMAp1G50kDKRBWsCtzB5II45UObYLZiXzrjK/N3Qp66Sa1i9Nb67zsoJsU2Etr71Ha/iJsK86Wz+UMdON2gbWM97isVRtWmimA9m3IHrfZKMudF603hnoUWUIfVmTssMvdqTjq1v9s0CC/lXRDpn15rG7qi8iY8KkP7x7qbDGy7Bh7NFYIBf/p0GhmAyEi/fvFttA7dPzji1hZN87wNEyADsNdpDbd+qAALvqTROb5ixWeSXULk3tBGlxK4eUP+Ndovw==; 31:Yf7fmIiaBtV8e7apMdD5H7FN8EJNJCAQ6WVc63FOd/IiyrEPY+cw6m3rYYFXZJAVIQ40VoDdwpbQ41pGgJInwGftyuXUJpobMbFObmyu5j6JMd/zNd4AiF0cHeqHSZBtpf0KDpHfesZZWJ7fOnOcb/7g/yoyEQWDHJ9iI1reYH5N0OhhEfr1kKr0O2F0yKrcX72xZyyMfGZJcg7maVWWrvwTyrLOCr+HWu9P9dBvIBM= X-MS-TrafficTypeDiagnostic: TY1PR06MB0990: X-Microsoft-Exchange-Diagnostics: 1; TY1PR06MB0990; 20:VjHS6968gbY5WipzvdcbOIjEgR9psMxTVkpVImq9AeDz2nnSpQjJ85UVPu8g1+tTRe56hxIJlK+AYQJdZdrc9VkjIMNXWIIVHF7uIFoqmfsA5zqwklD9R4m0ptj3GMOIlMM1rZsvtx0RAAC2ALw4hYLcuVmOQNY6EvCXt5h/QQyAbIXj8BSgIjZwvh+baNu020zavOIHSQhVvP1ncH4guLv1iZ8YMLa/bwMWQnepKX/q0Eg7kYPSRFG3ayW4wLt9ZKTEHEh2Snu7mq2JBgh62MDbMn6LT6fFfi9eFqCmdMDCFpeV6vTu4u74ESkEE+5kKnP4j9sGr7goF6EcBBZrUnQT0qmUGKjWgOHfq3Zx/n2W37ZabWfTQ2AxKEESjqOugmamUNfBeAN0p3SLcr5vggFDuLXxuzVVKcWsPfQcg3LbfHti49gZtoc/73Wc8VmcX7HvKm00sbU5qzBzuJIxNRwc1drgAFFhBDl5yOf9TWYcIfzgu+mRjGCl6uPDdXRT; 4:W1u/nhvTXJIcEiPcqJHbFh+gbXRFnfBLDL2sBFUKsJfN9yFzibCc7ibzIKUU+8nQ7Qgoyuxo936btQXAmob04ADkttQD2ywRX+497aQEyyv98TUqko6hhHUjlr9pCMeZ3BLJCS2gZfRVnOr2YY9STC7yeawnH8jVBTSgwchho82xAFqx0D9JmEqUe1Kd3gW03LgXFyt+XwlJ+ovlmCj4Y3CHhNZloxnB70aTCnuJvG+ettvEvxf5dvBpX8Wb2uI9/KmJK03KrqMg0COqCzVbPAU7Sskvhkyk2dorxIdfe8qQaK1eLykCJT+1QlQPB3Wt X-Microsoft-Antispam-PRVS: <TY1PR06MB0990CB1A584EC64C70DDDE4CB8A60@TY1PR06MB0990.apcprd06.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(9452136761055); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231221)(944501327)(52105095)(3002001)(10201501046)(93006095)(6055026)(6041310)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061750153)(20161123564045)(20161123558120)(20161123560045)(6072148)(201708071742011); SRVR:TY1PR06MB0990; BCL:0; PCL:0; RULEID:; SRVR:TY1PR06MB0990; X-Forefront-PRVS: 0630013541 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(6069001)(396003)(376002)(346002)(366004)(39860400002)(39380400002)(199004)(189003)(81166006)(52116002)(81156014)(50226002)(78352004)(8936002)(476003)(6116002)(3846002)(68736007)(4326008)(2906002)(8676002)(956004)(2616005)(486005)(6666003)(6512007)(6916009)(51416003)(53936002)(11346002)(446003)(486005)(59450400001)(106356001)(36756003)(107886003)(2361001)(6486002)(42882007)(76176011)(66066001)(47776003)(16526019)(26005)(7736002)(305945005)(50466002)(105586002)(48376002)(498600001)(316002)(97736004)(16586007)(6506007)(386003)(2351001)(5660300001)(25786009)(3720700003); DIR:OUT; SFP:1102; SCL:1; SRVR:TY1PR06MB0990; H:localhost.localdomain; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:0; MX:0; Received-SPF: None (protection.outlook.com: localhost.localdomain does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; TY1PR06MB0990; 23:zZi+Z7a0z40ESn+T1GQ0aILN6EHlt0JCqJnje4T/+?= =?us-ascii?Q?8AGOlbYlrr9dBXS2W9i59FJfUqQEMD59MesF2TryIrEwnuQCKeYjE+rlJjSU?= =?us-ascii?Q?0aUVK5k+hjmVFb1kFkeEsOhLMZBlHC6noKQTemrV4rw3gLZ1TwaBHWT+HY1U?= =?us-ascii?Q?+MgYwQlJsXUh+m2fJgWz80Fgvbj6kO6PNcQmq1ImutnmVmGekX/v9Fq3DZ5g?= =?us-ascii?Q?/vlXWEz/MFTB50+uwheMpyrM96vfKtMbCU9qYsHAS69jwx9baeZwUIyh5diy?= =?us-ascii?Q?ZEmaf1Z1ELbyS5P9wdRYtRj34TZlOnTVLxgqC5eSzPau0ACdXd55iPQ0mcYk?= =?us-ascii?Q?iCDgf+0KS2qb/kf9zbburdZbTQZ/2Rb+rKyZAKhvEHdi6qIQgevhKZiMngD/?= =?us-ascii?Q?cUW8mdk/fO1048BTSeigp8Epx7PqpaZFlXAT7OqOHMboZ4D/5CtaPD52TPUX?= =?us-ascii?Q?dDy2MYKLrGhSC45ieX5nw9OuMipJMZoJcG7Vx/HWXCRUgHgX2d6tOmikePYz?= =?us-ascii?Q?X5Ke4tNlC4CGRmY1t4FZCdh+nNSUH1W7gvH2pXvekumWbnVyuT4k6zmJhrVC?= =?us-ascii?Q?gQmSqGnKluAdRyMJf0ipq+RbyfQCPI+nMTTQClJ669EF26rQ663+iD8A4pRD?= =?us-ascii?Q?hUEq0SqGzhDdab4yvRQC8DTD1BYYwOEibARbHvxjIsgbNHk8KYJaJkMYIuMq?= =?us-ascii?Q?I8PHGgUyq31MVv//FzhKxLtkcaym7IJW/kn/JeeWeqBnBo/jpTTzSo55m9nq?= =?us-ascii?Q?bNKIR10km6EGEQ4p3/lc4yKW2QlKOdH74eXLcUryaJe9CuwE9ypbsM2IFV6m?= =?us-ascii?Q?VhrQRdu+/ZdOiM8veE71R9S4+BfeKewBKhs6TUZqPOFGzO6hqKGrzEBOg4lX?= =?us-ascii?Q?3IzaQg4X3HKAQ5pfP1e6qDY0tmFmM1FyEFsNAn5oj48tm1UOJ/RitusqnINV?= =?us-ascii?Q?b9iqf0CA7raAY6r73dBPQfq63p2rNvJ/Oqfb8dFOhU1UR7yeQcjmxRgunjJo?= =?us-ascii?Q?4/RNDc3rpEALqYNW7PqWS8wObaDnUFEPSAGcQypt0BIHj5cZqO7MLHHW00A2?= =?us-ascii?Q?yW0jY7Qi39Trn4mHUhUPl7lg5tKydcPNDTH/yMtEQxN1pIeg//2LQTpS5Jdq?= =?us-ascii?Q?ExuUX/jMo7DmlYk/gw5V3uZyKu/kXIKBfAONeFWT9BKL+ZWXRZ7c5xWykmvQ?= =?us-ascii?Q?g3aKH/vEvY3v5cDr6lVMtIMt8UHAFrMEMcdEBqAStINVJ1osbdB4OYSGjNfN?= =?us-ascii?Q?YLU/8t45FyZ2tAWgTYUiHUUqvY4Hb3ouGmz1MU9YmUN6Jlylx66hXrLZkwXs?= =?us-ascii?Q?aqQleQINPeS/9ifbf47ZoXV3AF9m9dvjdSJf8WRLKuO?= X-Microsoft-Antispam-Message-Info: uJFOslcaWutl1wao/UkAcHdJZRh/FU/6n8tjgtYzK3f14iGAreIXYnXt/ktueyf88rURwcueiUQ0UlvHZSCOx5VrvJJEo0NFZvVC1PQ9HkHZizRN5kbNSwiwxUGBvaUPuWozy9tPnBoYpXtPMTnYNg7XOj+PsfGeJwogFpr4Q3qxExkR5X1epThQCkxojMzv X-Microsoft-Exchange-Diagnostics: 1; TY1PR06MB0990; 6:+vJQzzO3cBbzU5sNFD+j/JI+7nysEh4TSfWrWcMksByc7ZPJuFY0Odh+hjB6nhYAv1TvGepL/b8hfVVVxmFOw/sfo4bqSN8ksTVg8E3ytwbUtobcnRkx4s9aHsV0p+b/Hv8CXrg/4kOI7mE6RuiT+AYJpgeNiJTwx+kzopmqbiXWS3qKlLh+ZVpzH7uaIQIZ8vzDEQx10/ZxYTawNV/Jf1qhvYY/BvGy4stFWz/1cK+OUIntk2m1B2o7xSJVXo8XzW2QphBVKolU3SYLOxyBEvw5MVoeP/A5L4homCll3owz48irzWyljffxwyVrky9sew9tLcE2cHLGKX1u/PV9GIHi0ipaG2glCbh+6HlIKzJbUTm3yQ26nXVDHolD0OTnngxXCEGKsNsNh7dFJPtNBSqdFkIAoO8Ah8+lITT8TvLJUpwa4msijna8idCtvFVnq/Vb3tOYx5nsI39b6YXMQQ==; 5:fzNwQWMfMtb7whHKLDpyl/lF5VXrNVO/MB+kglWy0TMAeNIG02vu/po/zUU9XtnqNeaS0oRmkyPsQfpb0TI6c1BHXaDVfY03J26TB801QsYerdW+nL4vxS7tsZCEglnAew5rptQw+SX4Xi/9Cx5Xd/BThuuGPeA8vML3c825Iyc=; 24:GOTC4Fy5IBL7i+O1EvBNKVuo5xuRWbo12BdpUThrWAyAoF3IeE44TVP6HEjhR4Bk4Raxv7I3XiAYBYiPrdLNuw7XO9L7oMLBRh2ekRXvke8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; TY1PR06MB0990; 7:uhbUdCBy3CjV40zljrKbEH9Nu4cdeTh6k65K6IYBUP8EkOcKSMR6ngzgAZDcU3kLfEbBensGEemI6iPgTG23Ip+BKEDLmWELR2rTi6OFrNBRllbZ+Mms0X1M3kqy+U/GALjNSl8bcHwVuwvfV2EebV8l5BbjfZKlwZ02Dg4op/JDSeqPhb1lBzS464ePQ//8RPT9ZH/xgcifCEQnLBtnGvmT79OtQDIdjdTxxw2agKNbyqT7Fi23OGtuTVdQLoZF; 20:qASwnC6y4QelAOpLVwxtRM5005d8WJJDeMGK2Mkx1nooTeKmlI17Xh3fm34j7if7SSEosNWBqu/wExI9CgrOsA48PXKmPpCMjy6f6aro0W5j4FfP37CmH/z5tL1wthBBryCuWz+6Q9vPgmrlxB6Du6AzFQFErI3YoJo0hFQ4anY= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2018 12:21:46.3505 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 028a77dd-687a-4788-d220-08d598944d6b X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY1PR06MB0990 Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: <linux-renesas-soc.vger.kernel.org> X-Mailing-List: linux-renesas-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP |
On Mon, Apr 02, 2018 at 09:21:33PM +0900, Yoshihiro Shimoda wrote: > This patch fixes an issue that this driver causes panic if a gadget > driver is already loaded because usb_add_gadget_udc() might call > renesas_usb3_start() via .udc_start, and then pm_runtime_get_sync() > in renesas_usb3_start() doesn't work correctly. > Note that the usb3_to_dev() macro should not be called at this timing > because the macro uses the gadget structure. > > Fixes: cf06df3fae28 ("usb: gadget: udc: renesas_usb3: move pm_runtime_{en,dis}able()") > Cc: <stable@vger.kernel.org> # v4.15+ > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
diff --git a/drivers/usb/gadget/udc/renesas_usb3.c b/drivers/usb/gadget/udc/renesas_usb3.c index 1c54a77..738b734 100644 --- a/drivers/usb/gadget/udc/renesas_usb3.c +++ b/drivers/usb/gadget/udc/renesas_usb3.c @@ -2632,6 +2632,7 @@ static int renesas_usb3_probe(struct platform_device *pdev) if (ret < 0) goto err_alloc_prd; + pm_runtime_enable(&pdev->dev); ret = usb_add_gadget_udc(&pdev->dev, &usb3->gadget); if (ret < 0) goto err_add_udc; @@ -2653,7 +2654,6 @@ static int renesas_usb3_probe(struct platform_device *pdev) renesas_usb3_debugfs_init(usb3, &pdev->dev); dev_info(&pdev->dev, "probed%s\n", usb3->phy ? " with phy" : ""); - pm_runtime_enable(usb3_to_dev(usb3)); return 0;
This patch fixes an issue that this driver causes panic if a gadget driver is already loaded because usb_add_gadget_udc() might call renesas_usb3_start() via .udc_start, and then pm_runtime_get_sync() in renesas_usb3_start() doesn't work correctly. Note that the usb3_to_dev() macro should not be called at this timing because the macro uses the gadget structure. Fixes: cf06df3fae28 ("usb: gadget: udc: renesas_usb3: move pm_runtime_{en,dis}able()") Cc: <stable@vger.kernel.org> # v4.15+ Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- drivers/usb/gadget/udc/renesas_usb3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)