Message ID | 1523338734-20474-5-git-send-email-yoshihiro.shimoda.uh@renesas.com (mailing list archive) |
---|---|
State | Superseded |
Delegated to: | Geert Uytterhoeven |
Headers | show
Return-Path: <linux-renesas-soc-owner@kernel.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 21A206028A for <patchwork-linux-renesas-soc@patchwork.kernel.org>; Tue, 10 Apr 2018 05:39:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1366B28C74 for <patchwork-linux-renesas-soc@patchwork.kernel.org>; Tue, 10 Apr 2018 05:39:34 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 07C1628C79; Tue, 10 Apr 2018 05:39:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8CCDD28C74 for <patchwork-linux-renesas-soc@patchwork.kernel.org>; Tue, 10 Apr 2018 05:39:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752127AbeDJFjb (ORCPT <rfc822;patchwork-linux-renesas-soc@patchwork.kernel.org>); Tue, 10 Apr 2018 01:39:31 -0400 Received: from relmlor2.renesas.com ([210.160.252.172]:17857 "EHLO relmlie1.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751851AbeDJFjM (ORCPT <rfc822;linux-renesas-soc@vger.kernel.org>); Tue, 10 Apr 2018 01:39:12 -0400 Received: from unknown (HELO relmlir1.idc.renesas.com) ([10.200.68.151]) by relmlie1.idc.renesas.com with ESMTP; 10 Apr 2018 14:39:10 +0900 Received: from relmlii2.idc.renesas.com (relmlii2.idc.renesas.com [10.200.68.66]) by relmlir1.idc.renesas.com (Postfix) with ESMTP id 9194776F19; Tue, 10 Apr 2018 14:39:10 +0900 (JST) X-IronPort-AV: E=Sophos;i="5.48,430,1517842800"; d="scan'208";a="277733088" Received: from mail-ty1jpn01lp0181.outbound.protection.outlook.com (HELO JPN01-TY1-obe.outbound.protection.outlook.com) ([23.103.139.181]) by relmlii2.idc.renesas.com with ESMTP/TLS/AES256-SHA256; 10 Apr 2018 14:39:10 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesasgroup.onmicrosoft.com; s=selector1-renesas-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=+EHupDPYYFjOymWPZ/GyrTLjfPGdWBpn3jQcVDhedSs=; b=KyanZSyE+nbNs17JMdnirzpL89uKikBKZ6hUDJqyyVMT4mhWYfzxLl/Iv9Xnsi01SIXfBScC+iM3wxZhM/Skp6fUdk8iGLHY4A5zw99JGHlPQkBWQtdvHQRsQuR+KVij7tI8ChK+6s+6UG9sTRkg+bNwzkCA6vUJ7kHcnnd+SeA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=<>; Received: from localhost.localdomain (211.11.155.138) by TY1PR06MB0989.apcprd06.prod.outlook.com (2a01:111:e400:59f2::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.653.12; Tue, 10 Apr 2018 05:39:08 +0000 From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> To: balbi@kernel.org Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-renesas-soc@vger.kernel.org, stable@vger.kernel.org, Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Subject: [PATCH v2 4/6] usb: gadget: udc: renesas_usb3: should call devm_phy_get() before add udc Date: Tue, 10 Apr 2018 14:38:52 +0900 Message-Id: <1523338734-20474-5-git-send-email-yoshihiro.shimoda.uh@renesas.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1523338734-20474-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> References: <1523338734-20474-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [211.11.155.138] X-ClientProxiedBy: TYXPR01CA0057.jpnprd01.prod.outlook.com (2603:1096:403:a::27) To TY1PR06MB0989.apcprd06.prod.outlook.com (2a01:111:e400:59f2::23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(8559017)(48565401081)(2017052603328)(7153060)(7193020); SRVR:TY1PR06MB0989; X-Microsoft-Exchange-Diagnostics: 1; TY1PR06MB0989; 3:+YTutcapAGycm47kNxWd5dAJaMe8ySEGTWmPdsRPjCr46UL1zvE7Hsr9IaOb3aR7RJ/wOwo+NtMKBUy7LfhL/2PTRffNT8nnQkgPiezk6tbkWBB4I0QbbhXKCNoyhdWwB1xa6HtGDYymf1WjSTVtAFTxz9pi0ASraH2q+odPSCs5RNIgkw+he42iUYV+6ZhliP/7VKtqZBCghr5DA3iMa5NVZhBFgfWTxLOVEPDtK0hpLSz/DQlhojABrlhqTlyq; 25:7kQCSP7LzcoaN+/5nPPRrWOlthRRcSKnqNelucv0ToGNE5Wc4bNz320P+aj8ajezYT/8Zi2TASI982QbeQxQ5GCpdVbR2myPgEqiJJvC0ncxtGC2njJ0NbhhEX7EuScyD4b7X94HM20CgJ8nrM/ZEVP9miF9du8imavRUEWtsrDk9tzg0ZTqAQLf5vYZHQgFuD7OwDK6uJmIThusFw/DMUoOGWoucMGsOxXmZj6/CZlLyoQY18EiFwmdjKhRSYXgcKcysPRGd0SGxl/OSabHn8pqTjhBm/9u46MagljIwKZ00td2PIywZ9JV12Wp9280WNGJ0OZp7gt0Uq4O4HYwnw==; 31:+GJL6V69Elxt3hA7085A5YxOd1Ow7/CDt1yoXBE1JWtxmiA6TqvS8eFE/BK4cNWUURpj4QYiiIn97cEyeaNPRB5fkxGTqjhEnmwHfO9em/9P1KFkZW+KhCbw/+WgtbveJrNB7oiKeydGF6R+FLfLh6VGuIfYNBadXEbJGvQKnE1esrpmzQL0FDEslIl2ccr0k+5rFDRtP8zsM3BPquNg2Ige2TucVI8Nk6ozmKkpAG4= X-MS-TrafficTypeDiagnostic: TY1PR06MB0989: X-Microsoft-Exchange-Diagnostics: 1; TY1PR06MB0989; 20:Jo6oYDSM4O2xY1I8P9OQH6kh4Cz8yBZwx8FX9NFN5cnVcemzhRBUHavuCnRfXWr7BB+nAweQWc25LWDRA99aBhSmxEqWzENbWeSIGvAFwPXqit5K0qn0dYZZnC0UDypelYbOyv+7tVJTv+FjeFAtviFpnhY6IZ9OiuxRlvx/RVdqANzjWk+2SYherhizUTi8jlj72Qj0XziuaNJ/GlNyJv8bSTK/PkApMS3MUi9/ecQOlWvNnIGsF0wldmJuEqNPd3X5E6BFsG15Scdlijscv0cdlHlyan/UJ/3zta764I7MeFmk6zO0xoR1DwwIiIyGskbk1nPeLsi/vbHe9wWQt0/DE2EuBT681itlngE+0oVZff+LI7lk/3I6a8wA+wqKbTqi8BPzOHn3flMCkdhvS7CXx0Jz33uCVYDcQnNByRuuI+DKpJmz5aHNStrj6GMzArU9uRG5FlLS/peA07p6Nt4VK07B+c4TYwQlKSHA8QPo8Cmv6jTbOFkXB1tpilcu; 4:h0ArEQmG1LZ3a8o7z4hxLsncMlG3Cmj13kTtEuIronZ0BYH5t6KU16OO02D2BNkfvkI/LnK9QR6LVUsP1FQZpL14quIY8uV9QTktrY1SeY2qOW0sVBvSP50ABXuveo1/c68+xcncen3r9kziON+U7bvovgoDG0aHg3pCX5BSSi+AsyFzY87tdMVPfj5SM23Cs9dIr9L5YgYrJNz9tcbDPw18IBgscX0/L23gZhTRn67TaAtvTkEOE1NgwJsSCHDLnCkHKvrRMyp0ZsPhenbwKAdCKJaTKQulC9LrAnhJBHS9D0EE1qtx9V1QEzn3lxwy X-Microsoft-Antispam-PRVS: <TY1PR06MB098955D0464D546F62D125F5B8BE0@TY1PR06MB0989.apcprd06.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(9452136761055); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(3231221)(944501327)(52105095)(93006095)(6055026)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061750153)(20161123564045)(20161123560045)(20161123558120)(20161123562045)(6072148)(201708071742011); SRVR:TY1PR06MB0989; BCL:0; PCL:0; RULEID:; SRVR:TY1PR06MB0989; X-Forefront-PRVS: 0638FD5066 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(6069001)(39860400002)(376002)(39380400002)(366004)(396003)(346002)(189003)(199004)(4326008)(498600001)(8936002)(7736002)(97736004)(2351001)(36756003)(81156014)(81166006)(305945005)(50226002)(2361001)(2906002)(78352004)(8676002)(25786009)(5660300001)(2616005)(486006)(956004)(476003)(6512007)(11346002)(446003)(53936002)(6486002)(6116002)(3846002)(316002)(16586007)(6666003)(105586002)(68736007)(106356001)(6916009)(76176011)(51416003)(52116002)(47776003)(16526019)(6506007)(386003)(26005)(107886003)(50466002)(48376002)(42882007)(66066001)(3720700003); DIR:OUT; SFP:1102; SCL:1; SRVR:TY1PR06MB0989; H:localhost.localdomain; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:0; A:0; Received-SPF: None (protection.outlook.com: localhost.localdomain does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; TY1PR06MB0989; 23:uvBbdODTUnLFx5OQAKdahzrfCAz2nG8RM/BK25eEU?= =?us-ascii?Q?SWS0IceBE3H10//m54v1siDzKkj8xuL45fulVz40pHxZsRp4Zi/lTbG/0EX8?= =?us-ascii?Q?atFGGIglAOgiOBat+xhSAqgP7uWYraN4UUQnczkPL18gKgrswYY27Q51FN82?= =?us-ascii?Q?IZiAEc6YUzNx3UORBPjmL7tpSL/nK7IjHlmPZN2B9Op0TaN6mfIxZ9BOdDrg?= =?us-ascii?Q?oDXcwNBDR4iSPDCFiRlGPOFWaLxjuvq2Z8wDyLaGSVAsLrhrETNkTTPmyDgf?= =?us-ascii?Q?iZyG5eCR+PTWoh/QhtVAiWKRO9CRdbxS0YyCfaVGwDrNlII4ZKeKQZprJtzy?= =?us-ascii?Q?0Xtw38vDPy4gnoXJv+E4L8Wl2ekrt3uo9LKSds1zZb2BQMkp/1qIyzFapbpg?= =?us-ascii?Q?l3BtDjfFpOKF2D1V/EwKcCo9WTEp0b9/JFM+4NmSlu+Mb+yIvOK1VbyyLxbT?= =?us-ascii?Q?XuL+K6/tNauhT3vuBXtmaoBI4M1xXfTWOc5FrniUXTyj6ZzY9PJ3vMHUZTHm?= =?us-ascii?Q?8Hd0iW6L23X13roUB6tcZ6EiIps6lQKN+YXng9Z7/yLxAecNGcZ4Cb1OE1TQ?= =?us-ascii?Q?fEH4DTgwNhGlj/Xx+ERwiu7vbQ5FoXPAhwKcPhosUx2huqO2QhokEk5oGJFN?= =?us-ascii?Q?n/YCf0Nf/u1qkbI677RrXbSNafQC7XJhdu0o16VlQpsRcwZRfrnK/Zp0zAMP?= =?us-ascii?Q?jm+o2OPXosGMuK0n5Nv6gsXE3Y18G+amaafNQ0KL+f3iBYNg/yEqR2G4jHAf?= =?us-ascii?Q?RswTd6Km7QIYdD8e+gFgSGfo7eHgseBTT2T/KC5bieX+Wlta8ft8N4evxhQp?= =?us-ascii?Q?L7ppnpCE2LOOUg2GhJG9ajCDbPh2svozWfn4NiwTqIJxTru4KMZGEIGIBaEt?= =?us-ascii?Q?0hxXUxHrumTNw+I3QyqKW4NLB8eto/bfllsg56CYjo1ET7ndmrBN1rK6kLnn?= =?us-ascii?Q?9ECqt5knKsAz1c4qtH9SpZ769+H0b1u1w2gDXxC8byUtzDRdTYLJXOyPlwS4?= =?us-ascii?Q?l1kMGqupuDl94i2SkXg7f5VGo4PdCQfwYgF3QmyiNOhASVKITJpKI2XFiHoD?= =?us-ascii?Q?zRCTAKKACEATBX0APCwhyqR5A2JusLoJ5YlQOhCB0dynrmEVc8z84UFXJCAS?= =?us-ascii?Q?TQbyx2taJdQJWidT16vkDYgECYKgpL9dc6CS4J6ZJ4PoqwP2TYLo2Rb6dF9k?= =?us-ascii?Q?IQyrkTdUBEYpvlF7mDdpnwjDfxaAsuoYbgLLH4E+PVQjIPl/iq9FV14KHIpw?= =?us-ascii?Q?mQEmYz0XlpF3EKKdSLlhYH4OFeQ8GFdICbJJRDtfZmCNjCY7XhgF/QzzDMkD?= =?us-ascii?B?QT09?= X-Microsoft-Antispam-Message-Info: IeAH+vNiOSxHluqTDGJYLLmhvwSKievlhqUJQA49NQHWDQFVEm1s1DQnK/erdf9vixv6hjuA6tRIJuyVuvtC/9uZLNnE5Eq+dYK3iguPEeCEEvHa3oQeiOsX6r224/ShF6ePW9KN6gaZjs5UdMw/dzQtDMyTafgXuw+hWmR6STsOtJJ9hjmGfm8jfavGRvhS X-Microsoft-Exchange-Diagnostics: 1; TY1PR06MB0989; 6:uNXv9olx4MEtRqVY6XOW64jga7ULTFOInZm8ai9aKGt/4Go3YFk6nIP2nzDbv1QtmDrbJ6LhYrpZEkTeoT2gIDeQsILRNroV9NzVGvrJupWmrLFQyQUfx171So0rhYoT+hQD/CT7WvCwLVfY/upQOCLj4IfApGdSr7EgzWGhl66j1gF2ouyZF4wq9fVOGFgEJwlE2HEa2Z9UkoqLESBQeOPnQgir9FdgmRgDbHISktkodWoKIxrva8uNl3ZZDmjhNn2GHNJp9U4Gj2aHYG8PDn1Y1wH2bXTLuMIihrnIR0s5FPi/0OEGg18Ve9MI19R56/+m9uvnDi6VtblU79Pfopw/ShAQ1n6L7Ii0U/z7fkTtmZvNNgo9aYTDYRJWf0TQP6bydhAOgw6P0o6J0rbutiR1ahCbdaVC/zIapHl6tZEkFfc489231v2x6pteArePsr5xH/F312fpcZIisMpByA==; 5:UwK7++IWak/0LhytD8hYc7GEJ4pqN9CoAM1vDHiWjRte5WN8Kgxevy/w3zYvYx/swdCEeEK/dQ6DwrbCMTKE47qoTaj99OnoRZ8hITuLEVBAwUZ26lnUutFSM8j/k3h7oPNhvav3dKjtL2YZ83vRP9sSh4Aa3OoW4EtsTn49570=; 24:tkcU/fsmYzH+4gm0qUgSNrcE7YZjw5P4iKK0fxs1hkk3EWV88uSYa9pcB6XeuI8PUBvjk5OF/Tp564S8Iiguuc9q17lbVoMSwYZtTr6z5mA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; TY1PR06MB0989; 7:FhfSkXQ5sxbjvlOva6yY6A7DvUgIAhHnJzAQP11dZZjuQWLc9VSx1iRZ/Xgl1O/tLbmHzvSpeQ7rsryhoTLyDE6dkT8kl5xQfwgPs/9EtnCCXH5Jtm7sQPxbOy9ZhMEZTp0UiBnKws0s+mNP2EL2U+n8bF6LaU5ExbskIp21lKetJCkot5VBj+jT4i9zO+v+qdG7CdkbOlEwa3oTuOftR5+Kc4dX073jHrkpzXoPHaLoE0g94zpl2Y9AY7aMMLtx; 20:vKEmGN1nAeniV6T/YwJQyC8oKwlD7xmauCyiwKEPCJ4iTYKds3ymtcV2hwxlgZfA24JqbyYauOKkHXDDni/S6padses17+mwrJA8CbhMmgY8weqANUr7yjQdbekyqS99r0P5bG+vJbGjSWqdZWGfIZIE6NT/GaFeSXSsVKANbi8= X-MS-Office365-Filtering-Correlation-Id: f255e11a-95d6-4a29-fa26-08d59ea5616e X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2018 05:39:08.3623 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f255e11a-95d6-4a29-fa26-08d59ea5616e X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY1PR06MB0989 Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: <linux-renesas-soc.vger.kernel.org> X-Mailing-List: linux-renesas-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP |
diff --git a/drivers/usb/gadget/udc/renesas_usb3.c b/drivers/usb/gadget/udc/renesas_usb3.c index 738b734..233bc04 100644 --- a/drivers/usb/gadget/udc/renesas_usb3.c +++ b/drivers/usb/gadget/udc/renesas_usb3.c @@ -2632,6 +2632,14 @@ static int renesas_usb3_probe(struct platform_device *pdev) if (ret < 0) goto err_alloc_prd; + /* + * This is optional. So, if this driver cannot get a phy, + * this driver will not handle a phy anymore. + */ + usb3->phy = devm_phy_get(&pdev->dev, "usb"); + if (IS_ERR(usb3->phy)) + usb3->phy = NULL; + pm_runtime_enable(&pdev->dev); ret = usb_add_gadget_udc(&pdev->dev, &usb3->gadget); if (ret < 0) @@ -2641,14 +2649,6 @@ static int renesas_usb3_probe(struct platform_device *pdev) if (ret < 0) goto err_dev_create; - /* - * This is an optional. So, if this driver cannot get a phy, - * this driver will not handle a phy anymore. - */ - usb3->phy = devm_phy_get(&pdev->dev, "usb"); - if (IS_ERR(usb3->phy)) - usb3->phy = NULL; - usb3->workaround_for_vbus = priv->workaround_for_vbus; renesas_usb3_debugfs_init(usb3, &pdev->dev);