From patchwork Tue Apr 10 05:38:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yoshihiro Shimoda X-Patchwork-Id: 10332339 X-Patchwork-Delegate: geert@linux-m68k.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8B9686028A for ; Tue, 10 Apr 2018 05:39:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7D30028C74 for ; Tue, 10 Apr 2018 05:39:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6F5DB28C79; Tue, 10 Apr 2018 05:39:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D676E28C74 for ; Tue, 10 Apr 2018 05:39:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751875AbeDJFj1 (ORCPT ); Tue, 10 Apr 2018 01:39:27 -0400 Received: from relmlor2.renesas.com ([210.160.252.172]:37227 "EHLO relmlie1.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751892AbeDJFjM (ORCPT ); Tue, 10 Apr 2018 01:39:12 -0400 Received: from unknown (HELO relmlir3.idc.renesas.com) ([10.200.68.153]) by relmlie1.idc.renesas.com with ESMTP; 10 Apr 2018 14:39:10 +0900 Received: from relmlii1.idc.renesas.com (relmlii1.idc.renesas.com [10.200.68.65]) by relmlir3.idc.renesas.com (Postfix) with ESMTP id EA36963171; Tue, 10 Apr 2018 14:39:10 +0900 (JST) X-IronPort-AV: E=Sophos;i="5.48,430,1517842800"; d="scan'208";a="276328174" Received: from mail-ty1jpn01lp0177.outbound.protection.outlook.com (HELO JPN01-TY1-obe.outbound.protection.outlook.com) ([23.103.139.177]) by relmlii1.idc.renesas.com with ESMTP/TLS/AES256-SHA256; 10 Apr 2018 14:39:10 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesasgroup.onmicrosoft.com; s=selector1-renesas-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=V+CLtQkmvQohU8vqHlEo5TCv3mMK+8VUoDwNQL6DYv0=; b=Ebe2U2Q2zUrG9Qp5WWlYGjlJ6yWDVpWV6IfMf+c6gwG82/oxNAiQo3HXN8igm7mCFBUYVB2iF5xdQTr+QU8r9g/4Lch2M2Kektf1Q52mq2JKcinfmmfZwKJbfVZ0nkG3rADypahl1U00mzb233lidFsTPipugsY1GOWMxA0kn1Y= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=<>; Received: from localhost.localdomain (211.11.155.138) by TY1PR06MB0989.apcprd06.prod.outlook.com (2a01:111:e400:59f2::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.653.12; Tue, 10 Apr 2018 05:39:08 +0000 From: Yoshihiro Shimoda To: balbi@kernel.org Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-renesas-soc@vger.kernel.org, stable@vger.kernel.org, Yoshihiro Shimoda Subject: [PATCH v2 5/6] usb: gadget: udc: renesas_usb3: should fail if devm_phy_get() returns error Date: Tue, 10 Apr 2018 14:38:53 +0900 Message-Id: <1523338734-20474-6-git-send-email-yoshihiro.shimoda.uh@renesas.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1523338734-20474-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> References: <1523338734-20474-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> MIME-Version: 1.0 X-Originating-IP: [211.11.155.138] X-ClientProxiedBy: TYXPR01CA0057.jpnprd01.prod.outlook.com (2603:1096:403:a::27) To TY1PR06MB0989.apcprd06.prod.outlook.com (2a01:111:e400:59f2::23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(8559017)(48565401081)(2017052603328)(7153060)(7193020); SRVR:TY1PR06MB0989; X-Microsoft-Exchange-Diagnostics: 1; TY1PR06MB0989; 3:bxJmwv5niBzCreVPdUR/QpZm3TN0uM1jXxLQZcSPLnQzvfgZVhqIuc5BAP6RCn1N830PL3S+NB4GU6wXBeETh33FSB1r4ypiCU1uTyojENBAmOQ0a80uWi4RbSEiuMj/WF8BlknrTNc5E3Q3DAguvd/x7KLKt20HvwW3bbY7Tdn2lj2Jm6nYhOXlQ+zWww2nylWO5AGcBX8y3dD2qckwgWH6MO2XjSAES8i329HPZfhi1eNXcNtkrWpTKzmeVNPM; 25:PxSKILGTudh1cOuX8zxgI7sWqnjnPoofW/Pf09b31cM1V1jNa64l9FSyxdrEJNuvZuLNJJpBuEZY5mrAZ2Wdv+rsV1PSwyNZA6s+6KNi3Zk4N5ARK22F8k4mdAN22CgH0zzO+Kq7SrMc9uNVSMyz084lROp+2Dl+JYluW/NN8bAabU4tVJfFnGSX7fqf7ALxxcoWakti4ZAFVsvzVVMKPYwsbhAU8CUtUuq+s73hypaxn8kGrDeq36c9Ob9xmu9eB6/PapmftOLfrzR7xO1vBuS9Q5c27AvpbnNjLaQgSLeGQXs/0yyOfVuy1ezcKdgvYyuyep45fytQyiphUQesUw==; 31:s4qQWGdYPTtGCvGbRIIDRMcVGFPxCQku0Jy34BJWPxHG8iC40QGjKYZdltzfduLqEInYc4yutOnHkwsuUjxVP0u50Jb/D+Na1eKTKT3zUcPlP5eJYa/uvNqByHgwhmjaJJOnOY55iw4n5nAbVF62Jzrf4SU8Oz/iIsJCO1weBEgNv8qV1qnK4May5t72govUnL5zOdVgrNk6RSM7yJDDZApqIPb1kvNAeMSjS9nYgh8= X-MS-TrafficTypeDiagnostic: TY1PR06MB0989: X-Microsoft-Exchange-Diagnostics: 1; TY1PR06MB0989; 20:M1vPww7JdczDySDAFLgaqB7RA5cjIaJs7LixF6KfNPiPwER295GOzBnEU2c9Fm3eyUkZmGY9Q+xJfIZ5icdHrRycH47j73vtzRK61h3v8k6sSPzKeVZBvqrfhiYEyX/jcgm6hbay67XhaoRBhNq4PgAco7An25lUdWvmOu+4Sg6FPq5SSSWxz8gFB41Ojf8o/VfDW1gWXn/jFXS2MqNztbXAO2T3VaOwaJ74E/SmKrc8f5Rxc3698+n3oWSnIvzLOxXkKkgp0hD0MeQSwa+5VFKJ33JnUz1XvvqB6STG/qHCD1r9XsGfZ4RfQT4wospJ4HXnCHdhtL++3JJv4Nb6/GJYab8He9v0aIMhh/iJPiRYyOjS6yEhMMqh9Yv9otB4JYosjon8R1lZ48ADj4bYhZSReQPnJIeHU/pWV39Xv9CJZM20GkZgKwhIH7/BoITTIbHZjSD3Ovx94gdmU5Jnh5rfhHf0ua1EU96abl7044RMQmQe1HIs/p/MN9OKWRWs; 4:69sIXOEa2BymoRTAVgk7+VeOEvzrPc34LeS6L5O9/zHt9GglVbhRDsB4AnBI63Lx4dH19IJK7b2fSmKqKXxjt0D+r5loMap2lA4fvREE0+rkdF3mrd6HuQU2prPiuNdKInMU345HjWuI4AbfvQGJM+qPtrteq+PV8etW9evKDlpKvtlqR5NThLthfS5MposMg1w2c4P4+hnllrVhCLkiXhmQacavcycRT0SHENBSZyvrDbASCYbUpkO4f8LOIIQfwM58Co/K1tRMQ77CYc4EBV6sNI6hjD8abrB7dNVovIINKttz3z8N/dDj4hwNK7/O X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(3231221)(944501327)(52105095)(93006095)(6055026)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061750153)(20161123564045)(20161123560045)(20161123558120)(20161123562045)(6072148)(201708071742011); SRVR:TY1PR06MB0989; BCL:0; PCL:0; RULEID:; SRVR:TY1PR06MB0989; X-Forefront-PRVS: 0638FD5066 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(6069001)(39860400002)(376002)(39380400002)(366004)(396003)(346002)(189003)(199004)(4326008)(498600001)(8936002)(7736002)(97736004)(2351001)(36756003)(81156014)(81166006)(305945005)(50226002)(2361001)(2906002)(78352004)(8676002)(25786009)(5660300001)(2616005)(486006)(956004)(476003)(6512007)(11346002)(446003)(53936002)(6486002)(6116002)(3846002)(316002)(16586007)(6666003)(105586002)(68736007)(106356001)(6916009)(59450400001)(76176011)(51416003)(52116002)(47776003)(16526019)(6506007)(386003)(26005)(107886003)(50466002)(48376002)(42882007)(66066001)(3720700003); DIR:OUT; SFP:1102; SCL:1; SRVR:TY1PR06MB0989; H:localhost.localdomain; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:0; A:0; Received-SPF: None (protection.outlook.com: localhost.localdomain does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; TY1PR06MB0989; 23:VdwhA3oqc788KSalbvHLubZbVxUlwWyVBDOgc7gPX?= =?us-ascii?Q?5q4S3NjrxxZ14d+DYm35zz/4AGIOruR5V4imbYHfbtYzp00p7P1rxTitBf56?= =?us-ascii?Q?e0gnEPhHGIOSUUs0w1ET0MqAdaBpjqhjMb7k/xE3eYIST6JaTsAcSo2gdvR4?= =?us-ascii?Q?cfzoPdAZQIip6jCQbhdV/C/H0MocksKwuVxGzfFFPeX3b/lTnWn6AZ46nN5N?= =?us-ascii?Q?7U6Bf8+7lfJN1wJJ0/TPa/IdUd4inpnpXvMeNFyYofLvtBOIDZoit8W7tcoY?= =?us-ascii?Q?4B4gmP6/aMu8UN0wq5mr7X5l6JlM45GGL25zSr9MIRxYBiNnmEYhB1k7aC0S?= =?us-ascii?Q?XOY3zaeXJfpMgHxP14emhG56+JgVGK5257Z7Tm7SKlDLg6zLhGfRAwfucxas?= =?us-ascii?Q?yxy6xXXLBGB6rYg657UuGFdeFH2Z4CcU0xEUIBafaUiRa3BcPsY0xfZ5gqXQ?= =?us-ascii?Q?zKibC2RX1E4xK1x61yRb8auulNGexnoZ6VXfbsYpo7ql2GagpE+8j3Wm4Q6r?= =?us-ascii?Q?wlao531dQTUhzeG/nCl7cWUTolq3ujmZKeifGal8K8+bskCYzWozIV04CaxW?= =?us-ascii?Q?3FVRyoy/7ES6O3yf2bqKmxi6Ri9qUqDz9PyFkuFYDdBmQ+QoNd9aF0K2bLg/?= =?us-ascii?Q?JzMFpZRLgVY6C/JLPLgZvkm+N0fWmLRPtioINir1S36xpQkhK9RY4a2aKeU6?= =?us-ascii?Q?OuEJwf8iSct1QwAuQ/0sHUv/9X9VpEuYJNhz265tg7IHauaAZ2UAEMedPdov?= =?us-ascii?Q?2iZ/ORxiG4Fz4cYTWcobELenx4bS0XyzGGirdBy5XADk2VK2ozLYzRX1nq3J?= =?us-ascii?Q?pHqZT1TCOBPlG1dap6WjUjcNiJgt99n2dOULb6NVvHdIvuavn2uCDDf140Nk?= =?us-ascii?Q?Mn/45qzeno+tjNmdEG2PiLgIo59Ykqq8DJqLQabn/yROAEfG4D3TgiOIaRlS?= =?us-ascii?Q?l2ux0Dp+xCh/+lXvZm8aSJiHFXeCS187buNJwB32R7rBw8Cz54y3e0iVhFzC?= =?us-ascii?Q?FCgwYDdlPskJ7KyHWL7GwGNCHUUyGhFv9OZk8VrGhC9vnF5igm+DQQRf6Xqo?= =?us-ascii?Q?v1jAlJ3qeQNzi0vK+B7WU+1wNXW16nZ7PEPBAJGvG+2fyuPDK68gav+m26HK?= =?us-ascii?Q?eGokn6Fp6etNFMYBjW799swXbCaaaZKGTLhlVCvx7qKV6k8KZSqvWgE+8dCN?= =?us-ascii?Q?+X/OaWwXs/yO5082oo9Omdg4Qj2QWaBbZZOBjFboW5BtlM/nFqIb/J0ejI2V?= =?us-ascii?Q?e23VC1QPp6nX1HLc3beKBbv/3i9Z0XhuAPnN8hI0w9Er/1cPt7W6pKxAUIFl?= =?us-ascii?Q?EJ/bOqi3X2qsotDqOihzWM=3D?= X-Microsoft-Antispam-Message-Info: ttudcnl2bxQx+m+DqYinExTGx5sZzA63j2qEpVbeqfJBRO9+Wt2KIlWYVOF8p7xsNUJdh0fejdXvpOY0+xp/8NjGeAbjyYCVZKgJfOdXNshDfEyVT1iQROXCDqs261gMpu8ouEoctsh6a20ouxB+rX152L3iDVJMoa9rd5qqEZ+jFmkqjH4wb8P2F3iXKR2H X-Microsoft-Exchange-Diagnostics: 1; TY1PR06MB0989; 6:AmhEeope2a/Vv21YokZYQKkPl2hyc2oN3k0h9VHowb5N7KCKheNkc40ZvbU+yRbq88kqLxpwZoXx81dWrzW8IHvBn48/2D2TAqC2DvUP492ZMp9afV0+HbEhFoa0SkGEdeBVhQo6syHBulT2TYEiqfCgApy9u7WEHXWTmWIRF+Cg1aTcOcKwsBjo3J/Iki2/FJPmWiJDXvRkvW0f/6UQZURoZcCS3EKWnuwA6FPHywqTZLezLiXJ6l3JiT/KEV8hLL4Qv+Ai1YQg/JjZhy2D3IiArwjE+ellZ0Nj5DM6oyxHl5hXEZnYd7WqsxtIrwIDts2tLs7RwiUY4t3bZrVKIyrXQR2DaVz7cVylvJcHp1Mmm0mRuujZ5g5p9MPHI0NJH6giYxdeeW4nLZAspUCJwiDCmD5wfb/hMpART5GLpHVf3hVyBi2ek+i8/tm7H1gm8DBZ/17dz5yG21CdW7MJ8w==; 5:d9sdYvIS0OiKJhoYJNqxHyoJRACfZPUYJCUHzOHnskt3LmpQMxbBTyzFyaukLs8xjePP78oC4bClHkSJH0biqIGf6z7uhuKrW2bSG/UT8CT0XkTE86CnyhXIiSfuw+Mvi1U/+5ZS1A6YfLxoaaiTWv4DjPdrhKdEjGyFsUTxEhI=; 24:daiziIVSoYZuu1HEEIeiYev/5DV0Y7S9UuDEu1zj5o+yTnX//4jv47pGZqiKUk/+YIratwmnPXlQVKHZuw+ykhSyBPwO/28Ylb8huE2wm44= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; TY1PR06MB0989; 7:rhw4B2h6Zl7+swugcM3B3P/9IlPvXmjYM3NewgEcB+aZfB/hS6yuZVd/4KjrJFQn8m4ASKwDlY5plx5+gF7cnX6qrzRubR1mgaFSKGDEeyg72J7P7t8VupRNEKqBTj0FmWsOu5aSWPAFzJ8Z4AuxF5twQZLeWJPbkGCJ/xG5tV0CPYchdscllziaaU6KPzUtoB/9TAUr0GLP+tTZeV+HfqknvHH0Yska/0/RIiZhlhFAZ2A7/en2kOqBlG9g8ZT6; 20:hAH4ukm7MqVlCrOuH+nRnX6uJZSDor8e0LdxVKW2HtCHP1KUuYGe7KTBy3Ga+fEDUtFMatLNXUDwl5vbA2m4e2MBwAxE0cfpoYfPmE06xY7M9rEX4jxdYNMxIpz9iyvF7zzTcA2flJbWMf3i8nJC+YCaWr+vu35V2UNxCqxSIQI= X-MS-Office365-Filtering-Correlation-Id: 112144c1-6181-42eb-59af-08d59ea561ce X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2018 05:39:08.9717 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 112144c1-6181-42eb-59af-08d59ea561ce X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY1PR06MB0989 Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch fixes an issue that this driver ignores errors other than the non-existence of the device, f.e. a memory allocation failure in devm_phy_get(). So, this patch replaces devm_phy_get() with devm_phy_optional_get(). Reported-by: Simon Horman Fixes: 279d4bc64060 ("usb: gadget: udc: renesas_usb3: add support for generic phy") Cc: # v4.15+ Signed-off-by: Yoshihiro Shimoda Reviewed-by: Simon Horman Reviewed-by: Simon Horman --- Remarks: - A new file in v2 drivers/usb/gadget/udc/renesas_usb3.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/usb/gadget/udc/renesas_usb3.c b/drivers/usb/gadget/udc/renesas_usb3.c index 233bc04..0e70163 100644 --- a/drivers/usb/gadget/udc/renesas_usb3.c +++ b/drivers/usb/gadget/udc/renesas_usb3.c @@ -2636,9 +2636,11 @@ static int renesas_usb3_probe(struct platform_device *pdev) * This is optional. So, if this driver cannot get a phy, * this driver will not handle a phy anymore. */ - usb3->phy = devm_phy_get(&pdev->dev, "usb"); - if (IS_ERR(usb3->phy)) - usb3->phy = NULL; + usb3->phy = devm_phy_optional_get(&pdev->dev, "usb"); + if (IS_ERR(usb3->phy)) { + ret = PTR_ERR(usb3->phy); + goto err_add_udc; + } pm_runtime_enable(&pdev->dev); ret = usb_add_gadget_udc(&pdev->dev, &usb3->gadget);