| Message ID | 1523357646-3946-4-git-send-email-jacopo+renesas@jmondi.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Simon Horman |
| Headers | show |
On 04/10/2018 01:54 PM, Jacopo Mondi wrote: > From: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > Add the LVDS device to r8a77970.dtsi in a disabled state. Also connect > the it to the LVDS output of the DU. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > --- > v1 -> v2: > - Rebased on the modified endpoint name and changed patch subject to > comply with other patches in the series from Sergei. Stop, what was wrong with my R8A77970 LVDS patch, reposted on the popular demand? :-) MBR, Sergei
Hi Sergei, On Tue, Apr 10, 2018 at 03:02:39PM +0300, Sergei Shtylyov wrote: > On 04/10/2018 01:54 PM, Jacopo Mondi wrote: > > > From: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > > > Add the LVDS device to r8a77970.dtsi in a disabled state. Also connect > > the it to the LVDS output of the DU. > > > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > > --- > > v1 -> v2: > > - Rebased on the modified endpoint name and changed patch subject to > > comply with other patches in the series from Sergei. > > Stop, what was wrong with my R8A77970 LVDS patch, reposted on the popular > demand? :-) > Nothing wrong, I found out about your right now. I see a very small difference as lvds@feb90000 vs lvds-encoder@feb90000 You can add your signed-off-by ofc if you think that's the case. Thanks j > MBR, Sergei
On 04/10/2018 03:13 PM, jacopo mondi wrote: >>> From: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> >>> >>> Add the LVDS device to r8a77970.dtsi in a disabled state. Also connect >>> the it to the LVDS output of the DU. >>> >>> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> >>> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> >>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >>> >>> --- >>> v1 -> v2: >>> - Rebased on the modified endpoint name and changed patch subject to >>> comply with other patches in the series from Sergei. >> >> Stop, what was wrong with my R8A77970 LVDS patch, reposted on the popular >> demand? :-) >> > > Nothing wrong, I found out about your right now. > I see a very small difference as > lvds@feb90000 vs lvds-encoder@feb90000 Yes, I thought the latter was closer to a "generic" name that DT spec requires... > You can add your signed-off-by ofc if you think that's the case. Didn't understand what you mean here... > Thanks > j MBR, Sergei
Hi Sergei, Niklas On Tue, Apr 10, 2018 at 08:12:36PM +0300, Sergei Shtylyov wrote: > On 04/10/2018 03:13 PM, jacopo mondi wrote: > > >>> From: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > >>> > >>> Add the LVDS device to r8a77970.dtsi in a disabled state. Also connect > >>> the it to the LVDS output of the DU. > >>> > >>> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > >>> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > >>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > >>> > >>> --- > >>> v1 -> v2: > >>> - Rebased on the modified endpoint name and changed patch subject to > >>> comply with other patches in the series from Sergei. > >> > >> Stop, what was wrong with my R8A77970 LVDS patch, reposted on the popular > >> demand? :-) > >> > > > > Nothing wrong, I found out about your right now. > > I see a very small difference as > > lvds@feb90000 vs lvds-encoder@feb90000 > > Yes, I thought the latter was closer to a "generic" name that DT spec requires... > > > You can add your signed-off-by ofc if you think that's the case. > > Didn't understand what you mean here... Don't worry, I will resend this and use (part of) your series [PATCH v2 0/5] Add R8A77970/V3MSK LVDS/HDMI support But please note that: [1/5] from your series has already been collected by Simon I have to reapply Laurent's comment on this series to your one (so I have to resend it anyhow) [5/5] from your series shall be resent to take into account the newly developed LVDS decoder driver (once it has been accepted) I have anyway to repost your patches then, and as I did in this series you are ofc listed as author already, so I have missed what's the difference actually except from LVDS patch I collected from Niklas and not from your series. Niklas I picked up patches 1-3 of this series from your tree. 1 and 2 are patches from Sergei's series 3 is from you but was also in Sergei's series and I picked yours as it was there already. Can I rebase on top of Sergei's one instead? Thanks j
Hi Jacopo, Sergei, On 2018-04-11 11:53:28 +0200, Jacopo Mondi wrote: > Hi Sergei, Niklas > > On Tue, Apr 10, 2018 at 08:12:36PM +0300, Sergei Shtylyov wrote: > > On 04/10/2018 03:13 PM, jacopo mondi wrote: > > > > >>> From: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > >>> > > >>> Add the LVDS device to r8a77970.dtsi in a disabled state. Also connect > > >>> the it to the LVDS output of the DU. > > >>> > > >>> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > >>> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > > >>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > >>> > > >>> --- > > >>> v1 -> v2: > > >>> - Rebased on the modified endpoint name and changed patch subject to > > >>> comply with other patches in the series from Sergei. > > >> > > >> Stop, what was wrong with my R8A77970 LVDS patch, reposted on the popular > > >> demand? :-) > > >> > > > > > > Nothing wrong, I found out about your right now. > > > I see a very small difference as > > > lvds@feb90000 vs lvds-encoder@feb90000 > > > > Yes, I thought the latter was closer to a "generic" name that DT spec requires... > > > > > You can add your signed-off-by ofc if you think that's the case. > > > > Didn't understand what you mean here... > > Don't worry, I will resend this and use (part of) your series > [PATCH v2 0/5] Add R8A77970/V3MSK LVDS/HDMI support > > But please note that: > [1/5] from your series has already been collected by Simon > I have to reapply Laurent's comment on this series to your one (so I > have to resend it anyhow) > [5/5] from your series shall be resent to take into account the newly > developed LVDS decoder driver (once it has been accepted) > > I have anyway to repost your patches then, and as I did in this series > you are ofc listed as author already, so I have missed what's the > difference actually except from LVDS patch I collected from Niklas and not > from your series. > > Niklas I picked up patches 1-3 of this series from your tree. > 1 and 2 are patches from Sergei's series > 3 is from you but was also in Sergei's series and I picked yours as it > was there already. Can I rebase on top of Sergei's one instead? Yes please do so. And sorry for this mess, it is my fault as I missed one of Sergei's patches when integrating changes I made to r8a77970-eagle.dts. For this series always pick Sergei's patches over mine :-) Once more sorry for the mess to both of you. > > Thanks > j
diff --git a/arch/arm64/boot/dts/renesas/r8a77970.dtsi b/arch/arm64/boot/dts/renesas/r8a77970.dtsi index ae5797d..ae15355 100644 --- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi @@ -659,6 +659,33 @@ port@1 { reg = <1>; du_out_lvds0: endpoint { + remote-endpoint = <&lvds0_in>; + }; + }; + }; + }; + + lvds0: lvds@feb90000 { + compatible = "renesas,r8a77970-lvds"; + reg = <0 0xfeb90000 0 0x14>; + clocks = <&cpg CPG_MOD 727>; + power-domains = <&sysc R8A77970_PD_ALWAYS_ON>; + resets = <&cpg 727>; + status = "disabled"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + lvds0_in: endpoint { + remote-endpoint = <&du_out_lvds0>; + }; + }; + port@1 { + reg = <1>; + lvds0_out: endpoint { }; }; };