From patchwork Fri Apr 13 17:00:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulrich Hecht X-Patchwork-Id: 10340605 X-Patchwork-Delegate: geert@linux-m68k.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 94D8460153 for ; Fri, 13 Apr 2018 17:01:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 81EE82894F for ; Fri, 13 Apr 2018 17:01:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 769592894B; Fri, 13 Apr 2018 17:01:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1B56B2894E for ; Fri, 13 Apr 2018 17:01:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752604AbeDMRBE (ORCPT ); Fri, 13 Apr 2018 13:01:04 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:42206 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751160AbeDMRBD (ORCPT ); Fri, 13 Apr 2018 13:01:03 -0400 Received: by mail-wr0-f193.google.com with SMTP id s18so9841036wrg.9; Fri, 13 Apr 2018 10:01:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=qLQIQaK6trCKpKpHVg6bYZCKuIYTQ+MBXyOWpQbfSeo=; b=Rj4o4z+6dJucmgI8lOLvRAzv0zejtcL5BvVRjzUFTdoU6GWOZzPfPu41vwDqQWtiDy MJie7C8j9xkKsapN4FEhN1OmimK51k9mPwK2jb+W59zS0ps4Y2LLmJIkKN0GYpv/jR1H jdMnNTRjR4le6174krDFM92phPWnv0A9TP8Vwtgi6ZEqYuJuFOxqZ43X3PSgvSiK6Ea5 MWK1Dc0GYso2SHT2NVBfeXryf8RnZHFIp2DqCZjUhbFSvC48k/lhvlLNWmZdp42i5CJ6 Hn21IqERwN9tCg786918+IeFiHwatPqMat0yCZcyc0gGeAA+Gs0FIn6SfeoSDSbk/FXg GYyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=qLQIQaK6trCKpKpHVg6bYZCKuIYTQ+MBXyOWpQbfSeo=; b=QrRg3a19nbxDRWwQZMcdFJR+Z3kqujtortk/oWfzrFPf+DUNTRADSynUff9N3pBq0M XD+zjVQ2+QcjpSmXWtUUvSxnCO18SvuTfA4qO0MJyBJj4Shx7CfliGkvIOTm0wtIgjrU ClQZy6ZBD4MjHZWZnI93jgi+HKG2WHNWq8p5i1EaZ7bofjEkl9dqwJwbRvbpHhrN4VGl s2DzZrnmCGEMwDf5FhJTtHfrCupdtmyRXzj5XB7ZqpcRKewlfOj9ZHN4xI9Q6ZrldntB JM+rklW7+JBsnPS7xT/rYWELQpq6BiBExA8KeVOng+a6/uxIHOwMgytkaMpAeubtXBuC r9Zg== X-Gm-Message-State: ALQs6tCdUBXYQwPQzbqCXD3lz1FemfUtvIdXxJ6tnoycpwKM5FrIQbPv XB0Yp2cZsmuo2eac/Tvu6EA0Poo= X-Google-Smtp-Source: AIpwx4//Z+9xakv25nqex5rORoxIcZjVhP5XcEb14ynuA8BeCVRe0uy8XKyuZZoHjNUshEOPzmceiw== X-Received: by 10.28.170.205 with SMTP id t196mr4452237wme.42.1523638862368; Fri, 13 Apr 2018 10:01:02 -0700 (PDT) Received: from groucho.site (ipbcc0ce2f.dynamic.kabel-deutschland.de. [188.192.206.47]) by smtp.gmail.com with ESMTPSA id q71sm2712082wmd.41.2018.04.13.10.01.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 13 Apr 2018 10:01:01 -0700 (PDT) From: Ulrich Hecht To: linux-renesas-soc@vger.kernel.org Cc: wsa@the-dreams.de, geert@linux-m68k.org, linux-serial@vger.kernel.org, magnus.damm@gmail.com, Hien Dang , Hiromitsu Yamasaki , Ulrich Hecht Subject: [PATCH 2/2] serial: sh-sci: Use pm_runtime_get_sync()/put() on resume Date: Fri, 13 Apr 2018 19:00:54 +0200 Message-Id: <1523638854-21804-3-git-send-email-ulrich.hecht+renesas@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1523638854-21804-1-git-send-email-ulrich.hecht+renesas@gmail.com> References: <1523638854-21804-1-git-send-email-ulrich.hecht+renesas@gmail.com> Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Hien Dang Since commit '39dd0f234fc37d ("PM / Domains: Allow runtime PM during system PM phases")', runtime PM may be in suspended state during the system suspend phase. It is therefore necessary to call pm_runtime_get_sync()/ pm_runtime_put() when accessing the hardware. This modification is the counterpart for the resume case. It ensures stability of the system, should the kernel allow the devices's runtime suspend state to change during the system resume phase as well. Signed-off-by: Hien Dang Signed-off-by: Hiromitsu Yamasaki [uli: edited description for clarity] Signed-off-by: Ulrich Hecht --- drivers/tty/serial/sh-sci.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c index 22d7a78..d5a1acb 100644 --- a/drivers/tty/serial/sh-sci.c +++ b/drivers/tty/serial/sh-sci.c @@ -3259,8 +3259,11 @@ static __maybe_unused int sci_resume(struct device *dev) { struct sci_port *sport = dev_get_drvdata(dev); - if (sport) + if (sport) { + pm_runtime_get_sync(sport->port.dev); uart_resume_port(&sci_uart_driver, &sport->port); + pm_runtime_put(sport->port.dev); + } return 0; }