| Message ID | 1523963101-56725-4-git-send-email-michel.pollet@bp.renesas.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Simon Horman |
| Headers | show |
On Tue, Apr 17, 2018 at 12:04:18PM +0100, Michel Pollet wrote: > This documents the RZ/N1 bindings for the RZN1D-DB board. > > Signed-off-by: Michel Pollet <michel.pollet@bp.renesas.com> > --- > Documentation/devicetree/bindings/arm/shmobile.txt | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) Please add acks/reviewed-bys when posting new versions. Rob
Hi Michel, On Tue, Apr 17, 2018 at 1:04 PM, Michel Pollet <michel.pollet@bp.renesas.com> wrote: > This documents the RZ/N1 bindings for the RZN1D-DB board. > > Signed-off-by: Michel Pollet <michel.pollet@bp.renesas.com> > --- > Documentation/devicetree/bindings/arm/shmobile.txt | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/arm/shmobile.txt b/Documentation/devicetree/bindings/arm/shmobile.txt > index 61b486f..6efb3f1 100644 > --- a/Documentation/devicetree/bindings/arm/shmobile.txt > +++ b/Documentation/devicetree/bindings/arm/shmobile.txt > @@ -51,7 +51,8 @@ SoCs: > compatible = "renesas,r8a77990" > - R-Car D3 (R8A77995) > compatible = "renesas,r8a77995" > - > + - RZ/N1D (R9A06G032) > + compatible = "renesas,r9a06g032", "renesas,rzn1" Why do you need a family-specific compatible value ("renesas,rzn1", which is a marketing name)? Gr{oetje,eeting}s, Geert
On Tue, Apr 17, 2018 at 05:49:25PM +0200, Geert Uytterhoeven wrote: > Hi Michel, > > On Tue, Apr 17, 2018 at 1:04 PM, Michel Pollet > <michel.pollet@bp.renesas.com> wrote: > > This documents the RZ/N1 bindings for the RZN1D-DB board. > > > > Signed-off-by: Michel Pollet <michel.pollet@bp.renesas.com> > > --- > > Documentation/devicetree/bindings/arm/shmobile.txt | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/arm/shmobile.txt b/Documentation/devicetree/bindings/arm/shmobile.txt > > index 61b486f..6efb3f1 100644 > > --- a/Documentation/devicetree/bindings/arm/shmobile.txt > > +++ b/Documentation/devicetree/bindings/arm/shmobile.txt > > @@ -51,7 +51,8 @@ SoCs: > > compatible = "renesas,r8a77990" > > - R-Car D3 (R8A77995) > > compatible = "renesas,r8a77995" > > - > > + - RZ/N1D (R9A06G032) > > + compatible = "renesas,r9a06g032", "renesas,rzn1" > > Why do you need a family-specific compatible value ("renesas,rzn1", > which is a marketing name)? Thanks Michel, Thanks Geert, it looks like this extra compatible value should be dropped. Its not consistent with the way other Renesas SoC families are handled and past experience has not lead us to want family-specific compatible values.
diff --git a/Documentation/devicetree/bindings/arm/shmobile.txt b/Documentation/devicetree/bindings/arm/shmobile.txt index 61b486f..6efb3f1 100644 --- a/Documentation/devicetree/bindings/arm/shmobile.txt +++ b/Documentation/devicetree/bindings/arm/shmobile.txt @@ -51,7 +51,8 @@ SoCs: compatible = "renesas,r8a77990" - R-Car D3 (R8A77995) compatible = "renesas,r8a77995" - + - RZ/N1D (R9A06G032) + compatible = "renesas,r9a06g032", "renesas,rzn1" Boards: @@ -112,6 +113,8 @@ Boards: compatible = "renesas,porter", "renesas,r8a7791" - RSKRZA1 (YR0K77210C000BE) compatible = "renesas,rskrza1", "renesas,r7s72100" + - RZN1D-DB (RZ/N1D Demo Board for the RZ/N1D 400 pins package) + compatible = "renesas,rzn1d400-db", "renesas,r9a06g032", "renesas,rzn1" - Salvator-X (RTP0RC7795SIPB0010S) compatible = "renesas,salvator-x", "renesas,r8a7795" - Salvator-X (RTP0RC7796SIPB0011S)
This documents the RZ/N1 bindings for the RZN1D-DB board. Signed-off-by: Michel Pollet <michel.pollet@bp.renesas.com> --- Documentation/devicetree/bindings/arm/shmobile.txt | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)