| Message ID | 1524130269-32688-9-git-send-email-jacopo+renesas@jmondi.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
Hi Jacopo, Thank you for the patch. On Thursday, 19 April 2018 12:31:09 EEST Jacopo Mondi wrote: > DRM_BUS_FLAG_DATA_* flags, defined in drm_connector.h header file are > used to swap ordering of LVDS RGB format to accommodate DRM objects > that need to handle LVDS components ordering. > > Now that the only 2 users of DRM_BUS_FLAG_DATA_* flags have been ported > to use the newly introduced MEDIA_BUS_FMT_RGB888_1X7X*_LE media bus > formats, remove them. I'm not opposed to this (despite my review of patch 5/8), but I think the _LE suffix isn't the right name for the new formats. _BE and _LE relate to byte swapping, while here you really need to describe full mirroring. Maybe a _MIRROR variant would be more appropriate ? > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > --- > include/drm/drm_connector.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h > index 675cc3f..9e0d6d5 100644 > --- a/include/drm/drm_connector.h > +++ b/include/drm/drm_connector.h > @@ -286,10 +286,6 @@ struct drm_display_info { > #define DRM_BUS_FLAG_PIXDATA_POSEDGE (1<<2) > /* drive data on neg. edge */ > #define DRM_BUS_FLAG_PIXDATA_NEGEDGE (1<<3) > -/* data is transmitted MSB to LSB on the bus */ > -#define DRM_BUS_FLAG_DATA_MSB_TO_LSB (1<<4) > -/* data is transmitted LSB to MSB on the bus */ > -#define DRM_BUS_FLAG_DATA_LSB_TO_MSB (1<<5) > > /** > * @bus_flags: Additional information (like pixel signal polarity) for
Hi Laurent, On Tue, Apr 24, 2018 at 12:03:04AM +0300, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > On Thursday, 19 April 2018 12:31:09 EEST Jacopo Mondi wrote: > > DRM_BUS_FLAG_DATA_* flags, defined in drm_connector.h header file are > > used to swap ordering of LVDS RGB format to accommodate DRM objects > > that need to handle LVDS components ordering. > > > > Now that the only 2 users of DRM_BUS_FLAG_DATA_* flags have been ported > > to use the newly introduced MEDIA_BUS_FMT_RGB888_1X7X*_LE media bus > > formats, remove them. > > I'm not opposed to this (despite my review of patch 5/8), but I think the _LE > suffix isn't the right name for the new formats. _BE and _LE relate to byte > swapping, while here you really need to describe full mirroring. Maybe a > _MIRROR variant would be more appropriate ? As I anticipated in the cover letter, I agree the BE/LE distinction does not apply well for LVDS formats. I chose to use _LE anyhow as there are no other format variants defined in media-bus-format.h I'm open to use either of those suffixes btw, what presses me is to get rid of those flags only defined in drm_connector.h thanks j > > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > > --- > > include/drm/drm_connector.h | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h > > index 675cc3f..9e0d6d5 100644 > > --- a/include/drm/drm_connector.h > > +++ b/include/drm/drm_connector.h > > @@ -286,10 +286,6 @@ struct drm_display_info { > > #define DRM_BUS_FLAG_PIXDATA_POSEDGE (1<<2) > > /* drive data on neg. edge */ > > #define DRM_BUS_FLAG_PIXDATA_NEGEDGE (1<<3) > > -/* data is transmitted MSB to LSB on the bus */ > > -#define DRM_BUS_FLAG_DATA_MSB_TO_LSB (1<<4) > > -/* data is transmitted LSB to MSB on the bus */ > > -#define DRM_BUS_FLAG_DATA_LSB_TO_MSB (1<<5) > > > > /** > > * @bus_flags: Additional information (like pixel signal polarity) for > > > -- > Regards, > > Laurent Pinchart > > >
diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h index 675cc3f..9e0d6d5 100644 --- a/include/drm/drm_connector.h +++ b/include/drm/drm_connector.h @@ -286,10 +286,6 @@ struct drm_display_info { #define DRM_BUS_FLAG_PIXDATA_POSEDGE (1<<2) /* drive data on neg. edge */ #define DRM_BUS_FLAG_PIXDATA_NEGEDGE (1<<3) -/* data is transmitted MSB to LSB on the bus */ -#define DRM_BUS_FLAG_DATA_MSB_TO_LSB (1<<4) -/* data is transmitted LSB to MSB on the bus */ -#define DRM_BUS_FLAG_DATA_LSB_TO_MSB (1<<5) /** * @bus_flags: Additional information (like pixel signal polarity) for
DRM_BUS_FLAG_DATA_* flags, defined in drm_connector.h header file are used to swap ordering of LVDS RGB format to accommodate DRM objects that need to handle LVDS components ordering. Now that the only 2 users of DRM_BUS_FLAG_DATA_* flags have been ported to use the newly introduced MEDIA_BUS_FMT_RGB888_1X7X*_LE media bus formats, remove them. Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> --- include/drm/drm_connector.h | 4 ---- 1 file changed, 4 deletions(-)