| Message ID | 1524767083-19862-3-git-send-email-jacopo+renesas@jmondi.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 6ff6991bb4adc74cc248f2aaea2e5560671b34c2 |
| Delegated to: | Simon Horman |
| Headers | show |
On Thu, Apr 26, 2018 at 08:24:43PM +0200, Jacopo Mondi wrote: > Describe CEU0 peripheral for Renesas R-Mobile A1 R8A7740 Soc. > > Reported-by: Geert Uytterhoeven <geert@glider.be> > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> Thanks, applied.
Hi Jacopo, On Thu, Apr 26, 2018 at 8:24 PM, Jacopo Mondi <jacopo+renesas@jmondi.org> wrote: > Describe CEU0 peripheral for Renesas R-Mobile A1 R8A7740 Soc. > > Reported-by: Geert Uytterhoeven <geert@glider.be> > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> Thanks for your patch! Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Minor question below. > --- a/arch/arm/boot/dts/r8a7740.dtsi > +++ b/arch/arm/boot/dts/r8a7740.dtsi > @@ -67,6 +67,16 @@ > power-domains = <&pd_d4>; > }; > > + ceu0: ceu@fe910000 { > + reg = <0xfe910000 0x3000>; > + compatible = "renesas,r8a7740-ceu"; > + interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&mstp1_clks R8A7740_CLK_CEU20>; > + clock-names = "ceu20"; Why the "clock-names" property? It's not mentioned in the DT bindings, and may cause issues if the bindings are ever amended. > + power-domains = <&pd_a4r>; > + status = "disabled"; > + }; > + Gr{oetje,eeting}s, Geert
On Wed, May 16, 2018 at 09:40:09AM +0200, Geert Uytterhoeven wrote: > Hi Jacopo, > > On Thu, Apr 26, 2018 at 8:24 PM, Jacopo Mondi <jacopo+renesas@jmondi.org> wrote: > > Describe CEU0 peripheral for Renesas R-Mobile A1 R8A7740 Soc. > > > > Reported-by: Geert Uytterhoeven <geert@glider.be> > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > > Thanks for your patch! > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Minor question below. > > > --- a/arch/arm/boot/dts/r8a7740.dtsi > > +++ b/arch/arm/boot/dts/r8a7740.dtsi > > @@ -67,6 +67,16 @@ > > power-domains = <&pd_d4>; > > }; > > > > + ceu0: ceu@fe910000 { > > + reg = <0xfe910000 0x3000>; > > + compatible = "renesas,r8a7740-ceu"; > > + interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&mstp1_clks R8A7740_CLK_CEU20>; > > + clock-names = "ceu20"; > > Why the "clock-names" property? It's not mentioned in the DT bindings, and > may cause issues if the bindings are ever amended. I have dropped that property for now. > > > + power-domains = <&pd_a4r>; > > + status = "disabled"; > > + }; > > + > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds >
diff --git a/arch/arm/boot/dts/r8a7740.dtsi b/arch/arm/boot/dts/r8a7740.dtsi index afd3bc5..508d934 100644 --- a/arch/arm/boot/dts/r8a7740.dtsi +++ b/arch/arm/boot/dts/r8a7740.dtsi @@ -67,6 +67,16 @@ power-domains = <&pd_d4>; }; + ceu0: ceu@fe910000 { + reg = <0xfe910000 0x3000>; + compatible = "renesas,r8a7740-ceu"; + interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&mstp1_clks R8A7740_CLK_CEU20>; + clock-names = "ceu20"; + power-domains = <&pd_a4r>; + status = "disabled"; + }; + cmt1: timer@e6138000 { compatible = "renesas,cmt-48-r8a7740", "renesas,cmt-48"; reg = <0xe6138000 0x170>;
Describe CEU0 peripheral for Renesas R-Mobile A1 R8A7740 Soc. Reported-by: Geert Uytterhoeven <geert@glider.be> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> --- arch/arm/boot/dts/r8a7740.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+)