Message ID | 1533628626-26503-6-git-send-email-biju.das@bp.renesas.com (mailing list archive) |
---|---|
State | Superseded |
Delegated to: | Simon Horman |
Headers | show |
Series | Add GPIO and EAVB Pinctrl support | expand |
On Tue, Aug 07, 2018 at 08:57:06AM +0100, Biju Das wrote: > Adding pinctrl support for EtherAVB interface. > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > V1-->V2 > * No change > V2-->V3 > * No change > Depend onthe below patch > https://patchwork.kernel.org/patch/10546801/ What is the effect of applying this patch without that dependency present?
Hello Simon, Thanks for the feedback. > Subject: Re: [PATCH v3 5/5] ARM: dts: iwg23s-sbc: Add pinctl support for > EtherAVB > > On Tue, Aug 07, 2018 at 08:57:06AM +0100, Biju Das wrote: > > Adding pinctrl support for EtherAVB interface. > > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > --- > > V1-->V2 > > * No change > > V2-->V3 > > * No change > > Depend onthe below patch > > https://patchwork.kernel.org/patch/10546801/ > > What is the effect of applying this patch without that dependency present? No build dependency. Only driver probe will fail during run time. [ 0.838091] ravb: probe of e6800000.ethernet failed with error -22 Regards, Biju Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
On Fri, Aug 10, 2018 at 01:47:12PM +0000, Biju Das wrote: > Hello Simon, > > Thanks for the feedback. > > > Subject: Re: [PATCH v3 5/5] ARM: dts: iwg23s-sbc: Add pinctl support for > > EtherAVB > > > > On Tue, Aug 07, 2018 at 08:57:06AM +0100, Biju Das wrote: > > > Adding pinctrl support for EtherAVB interface. > > > > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > --- > > > V1-->V2 > > > * No change > > > V2-->V3 > > > * No change > > > Depend onthe below patch > > > https://patchwork.kernel.org/patch/10546801/ > > > > What is the effect of applying this patch without that dependency present? > > No build dependency. Only driver probe will fail during run time. > [ 0.838091] ravb: probe of e6800000.ethernet failed with error -22 Thanks, but does the driver probe fail without this patch? If so I'd rather hold off on this until v4.21.
Hi Simon, Thanks for the feedback. > -----Original Message----- > From: devicetree-owner@vger.kernel.org <devicetree- > owner@vger.kernel.org> On Behalf Of Simon Horman > Sent: 17 August 2018 09:45 > To: Biju Das <biju.das@bp.renesas.com> > Cc: Rob Herring <robh+dt@kernel.org>; Mark Rutland > <mark.rutland@arm.com>; Magnus Damm <magnus.damm@gmail.com>; > linux-renesas-soc@vger.kernel.org; devicetree@vger.kernel.org; Geert > Uytterhoeven <geert+renesas@glider.be>; Chris Paterson > <Chris.Paterson2@renesas.com>; Fabrizio Castro > <fabrizio.castro@bp.renesas.com> > Subject: Re: [PATCH v3 5/5] ARM: dts: iwg23s-sbc: Add pinctl support for > EtherAVB > > On Fri, Aug 10, 2018 at 01:47:12PM +0000, Biju Das wrote: > > Hello Simon, > > > > Thanks for the feedback. > > > > > Subject: Re: [PATCH v3 5/5] ARM: dts: iwg23s-sbc: Add pinctl support > > > for EtherAVB > > > > > > On Tue, Aug 07, 2018 at 08:57:06AM +0100, Biju Das wrote: > > > > Adding pinctrl support for EtherAVB interface. > > > > > > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > > > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > --- > > > > V1-->V2 > > > > * No change > > > > V2-->V3 > > > > * No change > > > > Depend onthe below patch > > > > https://patchwork.kernel.org/patch/10546801/ > > > > > > What is the effect of applying this patch without that dependency > present? > > > > No build dependency. Only driver probe will fail during run time. > > [ 0.838091] ravb: probe of e6800000.ethernet failed with error -22 > > Thanks, but does the driver probe fail without this patch? Drive probe works ok without this patch. > If so I'd rather hold off on this until v4.21. Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
diff --git a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts index a3d92d9..2bfba93 100644 --- a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts +++ b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts @@ -52,6 +52,9 @@ }; &avb { + pinctrl-0 = <&avb_pins>; + pinctrl-names = "default"; + phy-handle = <&phy3>; phy-mode = "gmii"; renesas,no-ether-link; @@ -70,6 +73,11 @@ }; &pfc { + avb_pins: avb { + groups = "avb_mdio", "avb_gmii_tx_rx"; + function = "avb"; + }; + scif1_pins: scif1 { groups = "scif1_data_b"; function = "scif1";