diff mbox series

[PATCH/RFC,v2,01/02] ravb: Do not announce HDX as supported

Message ID 153477718520.16950.10138071667883935510.sendpatchset@octo (mailing list archive)
State Superseded
Delegated to: Geert Uytterhoeven
Headers show
Series ravb: Duplex handling update V2 | expand

Commit Message

Magnus Damm Aug. 20, 2018, 2:59 p.m. UTC 
From: Magnus Damm <damm+renesas@opensource.se>

According to the data sheet the Ethernet-AVB hardware in R-Car Gen3
and R-Car Gen2 SoCs do not support half duplex operation. So update
the driver to mark 100Mbit and 1Gbps HDX as unsupported.

Not-Yet-Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper")
Reviewed-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---

 Written on top of next-20180820

 drivers/net/ethernet/renesas/ravb_main.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff mbox series

Patch

--- 0001/drivers/net/ethernet/renesas/ravb_main.c
+++ work/drivers/net/ethernet/renesas/ravb_main.c	2018-08-20 23:42:46.670859449 +0900
@@ -1076,8 +1076,9 @@  static int ravb_phy_init(struct net_devi
 		netdev_info(ndev, "limited PHY to 100Mbit/s\n");
 	}
 
-	/* 10BASE is not supported */
-	phydev->supported &= ~PHY_10BT_FEATURES;
+	/* Neither 10BASE nor half duplex are supported */
+	phydev->supported &= ~(PHY_10BT_FEATURES | SUPPORTED_100baseT_Half |
+			       SUPPORTED_1000baseT_Half);
 
 	phy_attached_info(phydev);