diff mbox series

ARM: dts: iwg20d-q7-common: Move pciec node out of common dtsi

Message ID 1537538875-62836-1-git-send-email-biju.das@bp.renesas.com (mailing list archive)
State Accepted
Commit e0a39511dafd7e302a974f5cbdfc9c8afffa98d8
Delegated to: Simon Horman
Headers show
Series ARM: dts: iwg20d-q7-common: Move pciec node out of common dtsi | expand

Commit Message

Biju Das Sept. 21, 2018, 2:07 p.m. UTC 
PCIe is not populated by default on iWave RZ/G1N board. RZ/G1N board
is almost identical to RZ/G1M. In order to reuse the common dtsi for
both the boards, it is required to move pcie node from common dtsi
to board specific dts.

Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
 arch/arm/boot/dts/iwg20d-q7-common.dtsi         | 4 ----
 arch/arm/boot/dts/r8a7743-iwg20d-q7-dbcm-ca.dts | 4 ++++
 arch/arm/boot/dts/r8a7743-iwg20d-q7.dts         | 4 ++++
 3 files changed, 8 insertions(+), 4 deletions(-)

Comments

Simon Horman Sept. 24, 2018, 8:38 a.m. UTC | #1 
On Fri, Sep 21, 2018 at 03:07:55PM +0100, Biju Das wrote:
> PCIe is not populated by default on iWave RZ/G1N board. RZ/G1N board
> is almost identical to RZ/G1M. In order to reuse the common dtsi for
> both the boards, it is required to move pcie node from common dtsi
> to board specific dts.
> 
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Thanks,

This looks fine to me but I will wait to see if there are other reviews
before applying.

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Simon Horman Sept. 25, 2018, 7:34 a.m. UTC | #2 
On Mon, Sep 24, 2018 at 10:38:51AM +0200, Simon Horman wrote:
> On Fri, Sep 21, 2018 at 03:07:55PM +0100, Biju Das wrote:
> > PCIe is not populated by default on iWave RZ/G1N board. RZ/G1N board
> > is almost identical to RZ/G1M. In order to reuse the common dtsi for
> > both the boards, it is required to move pcie node from common dtsi
> > to board specific dts.
> > 
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> 
> Thanks,
> 
> This looks fine to me but I will wait to see if there are other reviews
> before applying.

Thanks again, applied for v4.20.
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/iwg20d-q7-common.dtsi b/arch/arm/boot/dts/iwg20d-q7-common.dtsi
index 5cae74e..ca9154dd 100644
--- a/arch/arm/boot/dts/iwg20d-q7-common.dtsi
+++ b/arch/arm/boot/dts/iwg20d-q7-common.dtsi
@@ -160,10 +160,6 @@ 
 	clock-frequency = <100000000>;
 };
 
-&pciec {
-	status = "okay";
-};
-
 &pfc {
 	can0_pins: can0 {
 		groups = "can0_data_d";
diff --git a/arch/arm/boot/dts/r8a7743-iwg20d-q7-dbcm-ca.dts b/arch/arm/boot/dts/r8a7743-iwg20d-q7-dbcm-ca.dts
index 3275451..0d006ae 100644
--- a/arch/arm/boot/dts/r8a7743-iwg20d-q7-dbcm-ca.dts
+++ b/arch/arm/boot/dts/r8a7743-iwg20d-q7-dbcm-ca.dts
@@ -14,3 +14,7 @@ 
 	model = "iW-RainboW-G20D-Q7 RZ/G1M based plus camera daughter board";
 	compatible = "iwave,g20d", "iwave,g20m", "renesas,r8a7743";
 };
+
+&pciec {
+	status = "okay";
+};
diff --git a/arch/arm/boot/dts/r8a7743-iwg20d-q7.dts b/arch/arm/boot/dts/r8a7743-iwg20d-q7.dts
index b683db4..498e223 100644
--- a/arch/arm/boot/dts/r8a7743-iwg20d-q7.dts
+++ b/arch/arm/boot/dts/r8a7743-iwg20d-q7.dts
@@ -13,3 +13,7 @@ 
 	model = "iWave Systems RainboW-G20D-Qseven board based on RZ/G1M";
 	compatible = "iwave,g20d", "iwave,g20m", "renesas,r8a7743";
 };
+
+&pciec {
+	status = "okay";
+};