| Message ID | 1539669890-25719-1-git-send-email-yoshihiro.shimoda.uh@renesas.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e67898dc2d2b4bf484dd8807d62c88480f6290fb |
| Delegated to: | Simon Horman |
| Headers | show |
| Series | arm64: dts: renesas: revise hsusb's reg size | expand |
On Tue, Oct 16, 2018 at 03:04:50PM +0900, Yoshihiro Shimoda wrote: > This patch revises the reg size of each hsusb device node for > r8a7795, r8a7796 and r8a77965. > > Reported-by: Biju Das <biju.das@bp.renesas.com> > Fixes: d2422e108812 ("arm64: dts: r8a7795: Add HSUSB device node") > Fixes: 4725f2b88057 ("arm64: dts: renesas: r8a7795: add hsusb ch3 device node") > Fixes: b9535853777f ("arm64: dts: r8a7796: Add HSUSB device node") > Fixes: 9e1b00a2ef43 ("arm64: dts: renesas: r8a77965: Add "reg" properties") > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Thanks Shimoda-san, This looks fine to me but I will wait to see if there are other reviews before applying. Reviewed-by: Simon Horman <horms+renesas@verge.net.au> Also, could you let me know if this has any run-time effect? If so perhaps it should be treated as a fix for v4.20 rather than a patch for v4.21.
Hi Shimoda-San, Thanks for the patch. > -----Original Message----- > From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc- > owner@vger.kernel.org> On Behalf Of Yoshihiro Shimoda > Sent: 16 October 2018 07:05 > To: horms@verge.net.au; magnus.damm@gmail.com > Cc: linux-renesas-soc@vger.kernel.org; Yoshihiro Shimoda > <yoshihiro.shimoda.uh@renesas.com> > Subject: [PATCH] arm64: dts: renesas: revise hsusb's reg size > > This patch revises the reg size of each hsusb device node for r8a7795, r8a7796 > and r8a77965. > > Reported-by: Biju Das <biju.das@bp.renesas.com> > Fixes: d2422e108812 ("arm64: dts: r8a7795: Add HSUSB device node") > Fixes: 4725f2b88057 ("arm64: dts: renesas: r8a7795: add hsusb ch3 device > node") > Fixes: b9535853777f ("arm64: dts: r8a7796: Add HSUSB device node") > Fixes: 9e1b00a2ef43 ("arm64: dts: renesas: r8a77965: Add "reg" properties") > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Reviewed-by: Biju Das <biju.das@bp.renesas.com> Regards, Biju Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
Hi Simon, On Wed, Oct 17, 2018 at 10:57 AM Simon Horman <horms@verge.net.au> wrote: > On Tue, Oct 16, 2018 at 03:04:50PM +0900, Yoshihiro Shimoda wrote: > > This patch revises the reg size of each hsusb device node for > > r8a7795, r8a7796 and r8a77965. > > > > Reported-by: Biju Das <biju.das@bp.renesas.com> > > Fixes: d2422e108812 ("arm64: dts: r8a7795: Add HSUSB device node") > > Fixes: 4725f2b88057 ("arm64: dts: renesas: r8a7795: add hsusb ch3 device node") > > Fixes: b9535853777f ("arm64: dts: r8a7796: Add HSUSB device node") > > Fixes: 9e1b00a2ef43 ("arm64: dts: renesas: r8a77965: Add "reg" properties") > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > Thanks Shimoda-san, > > This looks fine to me but I will wait to see if there are other reviews > before applying. > > Reviewed-by: Simon Horman <horms+renesas@verge.net.au> > > > Also, could you let me know if this has any run-time effect? > If so perhaps it should be treated as a fix for v4.20 rather than > a patch for v4.21. Probably not, as mapping granularity is PAGE_SIZE (> 0x200) anyway. Gr{oetje,eeting}s, Geert
On Wed, Oct 17, 2018 at 11:34:43AM +0200, Geert Uytterhoeven wrote: > Hi Simon, > > On Wed, Oct 17, 2018 at 10:57 AM Simon Horman <horms@verge.net.au> wrote: > > On Tue, Oct 16, 2018 at 03:04:50PM +0900, Yoshihiro Shimoda wrote: > > > This patch revises the reg size of each hsusb device node for > > > r8a7795, r8a7796 and r8a77965. > > > > > > Reported-by: Biju Das <biju.das@bp.renesas.com> > > > Fixes: d2422e108812 ("arm64: dts: r8a7795: Add HSUSB device node") > > > Fixes: 4725f2b88057 ("arm64: dts: renesas: r8a7795: add hsusb ch3 device node") > > > Fixes: b9535853777f ("arm64: dts: r8a7796: Add HSUSB device node") > > > Fixes: 9e1b00a2ef43 ("arm64: dts: renesas: r8a77965: Add "reg" properties") > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > > > Thanks Shimoda-san, > > > > This looks fine to me but I will wait to see if there are other reviews > > before applying. > > > > Reviewed-by: Simon Horman <horms+renesas@verge.net.au> > > > > > > Also, could you let me know if this has any run-time effect? > > If so perhaps it should be treated as a fix for v4.20 rather than > > a patch for v4.21. > > Probably not, as mapping granularity is PAGE_SIZE (> 0x200) anyway. Thanks, I have applied this for v4.21.
Hi Simon-san, Geert-san, > From: Geert Uytterhoeven, Sent: Wednesday, October 17, 2018 6:35 PM > > Hi Simon, > > On Wed, Oct 17, 2018 at 10:57 AM Simon Horman <horms@verge.net.au> wrote: > > On Tue, Oct 16, 2018 at 03:04:50PM +0900, Yoshihiro Shimoda wrote: > > > This patch revises the reg size of each hsusb device node for > > > r8a7795, r8a7796 and r8a77965. > > > > > > Reported-by: Biju Das <biju.das@bp.renesas.com> > > > Fixes: d2422e108812 ("arm64: dts: r8a7795: Add HSUSB device node") > > > Fixes: 4725f2b88057 ("arm64: dts: renesas: r8a7795: add hsusb ch3 device node") > > > Fixes: b9535853777f ("arm64: dts: r8a7796: Add HSUSB device node") > > > Fixes: 9e1b00a2ef43 ("arm64: dts: renesas: r8a77965: Add "reg" properties") > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > > > Thanks Shimoda-san, > > > > This looks fine to me but I will wait to see if there are other reviews > > before applying. > > > > Reviewed-by: Simon Horman <horms+renesas@verge.net.au> > > > > > > Also, could you let me know if this has any run-time effect? > > If so perhaps it should be treated as a fix for v4.20 rather than > > a patch for v4.21. > > Probably not, as mapping granularity is PAGE_SIZE (> 0x200) anyway. As Geert-san mentioned, I don't think this patch needs as a fix for v4.20. Best regards, Yoshihiro Shimoda > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi index 5f6020e..0b54c53 100644 --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi @@ -695,7 +695,7 @@ hsusb: usb@e6590000 { compatible = "renesas,usbhs-r8a7795", "renesas,rcar-gen3-usbhs"; - reg = <0 0xe6590000 0 0x100>; + reg = <0 0xe6590000 0 0x200>; interrupts = <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>; clocks = <&cpg CPG_MOD 704>, <&cpg CPG_MOD 703>; dmas = <&usb_dmac0 0>, <&usb_dmac0 1>, @@ -712,7 +712,7 @@ hsusb3: usb@e659c000 { compatible = "renesas,usbhs-r8a7795", "renesas,rcar-gen3-usbhs"; - reg = <0 0xe659c000 0 0x100>; + reg = <0 0xe659c000 0 0x200>; interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>; clocks = <&cpg CPG_MOD 705>, <&cpg CPG_MOD 700>; dmas = <&usb_dmac2 0>, <&usb_dmac2 1>, diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi index 1ec6aaa..3baee26 100644 --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi @@ -674,7 +674,7 @@ hsusb: usb@e6590000 { compatible = "renesas,usbhs-r8a7796", "renesas,rcar-gen3-usbhs"; - reg = <0 0xe6590000 0 0x100>; + reg = <0 0xe6590000 0 0x200>; interrupts = <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>; clocks = <&cpg CPG_MOD 704>, <&cpg CPG_MOD 703>; dmas = <&usb_dmac0 0>, <&usb_dmac0 1>, diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi index 83946ca..f12be5b 100644 --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi @@ -590,7 +590,7 @@ hsusb: usb@e6590000 { compatible = "renesas,usbhs-r8a77965", "renesas,rcar-gen3-usbhs"; - reg = <0 0xe6590000 0 0x100>; + reg = <0 0xe6590000 0 0x200>; interrupts = <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>; clocks = <&cpg CPG_MOD 704>, <&cpg CPG_MOD 703>; dmas = <&usb_dmac0 0>, <&usb_dmac0 1>,
This patch revises the reg size of each hsusb device node for r8a7795, r8a7796 and r8a77965. Reported-by: Biju Das <biju.das@bp.renesas.com> Fixes: d2422e108812 ("arm64: dts: r8a7795: Add HSUSB device node") Fixes: 4725f2b88057 ("arm64: dts: renesas: r8a7795: add hsusb ch3 device node") Fixes: b9535853777f ("arm64: dts: r8a7796: Add HSUSB device node") Fixes: 9e1b00a2ef43 ("arm64: dts: renesas: r8a77965: Add "reg" properties") Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- arch/arm64/boot/dts/renesas/r8a7795.dtsi | 4 ++-- arch/arm64/boot/dts/renesas/r8a7796.dtsi | 2 +- arch/arm64/boot/dts/renesas/r8a77965.dtsi | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)