From patchwork Wed Nov 21 06:31:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yoshihiro Shimoda X-Patchwork-Id: 10692001 X-Patchwork-Delegate: geert@linux-m68k.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E3AB65A4 for ; Wed, 21 Nov 2018 06:31:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C70642B804 for ; Wed, 21 Nov 2018 06:31:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B748E2B83F; Wed, 21 Nov 2018 06:31:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6241F2B804 for ; Wed, 21 Nov 2018 06:31:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726531AbeKUREi (ORCPT ); Wed, 21 Nov 2018 12:04:38 -0500 Received: from mail-eopbgr1410100.outbound.protection.outlook.com ([40.107.141.100]:62514 "EHLO JPN01-OS2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726039AbeKUREi (ORCPT ); Wed, 21 Nov 2018 12:04:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesasgroup.onmicrosoft.com; s=selector1-renesas-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wAczohH6PCg/e9Laj8zb+2cpYBMl8R5dQSL+5JSJhgA=; b=CotdffAvzAlH4LQ5VoHakx8k8WDGXzTTRK2cRMzO9b0le7XtLepNTvKoQEUMmV1jKJzy1n3Sf4ccZdN43j/cXUC6XMGs5vTUqErQAYMAJ/TpqjOdUTg+YYKlIn3LnXImW8rxPJlsuGTWaJ9sV+RksMl8Gu1dTI04PinKVkSQVQ0= Received: from OSBPR01MB2293.jpnprd01.prod.outlook.com (52.134.243.14) by OSBPR01MB3128.jpnprd01.prod.outlook.com (52.134.255.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.26; Wed, 21 Nov 2018 06:31:23 +0000 Received: from OSBPR01MB2293.jpnprd01.prod.outlook.com ([fe80::c070:7362:375f:74c5]) by OSBPR01MB2293.jpnprd01.prod.outlook.com ([fe80::c070:7362:375f:74c5%4]) with mapi id 15.20.1339.027; Wed, 21 Nov 2018 06:31:23 +0000 From: Yoshihiro Shimoda To: "balbi@kernel.org" CC: "gregkh@linuxfoundation.org" , "jarkko.nikula@linux.intel.com" , "linux-usb@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , Yoshihiro Shimoda Subject: [PATCH 1/2] usb: renesas_usbhs: Remove dummy runtime PM callbacks Thread-Topic: [PATCH 1/2] usb: renesas_usbhs: Remove dummy runtime PM callbacks Thread-Index: AQHUgWPSPoh/h/m0EkyqTpHT4MC0Bg== Date: Wed, 21 Nov 2018 06:31:23 +0000 Message-ID: <1542781735-8548-2-git-send-email-yoshihiro.shimoda.uh@renesas.com> References: <1542781735-8548-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> In-Reply-To: <1542781735-8548-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> Accept-Language: ja-JP, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 1.9.1 x-clientproxiedby: TY1PR01CA0188.jpnprd01.prod.outlook.com (2603:1096:403::18) To OSBPR01MB2293.jpnprd01.prod.outlook.com (2603:1096:603:26::14) authentication-results: spf=none (sender IP is ) smtp.mailfrom=yoshihiro.shimoda.uh@renesas.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [211.11.155.144] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;OSBPR01MB3128;20:UjyrW2VIov3EqEEWCCADxzHMreFrQupQVGyre8UawsmufPyUQ7l2hSgyOcf7x1UxJ0unqbLo/iwK1uREbL2vJ3mgoY5759hs6YvHIIxZRBp7kgF+c0VkbjJS/rgupyTyEociGVkPDswaHUnx1rt9ZPcp2e4NzhPBPU7dssRJBdo= x-ms-office365-filtering-correlation-id: 9c5ffc5f-73d3-4850-21ac-08d64f7af4ad x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390098)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020);SRVR:OSBPR01MB3128; x-ms-traffictypediagnostic: OSBPR01MB3128: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231442)(944501410)(52105112)(10201501046)(93006095)(93001095)(3002001)(6055026)(148016)(149066)(150057)(6041310)(20161123564045)(20161123560045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095);SRVR:OSBPR01MB3128;BCL:0;PCL:0;RULEID:;SRVR:OSBPR01MB3128; x-forefront-prvs: 08635C03D4 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(396003)(346002)(376002)(39860400002)(136003)(366004)(189003)(199004)(54906003)(6436002)(102836004)(5640700003)(52116002)(6486002)(86362001)(99286004)(105586002)(478600001)(53936002)(446003)(66066001)(2351001)(6512007)(5660300001)(14454004)(2501003)(81156014)(1730700003)(106356001)(11346002)(81166006)(8676002)(476003)(7736002)(2616005)(50226002)(6916009)(107886003)(6116002)(97736004)(68736007)(8936002)(486006)(2900100001)(186003)(386003)(305945005)(3846002)(2906002)(4326008)(71200400001)(25786009)(26005)(6506007)(76176011)(71190400001)(14444005)(316002)(256004)(36756003);DIR:OUT;SFP:1102;SCL:1;SRVR:OSBPR01MB3128;H:OSBPR01MB2293.jpnprd01.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: renesas.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: NYFpUh7O7W/EHxEvzRqxZJ3G6Y8M41kV1b6bMkRSODToPPP7lAo29jRk/dQSfqM8eVtIQn8fYdE3N3HxJsiDrebEKhK/saeNqtwAk0JSsJJN88pqvRgMuc4E2qG0yQA6FZPT0SyHZQpzHElHGJT+sw2by9Ka8rdTffsWBxnxjvzjFYwlh5XRFuDC+bCXIO4mx3mPXZVcxyULZrrlblmV8o6mv7AKKPXvce00n0poOSO7Ulqp9W6SJ9rNFmfbt/UTT2pr5zC22NkbTE1dVQtLLUzV1r9wQsUP12ipXos3Y4EHoupH7hQKwtZMvAGvzpHlgY4TuF75KjYJi/VFCKHk2UDmmi4ceDP4lR3ujO1IDMU= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9c5ffc5f-73d3-4850-21ac-08d64f7af4ad X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Nov 2018 06:31:23.2220 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSBPR01MB3128 Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Jarkko Nikula Platform drivers don't need dummy runtime PM callbacks that just return success in order to have runtime PM happening. This has changed since following commits: commit 05aa55dddb9e ("PM / Runtime: Lenient generic runtime pm callbacks") commit 543f2503a956 ("PM / platform_bus: Allow runtime PM by default") commit 8b313a38ecff ("PM / Platform: Use generic runtime PM callbacks directly") Signed-off-by: Jarkko Nikula Reviewed-by: Yoshihiro Shimoda Acked-by: Wolfram Sang [shimoda: revise git commit description style] Signed-off-by: Yoshihiro Shimoda --- drivers/usb/renesas_usbhs/common.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c index a3e1290..0e760f2 100644 --- a/drivers/usb/renesas_usbhs/common.c +++ b/drivers/usb/renesas_usbhs/common.c @@ -874,23 +874,9 @@ static int usbhsc_resume(struct device *dev) return 0; } -static int usbhsc_runtime_nop(struct device *dev) -{ - /* Runtime PM callback shared between ->runtime_suspend() - * and ->runtime_resume(). Simply returns success. - * - * This driver re-initializes all registers after - * pm_runtime_get_sync() anyway so there is no need - * to save and restore registers here. - */ - return 0; -} - static const struct dev_pm_ops usbhsc_pm_ops = { .suspend = usbhsc_suspend, .resume = usbhsc_resume, - .runtime_suspend = usbhsc_runtime_nop, - .runtime_resume = usbhsc_runtime_nop, }; static struct platform_driver renesas_usbhs_driver = {