From patchwork Wed Nov 21 11:21:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Magnus Damm X-Patchwork-Id: 10692441 X-Patchwork-Delegate: geert@linux-m68k.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 36AA613AD for ; Wed, 21 Nov 2018 11:21:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 238AC2B80C for ; Wed, 21 Nov 2018 11:21:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0E8392B9D8; Wed, 21 Nov 2018 11:21:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A10F22B9D1 for ; Wed, 21 Nov 2018 11:21:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726016AbeKUVzA (ORCPT ); Wed, 21 Nov 2018 16:55:00 -0500 Received: from mail-pl1-f194.google.com ([209.85.214.194]:41429 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730195AbeKUVzA (ORCPT ); Wed, 21 Nov 2018 16:55:00 -0500 Received: by mail-pl1-f194.google.com with SMTP id u6so5111126plm.8; Wed, 21 Nov 2018 03:20:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:date:message-id:in-reply-to:references:subject; bh=+dIGJjafXcdgIe5O9286Yy2klGG05lCXf2qAdSA/rGw=; b=b9iqkinnrHmJw7oVPpiN+7iewtSGzWj7u/g4nB4ScOlOsS8I/8JGg0635caFB9CVQQ 8luI5RoFAUjI5XildFvlviQp/O0Q0yBmk46waWltx7SW1zZmt2b2+eGUQz23aCutqUm5 QeyMOd6HkqwnCxePMhYhfbM/MAnobYmI1lUVNpFQ8lcyx74Gj90/zZVfvfmkeAlw3/wz ZvxySBvOrryvkEPDwxAexjxQ4T7SbEmQFA6/fl/dtJHs9Sv1l6aoFibfCY/ZsCgIaTG6 HvibuTh8I8DK0yvUpMoihdyC6GCiYh3+QoW/nIlqZre1EqmKM74HyLelxT1oeLOT6Org E5+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:date:message-id:in-reply-to :references:subject; bh=+dIGJjafXcdgIe5O9286Yy2klGG05lCXf2qAdSA/rGw=; b=RnXuJxFGEPy/YHTggrrd4GHG2iIlFxIxzF2yvYAIns98b1q/mXtdCocze7OiOv479M 1LuejaxDavrwkb/7MspbExeeNXL21fLvNTvc6PBv1e1hCetIurXI1kTaM74Tjf3tM218 b7ZtBdqnLnBKBxzd2qtdDYMDlK6q6NIj7fKwSrqycm3g9+0lggF6/SKCRaIqrJ2isvc6 VJCpcAoi+EmmU5XYI780p1bIDnROlrmrpe7zmipr0qdB3JIJQU8Jq/sH+Z+ISGv6Vzp3 Hl/HDSwXSUgS30zA/G6a+jq0tC9/VkE8A9oWGd4bR0uaWLtLMLai8Co45WZcScfTBhkz Rdww== X-Gm-Message-State: AA+aEWZquJYDUHB8eneTrOYyibN7rUvXU7gqvqbQOdlaHLZiDbfrTaaS H7P/e2zRyExE8gEk25jWP6sNxwhb X-Google-Smtp-Source: AFSGD/Uth3q/yX56zu44hK2qbMICRA27rpNR/JpDBCI8wBDyZGhOPygSMxESvkQv0kwArzSY6Chsew== X-Received: by 2002:a63:f547:: with SMTP id e7mr5705005pgk.182.1542799259142; Wed, 21 Nov 2018 03:20:59 -0800 (PST) Received: from [127.0.0.1] (l193216.ppp.asahi-net.or.jp. [218.219.193.216]) by smtp.gmail.com with ESMTPSA id 34sm77707028pgp.90.2018.11.21.03.20.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Nov 2018 03:20:58 -0800 (PST) From: Magnus Damm To: netdev@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, Magnus Damm , davem@davemloft.net, sergei.shtylyov@cogentembedded.com Date: Wed, 21 Nov 2018 20:21:17 +0900 Message-Id: <154279927781.10272.2774991326285490398.sendpatchset@octo> In-Reply-To: <154279926877.10272.700833429936129422.sendpatchset@octo> References: <154279926877.10272.700833429936129422.sendpatchset@octo> Subject: [PATCH v3 01/02] ravb: Do not announce HDX as supported Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Magnus Damm According to the data sheet the Ethernet-AVB hardware in R-Car Gen3 and R-Car Gen2 SoCs do not support half duplex operation. So update the driver to mark 100Mbit and 1Gbps HDX as unsupported. Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper") Signed-off-by: Magnus Damm Reviewed-by: Sergei Shtylyov --- Slightly reworked since V2 to make use of phy_remove_link_mode(). In case Sergei wants to opt-out from the Reviewed-by tag for V2 let us know. Applies on top of next-20181121 drivers/net/ethernet/renesas/ravb_main.c | 4 ++++ 1 file changed, 4 insertions(+) --- 0001/drivers/net/ethernet/renesas/ravb_main.c +++ work/drivers/net/ethernet/renesas/ravb_main.c 2018-11-21 19:47:58.165498803 +0900 @@ -1088,6 +1088,10 @@ static int ravb_phy_init(struct net_devi phy_remove_link_mode(phydev, ETHTOOL_LINK_MODE_Pause_BIT); phy_remove_link_mode(phydev, ETHTOOL_LINK_MODE_Asym_Pause_BIT); + /* Half Duplex is not supported */ + phy_remove_link_mode(phydev, ETHTOOL_LINK_MODE_1000baseT_Half_BIT); + phy_remove_link_mode(phydev, ETHTOOL_LINK_MODE_100baseT_Half_BIT); + phy_attached_info(phydev); return 0;