| Message ID | 1544000815-28069-5-git-send-email-biju.das@bp.renesas.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Simon Horman |
| Headers | show |
| Series | Add more support to RZ/G1N | expand |
Hi Biju, On Wed, Dec 5, 2018 at 10:15 AM Biju Das <biju.das@bp.renesas.com> wrote: > The internal LVDS encoder now has DT bindings separate from the DU. > So remove it from du node. > > Fixes: c6a27fa41fab ("drm: rcar-du: Convert LVDS encoder code to bridge driver") > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> Thanks for your patch! > --- > V1-->V2 > * Removed LVDS encoder definition from DU node. Shouldn't you add a new node for the LVDS encoder? > --- > arch/arm/boot/dts/r8a7743.dtsi | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi > index 3cc33f7..3ad1efc 100644 > --- a/arch/arm/boot/dts/r8a7743.dtsi > +++ b/arch/arm/boot/dts/r8a7743.dtsi > @@ -1681,15 +1681,12 @@ > > du: display@feb00000 { > compatible = "renesas,du-r8a7743"; > - reg = <0 0xfeb00000 0 0x40000>, > - <0 0xfeb90000 0 0x1c>; > - reg-names = "du", "lvds.0"; > + reg = <0 0xfeb00000 0 0x40000>; > interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&cpg CPG_MOD 724>, > - <&cpg CPG_MOD 723>, > - <&cpg CPG_MOD 726>; > - clock-names = "du.0", "du.1", "lvds.0"; > + <&cpg CPG_MOD 723>; > + clock-names = "du.0", "du.1"; > status = "disabled"; > > ports { Gr{oetje,eeting}s, Geert
Hi Geert, Thanks for the feedback. > Subject: Re: [PATCH v2 4/5] ARM: dts: r8a7743: Remove LVDS encoder from > du node > > Hi Biju, > > On Wed, Dec 5, 2018 at 10:15 AM Biju Das <biju.das@bp.renesas.com> > wrote: > > The internal LVDS encoder now has DT bindings separate from the DU. > > So remove it from du node. > > > > Fixes: c6a27fa41fab ("drm: rcar-du: Convert LVDS encoder code to > > bridge driver") > > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > Thanks for your patch! > > > --- > > V1-->V2 > > * Removed LVDS encoder definition from DU node. > > Shouldn't you add a new node for the LVDS encoder? Yes for Soc Dtsi , I will add the new node for LVDS encoder. Regards, Biju > > --- > > arch/arm/boot/dts/r8a7743.dtsi | 9 +++------ > > 1 file changed, 3 insertions(+), 6 deletions(-) > > > > diff --git a/arch/arm/boot/dts/r8a7743.dtsi > > b/arch/arm/boot/dts/r8a7743.dtsi index 3cc33f7..3ad1efc 100644 > > --- a/arch/arm/boot/dts/r8a7743.dtsi > > +++ b/arch/arm/boot/dts/r8a7743.dtsi > > @@ -1681,15 +1681,12 @@ > > > > du: display@feb00000 { > > compatible = "renesas,du-r8a7743"; > > - reg = <0 0xfeb00000 0 0x40000>, > > - <0 0xfeb90000 0 0x1c>; > > - reg-names = "du", "lvds.0"; > > + reg = <0 0xfeb00000 0 0x40000>; > > interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>, > > <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>; > > clocks = <&cpg CPG_MOD 724>, > > - <&cpg CPG_MOD 723>, > > - <&cpg CPG_MOD 726>; > > - clock-names = "du.0", "du.1", "lvds.0"; > > + <&cpg CPG_MOD 723>; > > + clock-names = "du.0", "du.1"; > > status = "disabled"; > > > > ports { > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
On Thu, Jan 03, 2019 at 02:34:39PM +0000, Biju Das wrote: > Hi Geert, > > Thanks for the feedback. > > > Subject: Re: [PATCH v2 4/5] ARM: dts: r8a7743: Remove LVDS encoder from > > du node > > > > Hi Biju, > > > > On Wed, Dec 5, 2018 at 10:15 AM Biju Das <biju.das@bp.renesas.com> > > wrote: > > > The internal LVDS encoder now has DT bindings separate from the DU. > > > So remove it from du node. > > > > > > Fixes: c6a27fa41fab ("drm: rcar-du: Convert LVDS encoder code to > > > bridge driver") > > > > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > > > Thanks for your patch! > > > > > --- > > > V1-->V2 > > > * Removed LVDS encoder definition from DU node. > > > > Shouldn't you add a new node for the LVDS encoder? > > Yes for Soc Dtsi , I will add the new node for LVDS encoder. Can I clarify that I should wait for a fresh revision of this and the following patch? > Regards, > Biju > > > --- > > > arch/arm/boot/dts/r8a7743.dtsi | 9 +++------ > > > 1 file changed, 3 insertions(+), 6 deletions(-) > > > > > > diff --git a/arch/arm/boot/dts/r8a7743.dtsi > > > b/arch/arm/boot/dts/r8a7743.dtsi index 3cc33f7..3ad1efc 100644 > > > --- a/arch/arm/boot/dts/r8a7743.dtsi > > > +++ b/arch/arm/boot/dts/r8a7743.dtsi > > > @@ -1681,15 +1681,12 @@ > > > > > > du: display@feb00000 { > > > compatible = "renesas,du-r8a7743"; > > > - reg = <0 0xfeb00000 0 0x40000>, > > > - <0 0xfeb90000 0 0x1c>; > > > - reg-names = "du", "lvds.0"; > > > + reg = <0 0xfeb00000 0 0x40000>; > > > interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>, > > > <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>; > > > clocks = <&cpg CPG_MOD 724>, > > > - <&cpg CPG_MOD 723>, > > > - <&cpg CPG_MOD 726>; > > > - clock-names = "du.0", "du.1", "lvds.0"; > > > + <&cpg CPG_MOD 723>; > > > + clock-names = "du.0", "du.1"; > > > status = "disabled"; > > > > > > ports { > > > > Gr{oetje,eeting}s, > > > > Geert > > > > -- > > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > > m68k.org > > > > In personal conversations with technical people, I call myself a hacker. But > > when I'm talking to journalists I just say "programmer" or something like that. > > -- Linus Torvalds > > > > Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
Hi Simon, Thanks for the feedback. > Subject: Re: [PATCH v2 4/5] ARM: dts: r8a7743: Remove LVDS encoder from > du node > > On Thu, Jan 03, 2019 at 02:34:39PM +0000, Biju Das wrote: > > Hi Geert, > > > > Thanks for the feedback. > > > > > Subject: Re: [PATCH v2 4/5] ARM: dts: r8a7743: Remove LVDS encoder > > > from du node > > > > > > Hi Biju, > > > > > > On Wed, Dec 5, 2018 at 10:15 AM Biju Das <biju.das@bp.renesas.com> > > > wrote: > > > > The internal LVDS encoder now has DT bindings separate from the DU. > > > > So remove it from du node. > > > > > > > > Fixes: c6a27fa41fab ("drm: rcar-du: Convert LVDS encoder code to > > > > bridge driver") > > > > > > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > > > > > Thanks for your patch! > > > > > > > --- > > > > V1-->V2 > > > > * Removed LVDS encoder definition from DU node. > > > > > > Shouldn't you add a new node for the LVDS encoder? > > > > Yes for Soc Dtsi , I will add the new node for LVDS encoder. > > Can I clarify that I should wait for a fresh revision of this and the following > patch? My original plan was to submit LVDS encoder patch as separate one. But now we are agreeing for adding LVDS encoder node as part of the fix (Fixes: c6a27fa41fab ("drm: rcar-du: Convert LVDS encoder code to bridge driver") So I will send V3 with this change. Regards, Biju > > > > --- > > > > arch/arm/boot/dts/r8a7743.dtsi | 9 +++------ > > > > 1 file changed, 3 insertions(+), 6 deletions(-) > > > > > > > > diff --git a/arch/arm/boot/dts/r8a7743.dtsi > > > > b/arch/arm/boot/dts/r8a7743.dtsi index 3cc33f7..3ad1efc 100644 > > > > --- a/arch/arm/boot/dts/r8a7743.dtsi > > > > +++ b/arch/arm/boot/dts/r8a7743.dtsi > > > > @@ -1681,15 +1681,12 @@ > > > > > > > > du: display@feb00000 { > > > > compatible = "renesas,du-r8a7743"; > > > > - reg = <0 0xfeb00000 0 0x40000>, > > > > - <0 0xfeb90000 0 0x1c>; > > > > - reg-names = "du", "lvds.0"; > > > > + reg = <0 0xfeb00000 0 0x40000>; > > > > interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>, > > > > <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>; > > > > clocks = <&cpg CPG_MOD 724>, > > > > - <&cpg CPG_MOD 723>, > > > > - <&cpg CPG_MOD 726>; > > > > - clock-names = "du.0", "du.1", "lvds.0"; > > > > + <&cpg CPG_MOD 723>; > > > > + clock-names = "du.0", "du.1"; > > > > status = "disabled"; > > > > > > > > ports { > > > > > > Gr{oetje,eeting}s, > > > > > > Geert > > > > > > -- > > > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- > > > geert@linux- m68k.org > > > > > > In personal conversations with technical people, I call myself a > > > hacker. But when I'm talking to journalists I just say "programmer" or > something like that. > > > -- Linus Torvalds > > > > > > > > Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne > End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under > Registered No. 04586709. Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
On Fri, Jan 04, 2019 at 10:02:02AM +0000, Biju Das wrote: > Hi Simon, > > Thanks for the feedback. > > > Subject: Re: [PATCH v2 4/5] ARM: dts: r8a7743: Remove LVDS encoder from > > du node > > > > On Thu, Jan 03, 2019 at 02:34:39PM +0000, Biju Das wrote: > > > Hi Geert, > > > > > > Thanks for the feedback. > > > > > > > Subject: Re: [PATCH v2 4/5] ARM: dts: r8a7743: Remove LVDS encoder > > > > from du node > > > > > > > > Hi Biju, > > > > > > > > On Wed, Dec 5, 2018 at 10:15 AM Biju Das <biju.das@bp.renesas.com> > > > > wrote: > > > > > The internal LVDS encoder now has DT bindings separate from the DU. > > > > > So remove it from du node. > > > > > > > > > > Fixes: c6a27fa41fab ("drm: rcar-du: Convert LVDS encoder code to > > > > > bridge driver") > > > > > > > > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > > > > > > > Thanks for your patch! > > > > > > > > > --- > > > > > V1-->V2 > > > > > * Removed LVDS encoder definition from DU node. > > > > > > > > Shouldn't you add a new node for the LVDS encoder? > > > > > > Yes for Soc Dtsi , I will add the new node for LVDS encoder. > > > > Can I clarify that I should wait for a fresh revision of this and the following > > patch? > > My original plan was to submit LVDS encoder patch as separate one. > > But now we are agreeing for adding LVDS encoder node as part of the fix (Fixes: c6a27fa41fab ("drm: rcar-du: Convert LVDS encoder code to bridge driver") > So I will send V3 with this change. Great, thanks!
diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi index 3cc33f7..3ad1efc 100644 --- a/arch/arm/boot/dts/r8a7743.dtsi +++ b/arch/arm/boot/dts/r8a7743.dtsi @@ -1681,15 +1681,12 @@ du: display@feb00000 { compatible = "renesas,du-r8a7743"; - reg = <0 0xfeb00000 0 0x40000>, - <0 0xfeb90000 0 0x1c>; - reg-names = "du", "lvds.0"; + reg = <0 0xfeb00000 0 0x40000>; interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>; clocks = <&cpg CPG_MOD 724>, - <&cpg CPG_MOD 723>, - <&cpg CPG_MOD 726>; - clock-names = "du.0", "du.1", "lvds.0"; + <&cpg CPG_MOD 723>; + clock-names = "du.0", "du.1"; status = "disabled"; ports {
The internal LVDS encoder now has DT bindings separate from the DU. So remove it from du node. Fixes: c6a27fa41fab ("drm: rcar-du: Convert LVDS encoder code to bridge driver") Signed-off-by: Biju Das <biju.das@bp.renesas.com> --- V1-->V2 * Removed LVDS encoder definition from DU node. --- arch/arm/boot/dts/r8a7743.dtsi | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)