| Message ID | 1544086559-47141-5-git-send-email-biju.das@bp.renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Simon Horman |
| Headers | show |
| Series | Add NXP pcf85263 real-time clock support | expand |
Hi Biju, On Thu, Dec 6, 2018 at 10:04 AM Biju Das <biju.das@bp.renesas.com> wrote: > Enable NXP pcf85263 real time clock for the iWave SBC based on RZ/G1C. > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts > +++ b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts > @@ -84,12 +84,30 @@ > clock-frequency = <20000000>; > }; > > +&i2c3 { > + pinctrl-0 = <&i2c3_pins>; > + pinctrl-names = "default"; > + > + status = "okay"; > + clock-frequency = <400000>; > + > + rtc@51 { > + compatible = "nxp,pcf85263"; > + reg = <0x51>; You might want to enable the optional interrupt: interrupt-parent = <&gpio0>; interrupts = <2 IRQ_TYPE_LEVEL_LOW>; > + }; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert, Thanks for the feedback. > Subject: Re: [PATCH v3 4/4] ARM: dts: iwg23s-sbc: Enable RTC > > Hi Biju, > > On Thu, Dec 6, 2018 at 10:04 AM Biju Das <biju.das@bp.renesas.com> wrote: > > Enable NXP pcf85263 real time clock for the iWave SBC based on RZ/G1C. > > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > --- a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts > > +++ b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts > > @@ -84,12 +84,30 @@ > > clock-frequency = <20000000>; > > }; > > > > +&i2c3 { > > + pinctrl-0 = <&i2c3_pins>; > > + pinctrl-names = "default"; > > + > > + status = "okay"; > > + clock-frequency = <400000>; > > + > > + rtc@51 { > > + compatible = "nxp,pcf85263"; > > + reg = <0x51>; > > You might want to enable the optional interrupt: I have enabled this but unfortunately it is generating 100000 of gpio interrupts during boot. The reason is, by default this pin is configured as function(Power on reset/at u-boot). Currently there is no function available in kernel to convert a pin from function to gpio (Similar to the issue Fab is facing for display hot plug interrupt) May be we can add optional interrupt at a later stage, once we have a solution for converting pin from function to gpio. Please share your opinion on this. Regards, Biju [https://www2.renesas.eu/media/email/unicef.jpg] This Christmas, instead of sending out cards, Renesas Electronics Europe have decided to support Unicef with a donation. For further details click here<https://www.unicef.org/> to find out about the valuable work they do, helping children all over the world. We would like to take this opportunity to wish you a Merry Christmas and a prosperous New Year. Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
Hi Biju, On Thu, Dec 6, 2018 at 1:41 PM Biju Das <biju.das@bp.renesas.com> wrote: > > Subject: Re: [PATCH v3 4/4] ARM: dts: iwg23s-sbc: Enable RTC > > On Thu, Dec 6, 2018 at 10:04 AM Biju Das <biju.das@bp.renesas.com> wrote: > > > Enable NXP pcf85263 real time clock for the iWave SBC based on RZ/G1C. > > > > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > > --- a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts > > > +++ b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts > > > @@ -84,12 +84,30 @@ > > > clock-frequency = <20000000>; > > > }; > > > > > > +&i2c3 { > > > + pinctrl-0 = <&i2c3_pins>; > > > + pinctrl-names = "default"; > > > + > > > + status = "okay"; > > > + clock-frequency = <400000>; > > > + > > > + rtc@51 { > > > + compatible = "nxp,pcf85263"; > > > + reg = <0x51>; > > > > You might want to enable the optional interrupt: > > I have enabled this but unfortunately it is generating 100000 of gpio interrupts during boot. Oh, the DT bindings claim interrupt support hasn't been implement yet ;-) > The reason is, by default this pin is configured as function(Power on reset/at u-boot). > Currently there is no function available in kernel to convert a pin from function to gpio (Similar to the issue Fab is facing for display hot plug interrupt) > > May be we can add optional interrupt at a later stage, once we have a solution for converting pin from function to gpio. > > Please share your opinion on this. IC. In that case, please postpone describing the interrupt until the issue is fixed. Gr{oetje,eeting}s, Geert
On Thu, Dec 06, 2018 at 01:59:58PM +0100, Geert Uytterhoeven wrote: > Hi Biju, > > On Thu, Dec 6, 2018 at 1:41 PM Biju Das <biju.das@bp.renesas.com> wrote: > > > Subject: Re: [PATCH v3 4/4] ARM: dts: iwg23s-sbc: Enable RTC > > > > On Thu, Dec 6, 2018 at 10:04 AM Biju Das <biju.das@bp.renesas.com> wrote: > > > > Enable NXP pcf85263 real time clock for the iWave SBC based on RZ/G1C. > > > > > > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > > > > --- a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts > > > > +++ b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts > > > > @@ -84,12 +84,30 @@ > > > > clock-frequency = <20000000>; > > > > }; > > > > > > > > +&i2c3 { > > > > + pinctrl-0 = <&i2c3_pins>; > > > > + pinctrl-names = "default"; > > > > + > > > > + status = "okay"; > > > > + clock-frequency = <400000>; > > > > + > > > > + rtc@51 { > > > > + compatible = "nxp,pcf85263"; > > > > + reg = <0x51>; > > > > > > You might want to enable the optional interrupt: > > > > I have enabled this but unfortunately it is generating 100000 of gpio interrupts during boot. > > Oh, the DT bindings claim interrupt support hasn't been implement yet ;-) > > > The reason is, by default this pin is configured as function(Power on reset/at u-boot). > > Currently there is no function available in kernel to convert a pin from function to gpio (Similar to the issue Fab is facing for display hot plug interrupt) > > > > May be we can add optional interrupt at a later stage, once we have a solution for converting pin from function to gpio. > > > > Please share your opinion on this. > > IC. In that case, please postpone describing the interrupt until the issue is > fixed. It feels like this patch is ready to be accepted. Geert, do you concur?
Hi Simon, On Mon, Dec 10, 2018 at 12:52 PM Simon Horman <horms@verge.net.au> wrote: > On Thu, Dec 06, 2018 at 01:59:58PM +0100, Geert Uytterhoeven wrote: > > On Thu, Dec 6, 2018 at 1:41 PM Biju Das <biju.das@bp.renesas.com> wrote: > > > > Subject: Re: [PATCH v3 4/4] ARM: dts: iwg23s-sbc: Enable RTC > > > > > > On Thu, Dec 6, 2018 at 10:04 AM Biju Das <biju.das@bp.renesas.com> wrote: > > > > > Enable NXP pcf85263 real time clock for the iWave SBC based on RZ/G1C. > > > > > > > > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > > > > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > > > > > > --- a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts > > > > > +++ b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts > > > > > @@ -84,12 +84,30 @@ > > > > > clock-frequency = <20000000>; > > > > > }; > > > > > > > > > > +&i2c3 { > > > > > + pinctrl-0 = <&i2c3_pins>; > > > > > + pinctrl-names = "default"; > > > > > + > > > > > + status = "okay"; > > > > > + clock-frequency = <400000>; > > > > > + > > > > > + rtc@51 { > > > > > + compatible = "nxp,pcf85263"; > > > > > + reg = <0x51>; > > > > > > > > You might want to enable the optional interrupt: > > > > > > I have enabled this but unfortunately it is generating 100000 of gpio interrupts during boot. > > > > Oh, the DT bindings claim interrupt support hasn't been implement yet ;-) > > > > > The reason is, by default this pin is configured as function(Power on reset/at u-boot). > > > Currently there is no function available in kernel to convert a pin from function to gpio (Similar to the issue Fab is facing for display hot plug interrupt) > > > > > > May be we can add optional interrupt at a later stage, once we have a solution for converting pin from function to gpio. > > > > > > Please share your opinion on this. > > > > IC. In that case, please postpone describing the interrupt until the issue is > > fixed. > > It feels like this patch is ready to be accepted. > Geert, do you concur? Yes, I agree. Gr{oetje,eeting}s, Geert
On Mon, Dec 10, 2018 at 12:56:11PM +0100, Geert Uytterhoeven wrote: > Hi Simon, > > On Mon, Dec 10, 2018 at 12:52 PM Simon Horman <horms@verge.net.au> wrote: > > On Thu, Dec 06, 2018 at 01:59:58PM +0100, Geert Uytterhoeven wrote: > > > On Thu, Dec 6, 2018 at 1:41 PM Biju Das <biju.das@bp.renesas.com> wrote: > > > > > Subject: Re: [PATCH v3 4/4] ARM: dts: iwg23s-sbc: Enable RTC > > > > > > > > On Thu, Dec 6, 2018 at 10:04 AM Biju Das <biju.das@bp.renesas.com> wrote: > > > > > > Enable NXP pcf85263 real time clock for the iWave SBC based on RZ/G1C. > > > > > > > > > > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > > > > > > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > > > > > > > > --- a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts > > > > > > +++ b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts > > > > > > @@ -84,12 +84,30 @@ > > > > > > clock-frequency = <20000000>; > > > > > > }; > > > > > > > > > > > > +&i2c3 { > > > > > > + pinctrl-0 = <&i2c3_pins>; > > > > > > + pinctrl-names = "default"; > > > > > > + > > > > > > + status = "okay"; > > > > > > + clock-frequency = <400000>; > > > > > > + > > > > > > + rtc@51 { > > > > > > + compatible = "nxp,pcf85263"; > > > > > > + reg = <0x51>; > > > > > > > > > > You might want to enable the optional interrupt: > > > > > > > > I have enabled this but unfortunately it is generating 100000 of gpio interrupts during boot. > > > > > > Oh, the DT bindings claim interrupt support hasn't been implement yet ;-) > > > > > > > The reason is, by default this pin is configured as function(Power on reset/at u-boot). > > > > Currently there is no function available in kernel to convert a pin from function to gpio (Similar to the issue Fab is facing for display hot plug interrupt) > > > > > > > > May be we can add optional interrupt at a later stage, once we have a solution for converting pin from function to gpio. > > > > > > > > Please share your opinion on this. > > > > > > IC. In that case, please postpone describing the interrupt until the issue is > > > fixed. > > > > It feels like this patch is ready to be accepted. > > Geert, do you concur? > > Yes, I agree. Thanks, I have applied v4 (which is the same as v3).
diff --git a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts index 40b7f98..77d1824 100644 --- a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts +++ b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts @@ -84,12 +84,30 @@ clock-frequency = <20000000>; }; +&i2c3 { + pinctrl-0 = <&i2c3_pins>; + pinctrl-names = "default"; + + status = "okay"; + clock-frequency = <400000>; + + rtc@51 { + compatible = "nxp,pcf85263"; + reg = <0x51>; + }; +}; + &pfc { avb_pins: avb { groups = "avb_mdio", "avb_gmii_tx_rx"; function = "avb"; }; + i2c3_pins: i2c3 { + groups = "i2c3_c"; + function = "i2c3"; + }; + mmc_pins_uhs: mmc_uhs { groups = "mmc_data8", "mmc_ctrl"; function = "mmc";
Enable NXP pcf85263 real time clock for the iWave SBC based on RZ/G1C. Signed-off-by: Biju Das <biju.das@bp.renesas.com> --- V1-->V2 * No change V2-->V3 * No change --- arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)