| Message ID | 1544443077-49827-1-git-send-email-biju.das@bp.renesas.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 072b817589b17660ef19c31d89f7b981dbed3fd2 |
| Headers | show |
| Series | ARM: dts: r8a7743: Remove generic compatible string from iic3 | expand |
Hi Biju, On Mon, Dec 10, 2018 at 1:06 PM Biju Das <biju.das@bp.renesas.com> wrote: > The iic3 block on RZ/G1M does not support automatic transmission, unlike > other R-Car SoC's. So dropping the compatibility with the generic version. > > Fixes: f523405f2a22cc0c307 ("ARM: dts: r8a7743: Add IIC cores to dtsi") Thanks for going through the other affected SoCs! > Signed-off-by: Biju Das <biju.das@bp.renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- a/arch/arm/boot/dts/r8a7743.dtsi > +++ b/arch/arm/boot/dts/r8a7743.dtsi > @@ -564,9 +564,7 @@ > /* doesn't need pinmux */ > #address-cells = <1>; > #size-cells = <0>; > - compatible = "renesas,iic-r8a7743", > - "renesas,rcar-gen2-iic", > - "renesas,rmobile-iic"; > + compatible = "renesas,iic-r8a7743"; > reg = <0 0xe60b0000 0 0x425>; > interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&cpg CPG_MOD 926>; Note that this is still a bit odd, as there are other iic nodes that do declare compatibility with the generic version, as they do support automatic transmission. But at least we'll have an easier job to support this in the driver[*], if ever needed. [*] The code handling r8a7743 (and r8a7744) can call of_device_is_compatible() to find out if the instance is compatible with the generic version. Gr{oetje,eeting}s, Geert
Hello Geert, > Subject: Re: [PATCH] ARM: dts: r8a7743: Remove generic compatible string > from iic3 > > Hi Biju, > > On Mon, Dec 10, 2018 at 1:06 PM Biju Das <biju.das@bp.renesas.com> > wrote: > > The iic3 block on RZ/G1M does not support automatic transmission, > > unlike other R-Car SoC's. So dropping the compatibility with the generic > version. > > > > Fixes: f523405f2a22cc0c307 ("ARM: dts: r8a7743: Add IIC cores to > > dtsi") > > Thanks for going through the other affected SoCs! > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > --- a/arch/arm/boot/dts/r8a7743.dtsi > > +++ b/arch/arm/boot/dts/r8a7743.dtsi > > @@ -564,9 +564,7 @@ > Note that this is still a bit odd, as there are other iic nodes that do declare > compatibility with the generic version, as they do support automatic > transmission. But at least we'll have an easier job to support this in the > driver[*], if ever needed. > > [*] The code handling r8a7743 (and r8a7744) can call > of_device_is_compatible() > to find out if the instance is compatible with the generic version. Thanks . Regards, Biju [https://www2.renesas.eu/media/email/unicef.jpg] This Christmas, instead of sending out cards, Renesas Electronics Europe have decided to support Unicef with a donation. For further details click here<https://www.unicef.org/> to find out about the valuable work they do, helping children all over the world. We would like to take this opportunity to wish you a Merry Christmas and a prosperous New Year. Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
On Mon, Dec 10, 2018 at 01:13:53PM +0100, Geert Uytterhoeven wrote: > Hi Biju, > > On Mon, Dec 10, 2018 at 1:06 PM Biju Das <biju.das@bp.renesas.com> wrote: > > The iic3 block on RZ/G1M does not support automatic transmission, unlike > > other R-Car SoC's. So dropping the compatibility with the generic version. > > > > Fixes: f523405f2a22cc0c307 ("ARM: dts: r8a7743: Add IIC cores to dtsi") > > Thanks for going through the other affected SoCs! > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Thanks, applied for v4.22. > > --- a/arch/arm/boot/dts/r8a7743.dtsi > > +++ b/arch/arm/boot/dts/r8a7743.dtsi > > @@ -564,9 +564,7 @@ > > /* doesn't need pinmux */ > > #address-cells = <1>; > > #size-cells = <0>; > > - compatible = "renesas,iic-r8a7743", > > - "renesas,rcar-gen2-iic", > > - "renesas,rmobile-iic"; > > + compatible = "renesas,iic-r8a7743"; > > reg = <0 0xe60b0000 0 0x425>; > > interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>; > > clocks = <&cpg CPG_MOD 926>; > > Note that this is still a bit odd, as there are other iic nodes that do declare > compatibility with the generic version, as they do support automatic > transmission. But at least we'll have an easier job to support this in the > driver[*], if ever needed. > > [*] The code handling r8a7743 (and r8a7744) can call of_device_is_compatible() > to find out if the instance is compatible with the generic version. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds >
diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi index 7b731c7..182464d 100644 --- a/arch/arm/boot/dts/r8a7743.dtsi +++ b/arch/arm/boot/dts/r8a7743.dtsi @@ -564,9 +564,7 @@ /* doesn't need pinmux */ #address-cells = <1>; #size-cells = <0>; - compatible = "renesas,iic-r8a7743", - "renesas,rcar-gen2-iic", - "renesas,rmobile-iic"; + compatible = "renesas,iic-r8a7743"; reg = <0 0xe60b0000 0 0x425>; interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>; clocks = <&cpg CPG_MOD 926>;
The iic3 block on RZ/G1M does not support automatic transmission, unlike other R-Car SoC's. So dropping the compatibility with the generic version. Fixes: f523405f2a22cc0c307 ("ARM: dts: r8a7743: Add IIC cores to dtsi") Signed-off-by: Biju Das <biju.das@bp.renesas.com> --- arch/arm/boot/dts/r8a7743.dtsi | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)