| Message ID | 1544732500-6866-1-git-send-email-fabrizio.castro@bp.renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | dt-bindings: PCI: rcar: Add device tree support for r8a774c0 | expand |
Hi Fabrizio, On Thu, Dec 13, 2018 at 9:21 PM Fabrizio Castro <fabrizio.castro@bp.renesas.com> wrote: > Add PCIe support for the RZ/G2E (a.k.a. R8A774C0). > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> One question below. > --- a/Documentation/devicetree/bindings/pci/rcar-pci.txt > +++ b/Documentation/devicetree/bindings/pci/rcar-pci.txt > @@ -37,7 +39,8 @@ compatible: "renesas,pcie-r8a7743" for the R8A7743 SoC; > > Optional properties: > - phys: from common PHY binding: PHY phandle and specifier (only make sense > - for R-Car gen3 SoCs where the PCIe PHYs have their own register blocks). > + for R-Car gen3 and RZ/G2 SoCs where the PCIe PHYs have their own Gen3, while at it? > + register blocks). The RZ/G2 Hardware User Manual I have lacks the table specifying which SoCs have which PHY registers. So I cannot verify if the above paragraph applies to RZ/G2(E). Gr{oetje,eeting}s, Geert
Hello Geert, Thank you for your feedback! > From: Geert Uytterhoeven <geert@linux-m68k.org> > Sent: 14 December 2018 10:29 > Subject: Re: [PATCH] dt-bindings: PCI: rcar: Add device tree support for r8a774c0 > > Hi Fabrizio, > > On Thu, Dec 13, 2018 at 9:21 PM Fabrizio Castro > <fabrizio.castro@bp.renesas.com> wrote: > > Add PCIe support for the RZ/G2E (a.k.a. R8A774C0). > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > One question below. > > > --- a/Documentation/devicetree/bindings/pci/rcar-pci.txt > > +++ b/Documentation/devicetree/bindings/pci/rcar-pci.txt > > > @@ -37,7 +39,8 @@ compatible: "renesas,pcie-r8a7743" for the R8A7743 SoC; > > > > Optional properties: > > - phys: from common PHY binding: PHY phandle and specifier (only make sense > > - for R-Car gen3 SoCs where the PCIe PHYs have their own register blocks). > > + for R-Car gen3 and RZ/G2 SoCs where the PCIe PHYs have their own > > Gen3, while at it? Can do > > > + register blocks). > > The RZ/G2 Hardware User Manual I have lacks the table specifying which SoCs > have which PHY registers. So I cannot verify if the above paragraph applies to > RZ/G2(E). I'll reply to this on your follow-up email. Thanks, Fab > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds [https://www2.renesas.eu/media/email/unicef.jpg] This Christmas, instead of sending out cards, Renesas Electronics Europe have decided to support Unicef with a donation. For further details click here<https://www.unicef.org/> to find out about the valuable work they do, helping children all over the world. We would like to take this opportunity to wish you a Merry Christmas and a prosperous New Year. Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
diff --git a/Documentation/devicetree/bindings/pci/rcar-pci.txt b/Documentation/devicetree/bindings/pci/rcar-pci.txt index 976ef7b..bb89fed 100644 --- a/Documentation/devicetree/bindings/pci/rcar-pci.txt +++ b/Documentation/devicetree/bindings/pci/rcar-pci.txt @@ -3,6 +3,7 @@ Required properties: compatible: "renesas,pcie-r8a7743" for the R8A7743 SoC; "renesas,pcie-r8a7744" for the R8A7744 SoC; + "renesas,pcie-r8a774c0" for the R8A774C0 SoC; "renesas,pcie-r8a7779" for the R8A7779 SoC; "renesas,pcie-r8a7790" for the R8A7790 SoC; "renesas,pcie-r8a7791" for the R8A7791 SoC; @@ -13,7 +14,8 @@ compatible: "renesas,pcie-r8a7743" for the R8A7743 SoC; "renesas,pcie-r8a77990" for the R8A77990 SoC; "renesas,pcie-rcar-gen2" for a generic R-Car Gen2 or RZ/G1 compatible device. - "renesas,pcie-rcar-gen3" for a generic R-Car Gen3 compatible device. + "renesas,pcie-rcar-gen3" for a generic R-Car Gen3 or + RZ/G2 compatible device. When compatible with the generic version, nodes must list the SoC-specific version corresponding to the platform first @@ -37,7 +39,8 @@ compatible: "renesas,pcie-r8a7743" for the R8A7743 SoC; Optional properties: - phys: from common PHY binding: PHY phandle and specifier (only make sense - for R-Car gen3 SoCs where the PCIe PHYs have their own register blocks). + for R-Car gen3 and RZ/G2 SoCs where the PCIe PHYs have their own + register blocks). - phy-names: from common PHY binding: should be "pcie". Example:
Add PCIe support for the RZ/G2E (a.k.a. R8A774C0). Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> --- Documentation/devicetree/bindings/pci/rcar-pci.txt | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)