| Message ID | 1559621375-5436-2-git-send-email-yoshihiro.shimoda.uh@renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | usb: renesas_usbhs: remove unused features | expand |
Hello! On 04.06.2019 7:09, Yoshihiro Shimoda wrote: > SUDMAC featurer was supported in v3.10, but was never used by Feature? > any platform. So, this patch removes it. > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> [...] MBR, Sergei
On Tue, Jun 4, 2019 at 6:14 AM Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> wrote: > SUDMAC featurer was supported in v3.10, but was never used by > any platform. So, this patch removes it. > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Shimoda-san, On Tue, Jun 04, 2019 at 01:09:34PM +0900, Yoshihiro Shimoda wrote: > SUDMAC featurer was supported in v3.10, but was never used by > any platform. So, this patch removes it. > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > --- > drivers/usb/renesas_usbhs/fifo.c | 5 +---- > include/linux/usb/renesas_usbhs.h | 1 - > 2 files changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/usb/renesas_usbhs/fifo.c b/drivers/usb/renesas_usbhs/fifo.c > index 452b456..53f8e2f 100644 > --- a/drivers/usb/renesas_usbhs/fifo.c > +++ b/drivers/usb/renesas_usbhs/fifo.c > @@ -325,10 +325,7 @@ static int usbhsf_fifo_select(struct usbhs_pipe *pipe, > } > > /* "base" will be used below */ > - if (usbhs_get_dparam(priv, has_sudmac) && !usbhsf_is_cfifo(priv, fifo)) I believe usbhsf_is_cfifo() will now be unused and should be removed. With that change feel free to add: Reviewed-by: Simon Horman <horms+renesas@verge.net.au> > - usbhs_write(priv, fifo->sel, base); > - else > - usbhs_write(priv, fifo->sel, base | MBW_32); > + usbhs_write(priv, fifo->sel, base | MBW_32); > > /* check ISEL and CURPIPE value */ > while (timeout--) { > diff --git a/include/linux/usb/renesas_usbhs.h b/include/linux/usb/renesas_usbhs.h > index 3f53043..a2481f4d 100644 > --- a/include/linux/usb/renesas_usbhs.h > +++ b/include/linux/usb/renesas_usbhs.h > @@ -187,7 +187,6 @@ struct renesas_usbhs_driver_param { > * option: > */ > u32 has_otg:1; /* for controlling PWEN/EXTLP */ > - u32 has_sudmac:1; /* for SUDMAC */ > u32 has_usb_dmac:1; /* for USB-DMAC */ > u32 runtime_pwctrl:1; > u32 has_cnen:1; > -- > 2.7.4 >
Hello! > From: Sergei Shtylyov, Sent: Tuesday, June 4, 2019 5:06 PM > > Hello! > > On 04.06.2019 7:09, Yoshihiro Shimoda wrote: > > > SUDMAC featurer was supported in v3.10, but was never used by > > Feature? Oops! I'll revise it on v2. Best regards, Yoshihiro Shimoda
Hi Simon-san, > From: Simon Horman, Sent: Tuesday, June 4, 2019 6:36 PM > > Hi Shimoda-san, > > On Tue, Jun 04, 2019 at 01:09:34PM +0900, Yoshihiro Shimoda wrote: > > SUDMAC featurer was supported in v3.10, but was never used by > > any platform. So, this patch removes it. > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > --- > > drivers/usb/renesas_usbhs/fifo.c | 5 +---- > > include/linux/usb/renesas_usbhs.h | 1 - > > 2 files changed, 1 insertion(+), 5 deletions(-) > > > > diff --git a/drivers/usb/renesas_usbhs/fifo.c b/drivers/usb/renesas_usbhs/fifo.c > > index 452b456..53f8e2f 100644 > > --- a/drivers/usb/renesas_usbhs/fifo.c > > +++ b/drivers/usb/renesas_usbhs/fifo.c > > @@ -325,10 +325,7 @@ static int usbhsf_fifo_select(struct usbhs_pipe *pipe, > > } > > > > /* "base" will be used below */ > > - if (usbhs_get_dparam(priv, has_sudmac) && !usbhsf_is_cfifo(priv, fifo)) > > I believe usbhsf_is_cfifo() will now be unused and should be removed. Good catch! I'll remove the macro on v2. > With that change feel free to add: > > Reviewed-by: Simon Horman <horms+renesas@verge.net.au> Thank you for your review! Best regards, Yoshihiro Shimoda
diff --git a/drivers/usb/renesas_usbhs/fifo.c b/drivers/usb/renesas_usbhs/fifo.c index 452b456..53f8e2f 100644 --- a/drivers/usb/renesas_usbhs/fifo.c +++ b/drivers/usb/renesas_usbhs/fifo.c @@ -325,10 +325,7 @@ static int usbhsf_fifo_select(struct usbhs_pipe *pipe, } /* "base" will be used below */ - if (usbhs_get_dparam(priv, has_sudmac) && !usbhsf_is_cfifo(priv, fifo)) - usbhs_write(priv, fifo->sel, base); - else - usbhs_write(priv, fifo->sel, base | MBW_32); + usbhs_write(priv, fifo->sel, base | MBW_32); /* check ISEL and CURPIPE value */ while (timeout--) { diff --git a/include/linux/usb/renesas_usbhs.h b/include/linux/usb/renesas_usbhs.h index 3f53043..a2481f4d 100644 --- a/include/linux/usb/renesas_usbhs.h +++ b/include/linux/usb/renesas_usbhs.h @@ -187,7 +187,6 @@ struct renesas_usbhs_driver_param { * option: */ u32 has_otg:1; /* for controlling PWEN/EXTLP */ - u32 has_sudmac:1; /* for SUDMAC */ u32 has_usb_dmac:1; /* for USB-DMAC */ u32 runtime_pwctrl:1; u32 has_cnen:1;
SUDMAC featurer was supported in v3.10, but was never used by any platform. So, this patch removes it. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- drivers/usb/renesas_usbhs/fifo.c | 5 +---- include/linux/usb/renesas_usbhs.h | 1 - 2 files changed, 1 insertion(+), 5 deletions(-)