| Message ID | 1562333979-28516-4-git-send-email-fabrizio.castro@bp.renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | Add HDMI audio support to the HiHope RZ/G2[MN] | expand |
On Fri, Jul 05, 2019 at 02:39:39PM +0100, Fabrizio Castro wrote: > This patch adds support for HDMI audio to the device tree > common to the HiHope RZ/G2M and the HiHope RZ/G2N. > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Hi Fabrizio, On Fri, Jul 5, 2019 at 3:40 PM Fabrizio Castro <fabrizio.castro@bp.renesas.com> wrote: > This patch adds support for HDMI audio to the device tree > common to the HiHope RZ/G2M and the HiHope RZ/G2N. > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> Thanks for your patch! > --- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi > +++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi > @@ -168,6 +180,7 @@ > > &hdmi0 { > status = "okay"; > + #sound-dai-cells = <0>; Why the above line? With the above question answered: Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
Hi Geert, Thank you for your feedback! > From: Geert Uytterhoeven <geert@linux-m68k.org> > Sent: 12 July 2019 14:42 > Subject: Re: [PATCH 3/3] arm64: dts: renesas: hihope-common: Add HDMI audio support > > Hi Fabrizio, > > On Fri, Jul 5, 2019 at 3:40 PM Fabrizio Castro > <fabrizio.castro@bp.renesas.com> wrote: > > This patch adds support for HDMI audio to the device tree > > common to the HiHope RZ/G2M and the HiHope RZ/G2N. > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > Thanks for your patch! > > > --- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi > > +++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi > > > @@ -168,6 +180,7 @@ > > > > &hdmi0 { > > status = "okay"; > > + #sound-dai-cells = <0>; > > Why the above line? It doesn't belong there, good catch, I'll send a v2 shortly without it. Thanks, Fab > > With the above question answered: > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
diff --git a/arch/arm64/boot/dts/renesas/hihope-common.dtsi b/arch/arm64/boot/dts/renesas/hihope-common.dtsi index 52d61c9..67f22ce 100644 --- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi +++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi @@ -81,6 +81,14 @@ regulator-always-on; }; + sound_card: sound { + compatible = "audio-graph-card"; + + label = "rcar-sound"; + + dais = <&rsnd_port0>; + }; + vbus0_usb2: regulator-vbus0-usb2 { compatible = "regulator-fixed"; @@ -129,6 +137,10 @@ }; }; +&audio_clk_a { + clock-frequency = <22579200>; +}; + &du { clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>, @@ -168,6 +180,7 @@ &hdmi0 { status = "okay"; + #sound-dai-cells = <0>; ports { port@1 { @@ -176,6 +189,12 @@ remote-endpoint = <&hdmi0_con>; }; }; + port@2 { + reg = <2>; + dw_hdmi0_snd_in: endpoint { + remote-endpoint = <&rsnd_endpoint0>; + }; + }; }; }; @@ -272,6 +291,11 @@ power-source = <1800>; }; + sound_clk_pins: sound_clk { + groups = "audio_clk_a_a"; + function = "audio_clk"; + }; + usb0_pins: usb0 { groups = "usb0"; function = "usb0"; @@ -295,6 +319,30 @@ }; }; +&rcar_sound { + pinctrl-0 = <&sound_clk_pins>; + pinctrl-names = "default"; + + status = "okay"; + + /* Single DAI */ + #sound-dai-cells = <0>; + + ports { + rsnd_port0: port@0 { + rsnd_endpoint0: endpoint { + remote-endpoint = <&dw_hdmi0_snd_in>; + + dai-format = "i2s"; + bitclock-master = <&rsnd_endpoint0>; + frame-master = <&rsnd_endpoint0>; + + playback = <&ssi2>; + }; + }; + }; +}; + &rwdt { timeout-sec = <60>; status = "okay";
This patch adds support for HDMI audio to the device tree common to the HiHope RZ/G2M and the HiHope RZ/G2N. Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> --- arch/arm64/boot/dts/renesas/hihope-common.dtsi | 48 ++++++++++++++++++++++++++ 1 file changed, 48 insertions(+)