| Message ID | 1588197415-13747-5-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | Add R8A7742/RZG1H board support | expand |
On Wed, Apr 29, 2020 at 10:56:41PM +0100, Lad Prabhakar wrote: > @@ -1701,6 +1709,7 @@ config DEBUG_UART_PHYS > default 0xe6e60000 if DEBUG_RCAR_GEN2_SCIF0 > default 0xe6e68000 if DEBUG_RCAR_GEN2_SCIF1 > default 0xe6ee0000 if DEBUG_RCAR_GEN2_SCIF4 > + default 0xe6c60000 if DEBUG_RCAR_GEN2_SCIFA2 Hi, This is ordered by address. Please keep it so. Thanks.
Hi, Thank you for the review. On Wed, Apr 29, 2020 at 11:00 PM Russell King - ARM Linux admin <linux@armlinux.org.uk> wrote: > > On Wed, Apr 29, 2020 at 10:56:41PM +0100, Lad Prabhakar wrote: > > @@ -1701,6 +1709,7 @@ config DEBUG_UART_PHYS > > default 0xe6e60000 if DEBUG_RCAR_GEN2_SCIF0 > > default 0xe6e68000 if DEBUG_RCAR_GEN2_SCIF1 > > default 0xe6ee0000 if DEBUG_RCAR_GEN2_SCIF4 > > + default 0xe6c60000 if DEBUG_RCAR_GEN2_SCIFA2 > > Hi, > > This is ordered by address. Please keep it so. > Sure will do that. Cheers, --Prabhakar > Thanks. > > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up
Hi Prabhakar, On Wed, Apr 29, 2020 at 11:58 PM Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > Enable low-level debugging support for RZ/G1H (R8A7742). RZ/G1H uses > SCIFA2 for the debug console. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com> Thanks for your patch! > --- a/arch/arm/Kconfig.debug > +++ b/arch/arm/Kconfig.debug > @@ -976,6 +976,13 @@ choice > Say Y here if you want kernel low-level debugging support > via SCIF4 on Renesas RZ/G1E (R8A7745). > > + config DEBUG_RCAR_GEN2_SCIFA2 > + bool "Kernel low-level debugging messages via SCIFA2 on ARCH_R8A7742" R8A7742 (without "ARCH_"-prefix) I can fix that (and the sorting issue) while applying, so Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue in renesas-devel for v5.8. Gr{oetje,eeting}s, Geert
Hi Geert, On Thu, Apr 30, 2020 at 2:03 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Prabhakar, > > On Wed, Apr 29, 2020 at 11:58 PM Lad Prabhakar > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > Enable low-level debugging support for RZ/G1H (R8A7742). RZ/G1H uses > > SCIFA2 for the debug console. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com> > > Thanks for your patch! > > > --- a/arch/arm/Kconfig.debug > > +++ b/arch/arm/Kconfig.debug > > @@ -976,6 +976,13 @@ choice > > Say Y here if you want kernel low-level debugging support > > via SCIF4 on Renesas RZ/G1E (R8A7745). > > > > + config DEBUG_RCAR_GEN2_SCIFA2 > > + bool "Kernel low-level debugging messages via SCIFA2 on ARCH_R8A7742" > > R8A7742 (without "ARCH_"-prefix) > > I can fix that (and the sorting issue) while applying, so > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > i.e. will queue in renesas-devel for v5.8. > Thank you for taking care of that. Cheers, --Prabhakar > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug index f46e18a..d0631e2 100644 --- a/arch/arm/Kconfig.debug +++ b/arch/arm/Kconfig.debug @@ -976,6 +976,13 @@ choice Say Y here if you want kernel low-level debugging support via SCIF4 on Renesas RZ/G1E (R8A7745). + config DEBUG_RCAR_GEN2_SCIFA2 + bool "Kernel low-level debugging messages via SCIFA2 on ARCH_R8A7742" + depends on ARCH_R8A7742 + help + Say Y here if you want kernel low-level debugging support + via SCIFA2 on Renesas RZ/G1H (R8A7742). + config DEBUG_RMOBILE_SCIFA0 bool "Kernel low-level debugging messages via SCIFA0 on R8A73A4" depends on ARCH_R8A73A4 @@ -1577,6 +1584,7 @@ config DEBUG_LL_INCLUDE default "debug/renesas-scif.S" if DEBUG_RCAR_GEN2_SCIF1 default "debug/renesas-scif.S" if DEBUG_RCAR_GEN2_SCIF2 default "debug/renesas-scif.S" if DEBUG_RCAR_GEN2_SCIF4 + default "debug/renesas-scif.S" if DEBUG_RCAR_GEN2_SCIFA2 default "debug/renesas-scif.S" if DEBUG_RMOBILE_SCIFA0 default "debug/renesas-scif.S" if DEBUG_RMOBILE_SCIFA1 default "debug/renesas-scif.S" if DEBUG_RMOBILE_SCIFA4 @@ -1701,6 +1709,7 @@ config DEBUG_UART_PHYS default 0xe6e60000 if DEBUG_RCAR_GEN2_SCIF0 default 0xe6e68000 if DEBUG_RCAR_GEN2_SCIF1 default 0xe6ee0000 if DEBUG_RCAR_GEN2_SCIF4 + default 0xe6c60000 if DEBUG_RCAR_GEN2_SCIFA2 default 0xe8008000 if DEBUG_R7S72100_SCIF2 || DEBUG_R7S9210_SCIF2 default 0xe8009000 if DEBUG_R7S9210_SCIF4 default 0xf0000000 if DEBUG_DIGICOLOR_UA0 @@ -1737,6 +1746,7 @@ config DEBUG_UART_PHYS DEBUG_RCAR_GEN1_SCIF0 || DEBUG_RCAR_GEN1_SCIF2 || \ DEBUG_RCAR_GEN2_SCIF0 || DEBUG_RCAR_GEN2_SCIF1 || \ DEBUG_RCAR_GEN2_SCIF2 || DEBUG_RCAR_GEN2_SCIF4 || \ + DEBUG_RCAR_GEN2_SCIFA2 || \ DEBUG_RMOBILE_SCIFA0 || DEBUG_RMOBILE_SCIFA1 || \ DEBUG_RMOBILE_SCIFA4 || DEBUG_S3C24XX_UART || \ DEBUG_S3C64XX_UART || \