diff mbox

[v2] clk: shmobile: r8a7795: Add INTC-EX clock

Message ID 20160218071403.11935.50948.sendpatchset@little-apple (mailing list archive)
State Accepted
Delegated to: Geert Uytterhoeven
Headers show

Commit Message

Magnus Damm Feb. 18, 2016, 7:14 a.m. UTC 
From: Magnus Damm <damm+renesas@opensource.se>

Add the "intc-ex" clock to the r8a7795 CPG MSSR driver V2.

According to information from the hardware team the INTC_EX
parent clock is CP. The next data sheet version will include
this information.

Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
---

 drivers/clk/shmobile/r8a7795-cpg-mssr.c |    1 +
 1 file changed, 1 insertion(+)

Comments

Geert Uytterhoeven Feb. 18, 2016, 8:01 a.m. UTC | #1 
Hi Magnus,

On Thu, Feb 18, 2016 at 8:14 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
> From: Magnus Damm <damm+renesas@opensource.se>
>
> Add the "intc-ex" clock to the r8a7795 CPG MSSR driver V2.
>
> According to information from the hardware team the INTC_EX
> parent clock is CP. The next data sheet version will include
> this information.

That makes sense, as it matches R-Car Gen2.

> Signed-off-by: Magnus Damm <damm+renesas@opensource.se>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Will queue in clk-shmobile-for-v4.6.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Magnus Damm Feb. 18, 2016, 3:53 p.m. UTC | #2 
Hi Geert,

On Thu, Feb 18, 2016 at 5:01 PM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> Hi Magnus,
>
> On Thu, Feb 18, 2016 at 8:14 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
>> From: Magnus Damm <damm+renesas@opensource.se>
>>
>> Add the "intc-ex" clock to the r8a7795 CPG MSSR driver V2.
>>
>> According to information from the hardware team the INTC_EX
>> parent clock is CP. The next data sheet version will include
>> this information.
>
> That makes sense, as it matches R-Car Gen2.

Yeah I think so too. The other INTC-AP and INTC-RT got their parent
clock updated in Gen3 though, so I somehow assumed that the same
update happened for INTC-EX. But now we know.

>> Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Will queue in clk-shmobile-for-v4.6.

Sweet, thanks for your help!

/ magnus
diff mbox

Patch

--- 0001/drivers/clk/shmobile/r8a7795-cpg-mssr.c
+++ work/drivers/clk/shmobile/r8a7795-cpg-mssr.c	2016-02-18 16:08:25.910513000 +0900
@@ -138,6 +138,7 @@  static const struct mssr_mod_clk r8a7795
 	DEF_MOD("usb3-if0",		 328,	R8A7795_CLK_S3D1),
 	DEF_MOD("usb-dmac0",		 330,	R8A7795_CLK_S3D1),
 	DEF_MOD("usb-dmac1",		 331,	R8A7795_CLK_S3D1),
+	DEF_MOD("intc-ex",		 407,	R8A7795_CLK_CP),
 	DEF_MOD("intc-ap",		 408,	R8A7795_CLK_S3D1),
 	DEF_MOD("audmac0",		 502,	R8A7795_CLK_S3D4),
 	DEF_MOD("audmac1",		 501,	R8A7795_CLK_S3D4),