diff mbox

[1/3] ARM: dts: r7s72100: add ethernet clock to device tree

Message ID 20160901155430.23400-1-chris.brandt@renesas.com (mailing list archive)
State Superseded
Delegated to: Simon Horman
Headers show

Commit Message

Chris Brandt Sept. 1, 2016, 3:54 p.m. UTC
Signed-off-by: Chris Brandt <chris.brandt@renesas.com>
---
 include/dt-bindings/clock/r7s72100-clock.h | 3 +++
 1 file changed, 3 insertions(+)

Comments

Sergei Shtylyov Sept. 1, 2016, 4:30 p.m. UTC | #1
On 09/01/2016 06:54 PM, Chris Brandt wrote:

> Signed-off-by: Chris Brandt <chris.brandt@renesas.com>
> ---
>  include/dt-bindings/clock/r7s72100-clock.h | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/include/dt-bindings/clock/r7s72100-clock.h b/include/dt-bindings/clock/r7s72100-clock.h
> index 5128f4d..3cd8138 100644
> --- a/include/dt-bindings/clock/r7s72100-clock.h
> +++ b/include/dt-bindings/clock/r7s72100-clock.h
> @@ -25,6 +25,9 @@
>  #define R7S72100_CLK_SCIF6	1
>  #define R7S72100_CLK_SCIF7	0
>
> +/* MSTP7 */
> +#define R7S72100_CLK_ETHER	4
> +
>  /* MSTP9 */
>  #define R7S72100_CLK_I2C0	7
>  #define R7S72100_CLK_I2C1	6

    I'd add the MSTP7 clock node itself in the same patch...

MBR, Sergei
Chris Brandt Sept. 1, 2016, 4:38 p.m. UTC | #2
On 09/01/2016, Sergei Shtylyov wrote:
>    I'd add the MSTP7 clock node itself in the same patch...


OK. I tried to look at previous commits to figure out what goes in what patch.


Thanks.

Chris
Sergei Shtylyov Sept. 1, 2016, 4:54 p.m. UTC | #3
On 09/01/2016 07:38 PM, Chris Brandt wrote:

>>    I'd add the MSTP7 clock node itself in the same patch...
>
> OK. I tried to look at previous commits to figure out what goes in what patch.

    There's no single approach here... but it was just that your patch subject 
doesn't seem to correspond well to what the patch does.

> Thanks.
>
> Chris

MBR, Sergei
Geert Uytterhoeven Sept. 1, 2016, 7:35 p.m. UTC | #4
On Thu, Sep 1, 2016 at 5:54 PM, Chris Brandt <chris.brandt@renesas.com> wrote:
> Signed-off-by: Chris Brandt <chris.brandt@renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

But as Sergei mentioned, the addition of mstp7_clks to the .dtsi really belongs
in this patch.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
diff mbox

Patch

diff --git a/include/dt-bindings/clock/r7s72100-clock.h b/include/dt-bindings/clock/r7s72100-clock.h
index 5128f4d..3cd8138 100644
--- a/include/dt-bindings/clock/r7s72100-clock.h
+++ b/include/dt-bindings/clock/r7s72100-clock.h
@@ -25,6 +25,9 @@ 
 #define R7S72100_CLK_SCIF6	1
 #define R7S72100_CLK_SCIF7	0
 
+/* MSTP7 */
+#define R7S72100_CLK_ETHER	4
+
 /* MSTP9 */
 #define R7S72100_CLK_I2C0	7
 #define R7S72100_CLK_I2C1	6